Cleanups

Author: javiercn

src/StaticWebAssetsSdk/Tasks/ApplyCompressionNegotiation.cs

@@ -365,9 +365,9 @@ private void ApplyCompressedEndpointHeaders(List<StaticWebAssetEndpointResponseH
 
     private void ApplyRelatedEndpointCandidateHeaders(List<StaticWebAssetEndpointResponseHeader> headers, StaticWebAssetEndpoint relatedEndpointCandidate, HashSet<string> compressedHeaders)
     {
-        StaticWebAssetEndpointResponseHeader.PopulateFromMetadataValue(relatedEndpointCandidate.ResponseHeadersString, _headersList);
+        StaticWebAssetEndpointResponseHeader.PopulateFromMetadataValue(relatedEndpointCandidate.ResponseHeadersString, _tempHeadersList);
 
-        foreach (var header in _headersList)
+        foreach (var header in _tempHeadersList)
         {
             // We need to keep the headers that are specific to the compressed asset like Content-Length,
             // Last-Modified and ETag. Any other header we should add it.

src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointResponseHeader.cs

@@ -60,7 +60,7 @@ public static void PopulateFromMetadataValue(string value, List<StaticWebAssetEn
         var actualByteCount = _encoder.GetBytes(value, bytes);
         var reader = new Utf8JsonReader(bytes.Slice(0, actualByteCount));
 #else
-        byte[] bytes = rentedBuffer = ArrayPool<byte>.Shared.Rent(maxByteCount);
+        var bytes = rentedBuffer = ArrayPool<byte>.Shared.Rent(maxByteCount);
         var actualByteCount = _encoder.GetBytes(value, 0, value.Length, bytes, 0);
         var reader = new Utf8JsonReader(bytes.AsSpan(0, actualByteCount));
 #endif
@@ -137,7 +137,7 @@ internal static string ToMetadataValue(
         var (buffer, writer) = context;
 
         writer.WriteStartArray();
-        for (int i = 0; i < headers.Count; i++)
+        for (var i = 0; i < headers.Count; i++)
         {
             var header = headers[i];
             writer.WriteStartObject();

src/StaticWebAssetsSdk/Tasks/OverrideHtmlAssetPlaceholders.cs

@@ -43,6 +43,10 @@ public partial class OverrideHtmlAssetPlaceholders : Task
 
     internal static readonly Regex _preloadRegex = new Regex(@"<link\s+rel=""preload""(\s+id=""(?<group>[^""]+)"")?\s*[/]?>");
 
+    // Reusable collections to avoid allocations
+    private readonly List<StaticWebAssetEndpointProperty> _propertiesList = new(10);
+    private readonly List<StaticWebAssetEndpointSelector> _selectorsList = new(4);
+
     public override bool Execute()
     {
         var endpoints = StaticWebAssetEndpoint.FromItemGroup(Endpoints).Where(e => e.AssetFile.EndsWith(".js") || e.AssetFile.EndsWith(".mjs"));
@@ -172,12 +176,18 @@ internal List<ResourceAsset> CreateResourcesFromEndpoints(IEnumerable<StaticWebA
         foreach (var endpoint in endpoints)
         {
             // If there's a selector this means that this is an alternative representation for a resource, so skip it.
-            if (endpoint.Selectors?.Length == 0)
+            // Use the reusable list to check selectors efficiently
+            StaticWebAssetEndpointSelector.PopulateFromMetadataValue(endpoint.SelectorsString, _selectorsList);
+            if (_selectorsList.Count == 0)
             {
                 var resourceAsset = new ResourceAsset(endpoint.Route);
-                for (var i = 0; i < endpoint.EndpointProperties?.Length; i++)
+                
+                // Use the reusable list to avoid allocations
+                StaticWebAssetEndpointProperty.PopulateFromMetadataValue(endpoint.EndpointPropertiesString, _propertiesList);
+                
+                for (var i = 0; i < _propertiesList.Count; i++)
                 {
-                    var property = endpoint.EndpointProperties[i];
+                    var property = _propertiesList[i];
                     if (property.Name.Equals("label", StringComparison.OrdinalIgnoreCase))
                     {
                         resourceAsset.Label = property.Value;

src/StaticWebAssetsSdk/Tasks/ResolveFingerprintedStaticWebAssetEndpointsForAssets.cs

@@ -23,6 +23,9 @@ public class ResolveFingerprintedStaticWebAssetEndpointsForAssets : Task
 
     [Output] public ITaskItem[] ResolvedEndpoints { get; set; }
 
+    // Reusable collection to avoid allocations
+    private readonly List<StaticWebAssetEndpointProperty> _propertiesList = new(10);
+
     public override bool Execute()
     {
         var candidateEndpoints = StaticWebAssetEndpoint.FromItemGroup(CandidateEndpoints);
@@ -96,11 +99,14 @@ public override bool Execute()
         return !Log.HasLoggedErrors;
     }
 
-    private static bool HasFingerprint(StaticWebAssetEndpoint endpoint)
+    private bool HasFingerprint(StaticWebAssetEndpoint endpoint)
     {
-        for (var i = 0; i < endpoint.EndpointProperties.Length; i++)
+        // Use the reusable list to avoid allocations
+        StaticWebAssetEndpointProperty.PopulateFromMetadataValue(endpoint.EndpointPropertiesString, _propertiesList);
+
+        for (var i = 0; i < _propertiesList.Count; i++)
         {
-            var property = endpoint.EndpointProperties[i];
+            var property = _propertiesList[i];
             if (string.Equals(property.Name, "fingerprint", StringComparison.OrdinalIgnoreCase))
             {
                 return true;