Skip to content

Commit 8672d1e

Browse files
authored
Update TestModulesFilterHandler.cs
1 parent 0006c13 commit 8672d1e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/Cli/dotnet/Commands/Test/TestModulesFilterHandler.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ public bool RunWithTestModulesFilter(ParseResult parseResult)
5151
var muxerPath = new Muxer().MuxerPath;
5252
foreach (string testModule in testModulePaths)
5353
{
54+
// We want to produce the right RunCommand and RunArguments for TestApplication implementation to consume directly.
55+
// We don't want TestApplication class to be concerned about whether it's running dll via test module or not.
56+
// If we are given dll, we use dotnet exec. Otherwise, we run the executable directly.
5457
RunProperties runProperties = testModule.HasExtension(CliConstants.DLLExtension)
5558
? new RunProperties(muxerPath, $@"exec ""{testModule}""", null)
5659
: new RunProperties(testModule, null, null);

0 commit comments

Comments
 (0)