lock around the entire dictionary read to prevent read/write out of sync

Author: baronfel

src/Microsoft.Extensions.Logging.MSBuild/MSBuildLoggerProvider.cs

@@ -22,15 +22,15 @@ public MSBuildLoggerProvider(TaskLoggingHelper loggingHelperToWrap)
 
     public ILogger CreateLogger(string categoryName)
     {
-        if (!_loggers.TryGetValue(categoryName, out var logger))
+        lock (_loggers)
         {
-            logger = new MSBuildLogger(categoryName, _loggingHelper, _scopeProvider);
-            lock (_loggers)
+            if (!_loggers.TryGetValue(categoryName, out var logger))
             {
+                logger = new MSBuildLogger(categoryName, _loggingHelper, _scopeProvider);
                 _loggers[categoryName] = logger;
             }
+            return logger;
         }
-        return logger;
     }
 
     public void Dispose() { }

test/Microsoft.NET.Build.Containers.IntegrationTests/PackageTests.cs

@@ -49,7 +49,8 @@ public void SanityTest_NET_Build_ContainersDependencies()
         };
         IReadOnlyList<string> knownProjectReferences = new List<string>()
         {
-            "..\\..\\Cli\\Microsoft.DotNet.Cli.Utils\\Microsoft.DotNet.Cli.Utils.csproj"
+            "..\\..\\Cli\\Microsoft.DotNet.Cli.Utils\\Microsoft.DotNet.Cli.Utils.csproj",
+            "..\\..\\Microsoft.Extensions.Logging.MSBuild\\Microsoft.Extensions.Logging.MSBuild.csproj"
         };
 
         string projectFilePath = Path.Combine(TestContext.Current.TestExecutionDirectory, "Container", "ProjectFiles", "Microsoft.NET.Build.Containers.csproj");