Fix the path check to ensure it correctly handles casing and character codes (#45883)

marcpopMSFT · web-flow · commit 6d5870d7028e · 2025-05-19T12:57:10.000-07:00
diff --git a/src/Tasks/sdk-tasks/ExtractArchiveToDirectory.cs b/src/Tasks/sdk-tasks/ExtractArchiveToDirectory.cs
@@ -186,7 +186,7 @@ private string GetFullDirectoryPathWithSeperator(string directory)
         {
             string fullDirectoryPath = Path.GetFullPath(directory);
 
-            if (!fullDirectoryPath.EndsWith(Path.DirectorySeparatorChar.ToString()))
+            if (!fullDirectoryPath.EndsWith(Path.DirectorySeparatorChar.ToString(), StringComparison.OrdinalIgnoreCase))
             {
                 fullDirectoryPath = string.Concat(fullDirectoryPath, Path.DirectorySeparatorChar);
             }

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ private string GetFullDirectoryPathWithSeperator(string directory)`
`186`	`186`	`{`
`187`	`187`	`string fullDirectoryPath = Path.GetFullPath(directory);`
`188`	`188`
`189`		`- if (!fullDirectoryPath.EndsWith(Path.DirectorySeparatorChar.ToString()))`
	`189`	`+ if (!fullDirectoryPath.EndsWith(Path.DirectorySeparatorChar.ToString(), StringComparison.OrdinalIgnoreCase))`
`190`	`190`	`{`
`191`	`191`	`fullDirectoryPath = string.Concat(fullDirectoryPath, Path.DirectorySeparatorChar);`
`192`	`192`	`}`