Skip to content

Commit 0ea0fd8

Browse files
author
Simon Zhao (BEYONDSOFT CONSULTING INC)
committed
Merge branch 'main' of https://github.com/dotnet/sdk into darc-main-729b9814-ef2d-414d-bd53-62e16a898107
2 parents 43b9047 + 80b4384 commit 0ea0fd8

File tree

22 files changed

+519
-217
lines changed

22 files changed

+519
-217
lines changed

eng/Version.Details.xml

Lines changed: 42 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -189,17 +189,17 @@
189189
<Uri>https://github.com/nuget/nuget.client</Uri>
190190
<Sha>c21ba3b47e224cf84490bdc53b89e7f9ebcc1841</Sha>
191191
</Dependency>
192-
<Dependency Name="Microsoft.NET.Test.Sdk" Version="17.15.0-preview-25359-101">
193-
<Uri>https://github.com/dotnet/dotnet</Uri>
194-
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
192+
<Dependency Name="Microsoft.NET.Test.Sdk" Version="18.0.0-preview-25366-05">
193+
<Uri>https://github.com/microsoft/vstest</Uri>
194+
<Sha>ab6e14292ec4aac0c228a6c75e420f0a0461b0e1</Sha>
195195
</Dependency>
196-
<Dependency Name="Microsoft.TestPlatform.CLI" Version="17.15.0-preview-25359-101">
197-
<Uri>https://github.com/dotnet/dotnet</Uri>
198-
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
196+
<Dependency Name="Microsoft.TestPlatform.CLI" Version="18.0.0-preview-25366-05">
197+
<Uri>https://github.com/microsoft/vstest</Uri>
198+
<Sha>ab6e14292ec4aac0c228a6c75e420f0a0461b0e1</Sha>
199199
</Dependency>
200-
<Dependency Name="Microsoft.TestPlatform.Build" Version="17.15.0-preview-25359-101">
201-
<Uri>https://github.com/dotnet/dotnet</Uri>
202-
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
200+
<Dependency Name="Microsoft.TestPlatform.Build" Version="18.0.0-preview-25366-05">
201+
<Uri>https://github.com/microsoft/vstest</Uri>
202+
<Sha>ab6e14292ec4aac0c228a6c75e420f0a0461b0e1</Sha>
203203
</Dependency>
204204
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="10.0.0-preview.7.25359.101">
205205
<Uri>https://github.com/dotnet/dotnet</Uri>
@@ -225,6 +225,39 @@
225225
<Uri>https://github.com/dotnet/dotnet</Uri>
226226
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
227227
</Dependency>
228+
<!-- Do not use properties based on:
229+
- Microsoft.WindowsDesktop.App.Ref
230+
- Microsoft.WindowsDesktop.App.Internal
231+
- Microsoft.NET.Sdk.WindowsDesktop
232+
- Microsoft.Dotnet.WinForms.ProjectTemplates
233+
- Microsoft.DotNet.Wpf.ProjectTemplates
234+
In VMR builds on non-Windows, they aren't built. Instead, use the following:
235+
- Microsoft.WindowsDesktop.App.Ref - Microsoft.NETCore.App.Ref
236+
- Microsoft.WindowsDesktop.App.Internal - Microsoft.NETCore.Platforms
237+
- Microsoft.NET.Sdk.WindowsDesktop - Microsoft.NETCore.App.Ref
238+
- Microsoft.Dotnet.WinForms.ProjectTemplates - Microsoft.NETCore.Platforms
239+
- Microsoft.DotNet.Wpf.ProjectTemplates - Microsoft.NETCore.Platforms
240+
-->
241+
<Dependency Name="Microsoft.WindowsDesktop.App.Ref" Version="10.0.0-preview.7.25359.101">
242+
<Uri>https://github.com/dotnet/dotnet</Uri>
243+
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
244+
</Dependency>
245+
<Dependency Name="Microsoft.WindowsDesktop.App.Internal" Version="10.0.0-preview.7.25359.101">
246+
<Uri>https://github.com/dotnet/dotnet</Uri>
247+
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
248+
</Dependency>
249+
<Dependency Name="Microsoft.NET.Sdk.WindowsDesktop" Version="10.0.0-preview.7.25359.101">
250+
<Uri>https://github.com/dotnet/dotnet</Uri>
251+
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
252+
</Dependency>
253+
<Dependency Name="Microsoft.Dotnet.WinForms.ProjectTemplates" Version="10.0.0-preview.7.25359.101">
254+
<Uri>https://github.com/dotnet/dotnet</Uri>
255+
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
256+
</Dependency>
257+
<Dependency Name="Microsoft.DotNet.Wpf.ProjectTemplates" Version="10.0.0-preview.7.25359.101">
258+
<Uri>https://github.com/dotnet/dotnet</Uri>
259+
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>
260+
</Dependency>
228261
<Dependency Name="Microsoft.AspNetCore.App.Ref" Version="10.0.0-preview.7.25359.101">
229262
<Uri>https://github.com/dotnet/dotnet</Uri>
230263
<Sha>f451e5d3036a4f140a989e0a7f3f1ae432420e71</Sha>

eng/Versions.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,9 @@
161161
</PropertyGroup>
162162
<PropertyGroup>
163163
<!-- Dependencies from https://github.com/Microsoft/vstest -->
164-
<MicrosoftNETTestSdkPackageVersion>17.15.0-preview-25359-101</MicrosoftNETTestSdkPackageVersion>
165-
<MicrosoftTestPlatformCLIPackageVersion>17.15.0-preview-25359-101</MicrosoftTestPlatformCLIPackageVersion>
166-
<MicrosoftTestPlatformBuildPackageVersion>17.15.0-preview-25359-101</MicrosoftTestPlatformBuildPackageVersion>
164+
<MicrosoftNETTestSdkPackageVersion>18.0.0-preview-25366-05</MicrosoftNETTestSdkPackageVersion>
165+
<MicrosoftTestPlatformCLIPackageVersion>18.0.0-preview-25366-05</MicrosoftTestPlatformCLIPackageVersion>
166+
<MicrosoftTestPlatformBuildPackageVersion>18.0.0-preview-25366-05</MicrosoftTestPlatformBuildPackageVersion>
167167
</PropertyGroup>
168168
<PropertyGroup>
169169
<!-- Dependencies from https://github.com/dotnet/roslyn-analyzers -->

src/Cli/Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
</ItemGroup>
2222

2323
<ItemGroup>
24-
<ProjectReference Include="..\Microsoft.DotNet.InternalAbstractions\Microsoft.DotNet.InternalAbstractions.csproj" />
25-
<ProjectReference Include="..\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj" />
24+
<ProjectReference Include="..\Microsoft.DotNet.InternalAbstractions\Microsoft.DotNet.InternalAbstractions.csproj" GlobalPropertiesToRemove="PublishDir" />
25+
<ProjectReference Include="..\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj" GlobalPropertiesToRemove="PublishDir" />
2626
</ItemGroup>
2727

2828
<ItemGroup>

src/Cli/Microsoft.TemplateEngine.Cli/Microsoft.TemplateEngine.Cli.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
</ItemGroup>
2222

2323
<ItemGroup>
24-
<ProjectReference Include="../Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj" />
25-
<ProjectReference Include="../Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj" />
24+
<ProjectReference Include="../Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj" GlobalPropertiesToRemove="PublishDir" />
25+
<ProjectReference Include="../Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj" GlobalPropertiesToRemove="PublishDir" />
2626
</ItemGroup>
2727

2828
<ItemGroup>

src/Cli/dotnet/Commands/Test/IPC/PipeNameDescription.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,13 @@ internal sealed class PipeNameDescription(string name, bool isDirectory) : IDisp
1212

1313
public string Name { get; } = name;
1414

15-
public void Dispose() => Dispose(true);
16-
17-
public void Dispose(bool disposing)
15+
public void Dispose()
1816
{
1917
if (_disposed)
2018
{
2119
return;
2220
}
2321

24-
if (disposing)
25-
{
26-
// TODO: dispose managed state (managed objects).
27-
}
28-
2922
if (_isDirectory)
3023
{
3124
try

src/Cli/dotnet/dotnet.csproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@
3838
</ItemGroup>
3939

4040
<ItemGroup>
41-
<ProjectReference Include="../Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj" />
42-
<ProjectReference Include="../Microsoft.DotNet.InternalAbstractions/Microsoft.DotNet.InternalAbstractions.csproj" />
43-
<ProjectReference Include="../Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj" />
41+
<ProjectReference Include="../Microsoft.DotNet.Configurer/Microsoft.DotNet.Configurer.csproj" GlobalPropertiesToRemove="PublishDir" />
42+
<ProjectReference Include="../Microsoft.DotNet.InternalAbstractions/Microsoft.DotNet.InternalAbstractions.csproj" GlobalPropertiesToRemove="PublishDir" />
43+
<ProjectReference Include="../Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj" GlobalPropertiesToRemove="PublishDir" />
4444
<!-- override the Microsoft.TemplateEngine.Cli's dependency with the latest Microsoft.DotNet.TemplateLocator -->
45-
<ProjectReference Include="../../Microsoft.DotNet.TemplateLocator\Microsoft.DotNet.TemplateLocator.csproj" />
46-
<ProjectReference Include="../../Resolvers\Microsoft.DotNet.NativeWrapper\Microsoft.DotNet.NativeWrapper.csproj" />
47-
<ProjectReference Include="../../Microsoft.Win32.Msi/Microsoft.Win32.Msi.csproj" />
48-
<ProjectReference Include="..\Microsoft.TemplateEngine.Cli\Microsoft.TemplateEngine.Cli.csproj" />
49-
<ProjectReference Include="..\..\System.CommandLine.StaticCompletions\System.CommandLine.StaticCompletions.csproj" />
45+
<ProjectReference Include="../../Microsoft.DotNet.TemplateLocator\Microsoft.DotNet.TemplateLocator.csproj" GlobalPropertiesToRemove="PublishDir" />
46+
<ProjectReference Include="../../Resolvers\Microsoft.DotNet.NativeWrapper\Microsoft.DotNet.NativeWrapper.csproj" GlobalPropertiesToRemove="PublishDir" />
47+
<ProjectReference Include="../../Microsoft.Win32.Msi/Microsoft.Win32.Msi.csproj" GlobalPropertiesToRemove="PublishDir" />
48+
<ProjectReference Include="..\Microsoft.TemplateEngine.Cli\Microsoft.TemplateEngine.Cli.csproj" GlobalPropertiesToRemove="PublishDir" />
49+
<ProjectReference Include="..\..\System.CommandLine.StaticCompletions\System.CommandLine.StaticCompletions.csproj" GlobalPropertiesToRemove="PublishDir" />
5050
</ItemGroup>
5151

5252
<ItemGroup>

src/Compatibility/ApiDiff/Microsoft.DotNet.ApiDiff/FileOutputDiffGenerator.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,6 @@ public async Task RunAsync(CancellationToken cancellationToken)
155155
_log.LogMessage($"Wrote '{filePath}'.");
156156
}
157157

158-
tableOfContents.AppendLine();
159-
160158
string tableOfContentsFilePath = Path.Combine(_outputFolderPath, $"{_tableOfContentsTitle}.md");
161159

162160
if (_writeToDisk)

src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@
2525
</PropertyGroup>
2626

2727
<ItemGroup>
28-
<ProjectReference Include="..\..\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj" Condition="'$(TargetFramework)' != 'net472'">
28+
<ProjectReference Include="..\..\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj"
29+
Condition="'$(TargetFramework)' != 'net472'"
30+
GlobalPropertiesToRemove="PublishDir">
2931
<!-- This is referenced by the core CLI as well so it doesn't need to be redistributed
3032
in the containers task folder. -->
3133
<IncludeAssets>build</IncludeAssets>

src/Containers/containerize/containerize.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
</ItemGroup>
1818

1919
<ItemGroup>
20-
<ProjectReference Include="..\Microsoft.NET.Build.Containers\Microsoft.NET.Build.Containers.csproj" />
21-
<ProjectReference Include="..\..\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj" />
20+
<ProjectReference Include="..\Microsoft.NET.Build.Containers\Microsoft.NET.Build.Containers.csproj" GlobalPropertiesToRemove="PublishDir" />
21+
<ProjectReference Include="..\..\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj" GlobalPropertiesToRemove="PublishDir" />
2222
</ItemGroup>
2323

2424
<!-- Copy to TestExecutionDirectory for using in integration tests. -->

src/Containers/packaging/package.csproj

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,21 @@
2626
<ItemGroup>
2727
<ProjectReference Include="../Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj"
2828
SetTargetFramework="TargetFramework=$(TargetFramework)"
29-
OutputItemType="ContainerLibraryOutput"/>
29+
OutputItemType="ContainerLibraryOutput"
30+
GlobalPropertiesToRemove="PublishDir"/>
3031

3132
<ProjectReference Include="../Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj"
3233
SetTargetFramework="TargetFramework=$(VSCompatTargetFramework)"
33-
OutputItemType="ContainerLibraryOutputNet472" Condition="'$(DotNetBuildSourceOnly)' != 'true'" />
34+
OutputItemType="ContainerLibraryOutputNet472"
35+
Condition="'$(DotNetBuildSourceOnly)' != 'true'"
36+
GlobalPropertiesToRemove="PublishDir" />
3437

35-
<ProjectReference Include="../containerize/containerize.csproj" PrivateAssets="all" IncludeAssets="runtime" ReferenceOutputAssembly="true" Condition="'$(DotNetBuildSourceOnly)' != 'true'" />
38+
<ProjectReference Include="../containerize/containerize.csproj"
39+
PrivateAssets="all"
40+
IncludeAssets="runtime"
41+
ReferenceOutputAssembly="true"
42+
Condition="'$(DotNetBuildSourceOnly)' != 'true'"
43+
GlobalPropertiesToRemove="PublishDir" />
3644
</ItemGroup>
3745

3846
<Target Name="PreparePackageReleaseNotesFromFile" BeforeTargets="GenerateNuspec">
@@ -53,7 +61,7 @@
5361
$([MSBuild]::ValueOrDefault('%(_AllNet472ContainerTaskDependencies.NuGetPackageId)', '').Contains('Microsoft.Extensions'))
5462
) and
5563
%(_AllNet472ContainerTaskDependencies.NuGetIsFrameworkReference) != true" />
56-
64+
5765
<!-- containerize folder -->
5866
<Content Include="$(OutDir)containerize.dll" Pack="true" PackagePath="containerize/" />
5967
<Content Include="$(OutDir)containerize.runtimeconfig.json" Pack="true" PackagePath="containerize/" />

0 commit comments

Comments
 (0)