Update some comments

Author: yowl

src/coreclr/nativeaot/Runtime/wasm/PalRedhawkWasm.cpp

@@ -224,7 +224,7 @@ void PalGetMaximumStackBounds_MultiThreadedWasm(void** ppStackLowOut, void** ppS
 }
 
 #ifdef TARGET_WASI
-// No-op stubs that assume a single-threaded environment.
+// TODO-LLVM: No-op stubs, maybe when threads are implemented in WASI, we wont have to provide all of these.
 int pthread_mutex_init(pthread_mutex_t *, const pthread_mutexattr_t *)
 {
     return 0;
@@ -292,7 +292,7 @@ pthread_t pthread_self(void)
 
 int pthread_equal(pthread_t, pthread_t)
 {
-    return 1; // only one thread
+    return 1;
 }
 
 int pthread_attr_init(pthread_attr_t *)
@@ -322,10 +322,7 @@ int pthread_attr_setdetachstate(pthread_attr_t *, int)
 
 using Dtor = void(*)(void*);
 
-// Due to a bug in the toolchain, we have to provide an implementation of thread-local destruction.
-// Since this is the single-threaded case, we simply delegate to the static destruction mechanism.
-// Reference: https://github.com/llvm/llvm-project/blob/main/libcxxabi/src/cxa_thread_atexit.cpp.
-//
+// TODO=LLVM: This is a copy of the single threaded implementation.
 extern "C" int __cxa_thread_atexit(Dtor dtor, void* obj, void*)
 {
     struct DtorList

src/libraries/Common/src/Interop/Browser/Interop.Runtime.NativeAOT.cs

@@ -29,12 +29,9 @@ internal static unsafe partial class Runtime
         public static unsafe partial void CancelPromise(IntPtr gcHandle);
 
 #if FEATURE_WASM_MANAGED_THREADS
+        // Required by JavaScript/JSFunctionBinding.cs
         [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_invoke_js_function_send")]
         public static unsafe partial void InvokeJSFunctionSend(nint targetNativeTID, nint functionHandle, nint data);
-        [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_install_js_worker_interop_wrapper")]
-        public static unsafe partial void InstallWebWorkerInterop(nint proxyContextGCHandle, void* beforeSyncJSImport, void* afterSyncJSImport, void* pumpHandler);
-        [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_cancel_promise_post")]
-        public static unsafe partial void CancelPromisePost(nint targetNativeTID, nint taskHolderGCHandle);
         [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_invoke_jsimport_MT")]
         public static unsafe partial void InvokeJSImportSync(nint signature, nint args);
         [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_invoke_jsimport_sync_send")]
@@ -43,10 +40,16 @@ internal static unsafe partial class Runtime
         public static unsafe partial void InvokeJSImportAsyncPost(nint targetNativeTID, nint signature, nint args);
         [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_resolve_or_reject_promise_post")]
         public static unsafe partial void ResolveOrRejectPromisePost(nint targetNativeTID, nint data);
+        [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_install_js_worker_interop_wrapper")]
+        public static unsafe partial void InstallWebWorkerInterop(nint proxyContextGCHandle, void* beforeSyncJSImport, void* afterSyncJSImport, void* pumpHandler);
+        // Required by JavaScript/JSProxyContext.cs
         [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_release_cs_owned_object_post")]
         internal static unsafe partial void ReleaseCSOwnedObjectPost(nint targetNativeTID, nint jsHandle);
         [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_uninstall_js_worker_interop")]
         public static unsafe partial void UninstallWebWorkerInterop();
+        // Required by JavaScript/CancelablePromise.cs
+        [LibraryImport(JSLibrary, EntryPoint = "mono_wasm_cancel_promise_post")]
+        public static unsafe partial void CancelPromisePost(nint targetNativeTID, nint taskHolderGCHandle);
 #endif
 
         #region Not used by NativeAOT

src/mono/browser/runtime/loader/polyfills.ts

@@ -22,6 +22,7 @@ export function verifyEnvironment () {
     mono_assert(ENVIRONMENT_IS_SHELL || typeof globalThis.URL === "function", "This browser/engine doesn't support URL API. Please use a modern version. See also https://aka.ms/dotnet-wasm-features");
     mono_assert(typeof globalThis.BigInt64Array === "function", "This browser/engine doesn't support BigInt64Array API. Please use a modern version. See also https://aka.ms/dotnet-wasm-features");
     if (WasmEnableThreads) {
+        // TODO-LLVM: Comment this check out for now so we can run at least some tests.
         //mono_assert(!ENVIRONMENT_IS_SHELL && !ENVIRONMENT_IS_NODE, "This build of dotnet is multi-threaded, it doesn't support shell environments like V8 or NodeJS. See also https://aka.ms/dotnet-wasm-features");
         mono_assert(globalThis.SharedArrayBuffer !== undefined, "SharedArrayBuffer is not enabled on this page. Please use a modern browser and set Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy http headers. See also https://aka.ms/dotnet-wasm-features");
         mono_assert(typeof globalThis.EventTarget === "function", "This browser/engine doesn't support EventTarget API. Please use a modern version. See also https://aka.ms/dotnet-wasm-features");

src/tests/Common/dirs.proj

@@ -30,6 +30,7 @@
       <DisabledProjects Include="$(TestRoot)nativeaot\SmokeTests\HelloWasm\WasmDebugging.csproj" Condition="'$(TargetOS)' == 'browser' or '$(OS)' == 'Windows_NT' or '$(Configuration)' != 'Debug'" />
       <DisabledProjects Include="$(TestRoot)readytorun\**\*.csproj" Condition="'$(TestBuildMode)' == 'nativeaot'" />
 
+      <!-- TODO-LLVM: Reinstate when more thread support is implemented. -->
       <!-- WaitForPendingFinalizers fails, FinalizeFinalizableObjects is not implemented when WasmEnableThreads. -->
       <DisabledProjects Include="$(TestRoot)nativeaot\SmokeTests\DynamicGenerics\DynamicGenerics.csproj" Condition="'$(WasmEnableThreads)' == 'true'"/>
       <!-- Hangs attemping to create thread. -->