From 25f98a92f1dd3f0c97aae5cb66bdf7fbb3b2856e Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Fri, 17 Oct 2025 11:58:07 -0700 Subject: [PATCH 1/5] Remove pkgproj projects that can be easily replaced by .NET SDK pack support --- eng/Subsets.props | 2 ++ ...Reflection.ReadyToRun.Experimental.pkgproj | 25 -------------- .../Microsoft.ILVerification.pkgproj | 24 -------------- src/coreclr/.nuget/coreclr-packages.proj | 6 ---- .../dotnet-ilverify/DotnetToolSettings.xml | 6 ---- .../dotnet-ilverify/dotnet-ilverify.pkgproj | 33 ------------------- .../ILVerification/ILVerification.csproj | 7 ++++ src/coreclr/tools/ILVerify/ILVerify.csproj | 5 +++ .../ILCompiler.Reflection.ReadyToRun.csproj | 4 +++ 9 files changed, 18 insertions(+), 94 deletions(-) delete mode 100644 src/coreclr/.nuget/ILCompiler.Reflection.ReadyToRun.Experimental/ILCompiler.Reflection.ReadyToRun.Experimental.pkgproj delete mode 100644 src/coreclr/.nuget/Microsoft.ILVerification/Microsoft.ILVerification.pkgproj delete mode 100644 src/coreclr/.nuget/dotnet-ilverify/DotnetToolSettings.xml delete mode 100644 src/coreclr/.nuget/dotnet-ilverify/dotnet-ilverify.pkgproj diff --git a/eng/Subsets.props b/eng/Subsets.props index 42cb024aacc661..627bbeb3e2966e 100644 --- a/eng/Subsets.props +++ b/eng/Subsets.props @@ -463,6 +463,8 @@ $(CoreClrProjectRoot)tools\r2rtest\R2RTest.csproj; $(CoreClrProjectRoot)tools\PdbChecker\PdbChecker.csproj; $(CoreClrProjectRoot)tools\AssemblyChecker\AssemblyChecker.csproj; + $(CoreClrProjectRoot)tools\ILVerify\ILVerify.csproj; + $(CoreClrProjectRoot)tools\ILVerification\ILVerification.csproj; $(ToolsProjectRoot)StressLogAnalyzer\src\StressLogAnalyzer.csproj" Category="clr" Condition="'$(DotNetBuildSourceOnly)' != 'true'"/> - - - - - - $(Platform) - x64 - win7 - win8 - win10 - AnyCPU - - - - - false - - windows;osx;android;linux;freebsd;netbsd;illumos;solaris;haiku - ;$(SupportedPackageOSGroups); - - <_isSupportedOSGroup>true - - - - - <_derivedPackageTargetOSGroup Condition="'$(_derivedPackageTargetOSGroup)' == '' and '$(TargetOS)' != ''">$(TargetOS) - <_derivedPackageTargetOSGroup Condition="'$(_derivedPackageTargetOSGroup)' == ''">linux - - <_isSupportedOSGroup Condition="!$(SupportedPackageOSGroups.Contains(';$(_derivedPackageTargetOSGroup);'))">false - - - - - - <_packageTargetOSGroup>$(_derivedPackageTargetOSGroup) - <_packageTargetOSGroup Condition="'$(_derivedPackageTargetOSGroup)' == 'android'">linux - - - true - $(PackageOutputPath) - - - - true - true - - - - - - - - arm - - - arm - - - arm64 - - - arm64 - - - armel - - - armel - - - - - - arm64 - - - - - - - - - - - - - - - - - - - - x86 - - - - arm64 - - - - - - - amd64 - $(TargetArchitecture) - - - - - <_project Include="@(BuildRID)"> - amd64 - %(Identity) - PackageTargetRuntime=%(Identity);Platform=%(Platform) - - - <_buildRidProjects Include="@(_project->'$(MSBuildProjectName).pkgproj')" /> - - - - - - - - + diff --git a/src/coreclr/.nuget/Directory.Build.targets b/src/coreclr/.nuget/Directory.Build.targets index 520110c8064d67..7d8dc74db872d6 100644 --- a/src/coreclr/.nuget/Directory.Build.targets +++ b/src/coreclr/.nuget/Directory.Build.targets @@ -1,78 +1,4 @@ - - - $(ProductVersion) - - - - $(Version) - $(ProductVersion) - $(VersionPrefix)-$(_PreReleaseLabel).final - - - - - - - - - - - - - runtimes/$(PackageTargetRuntime)/native - - - tools - - - - - - - - - - - - - - - - - - - - - - - - - true - - - - - true - - - - - runtimes/$(PackageTargetRuntime)/native - true - - - - + diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props new file mode 100644 index 00000000000000..f5139a1d63ddcf --- /dev/null +++ b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props @@ -0,0 +1,4 @@ + + false + + diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.targets b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.targets new file mode 100644 index 00000000000000..520110c8064d67 --- /dev/null +++ b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.targets @@ -0,0 +1,78 @@ + + + + + $(ProductVersion) + + + + $(Version) + $(ProductVersion) + $(VersionPrefix)-$(_PreReleaseLabel).final + + + + + + + + + + + + + runtimes/$(PackageTargetRuntime)/native + + + tools + + + + + + + + + + + + + + + + + + + + + + + + + true + + + + + true + + + + + runtimes/$(PackageTargetRuntime)/native + true + + + + + diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.pkgproj b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.pkgproj deleted file mode 100644 index be90c1c8c370c3..00000000000000 --- a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.pkgproj +++ /dev/null @@ -1,43 +0,0 @@ - - - - - MSBuildSdk - Provides support for building IL projects. - - - - - sdk - - - targets - - - - - Microsoft.NET.Sdk.IL.targets.template - $(IntermediateOutputPath)Microsoft.NET.Sdk.IL.targets - - - - - - - - - - - targets - - - - - - diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj new file mode 100644 index 00000000000000..a79df0e1131e85 --- /dev/null +++ b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj @@ -0,0 +1,41 @@ + + + + DotNetSdk + true + false + Provides support for building IL projects. + $(BeforePack);ReplaceTemplateParametersInILTargetsTemplate + $(NoWarn);NU5128;NU5131 + + + + + + + + + + + + + Microsoft.NET.Sdk.IL.targets.template + $(IntermediateOutputPath)Microsoft.NET.Sdk.IL.targets + + + + + + + + + + + + + + diff --git a/src/coreclr/.nuget/coreclr-packages.proj b/src/coreclr/.nuget/coreclr-packages.proj index 4bd9835e5bb6b1..609e6884946c88 100644 --- a/src/coreclr/.nuget/coreclr-packages.proj +++ b/src/coreclr/.nuget/coreclr-packages.proj @@ -1,6 +1,6 @@ - - + + diff --git a/src/coreclr/.nuget/pkgproj.props b/src/coreclr/.nuget/pkgproj.props new file mode 100644 index 00000000000000..ddebcfbac6ea7b --- /dev/null +++ b/src/coreclr/.nuget/pkgproj.props @@ -0,0 +1,134 @@ + + + + + + + + + $(Platform) + x64 + win7 + win8 + win10 + AnyCPU + + + + + false + + windows;osx;android;linux;freebsd;netbsd;illumos;solaris;haiku + ;$(SupportedPackageOSGroups); + + <_isSupportedOSGroup>true + + + + + <_derivedPackageTargetOSGroup Condition="'$(_derivedPackageTargetOSGroup)' == '' and '$(TargetOS)' != ''">$(TargetOS) + <_derivedPackageTargetOSGroup Condition="'$(_derivedPackageTargetOSGroup)' == ''">linux + + <_isSupportedOSGroup Condition="!$(SupportedPackageOSGroups.Contains(';$(_derivedPackageTargetOSGroup);'))">false + + + + + + <_packageTargetOSGroup>$(_derivedPackageTargetOSGroup) + <_packageTargetOSGroup Condition="'$(_derivedPackageTargetOSGroup)' == 'android'">linux + + + true + $(PackageOutputPath) + + + + true + true + + + + + + + + arm + + + arm + + + arm64 + + + arm64 + + + armel + + + armel + + + + + + arm64 + + + + + + + + + + + + + + + + + + + + x86 + + + + arm64 + + + + + + + amd64 + $(TargetArchitecture) + + + + + <_project Include="@(BuildRID)"> + amd64 + %(Identity) + PackageTargetRuntime=%(Identity);Platform=%(Platform) + + + <_buildRidProjects Include="@(_project->'$(MSBuildProjectName).pkgproj')" /> + + + + + + + + + diff --git a/src/coreclr/.nuget/pkgproj.targets b/src/coreclr/.nuget/pkgproj.targets new file mode 100644 index 00000000000000..520110c8064d67 --- /dev/null +++ b/src/coreclr/.nuget/pkgproj.targets @@ -0,0 +1,78 @@ + + + + + $(ProductVersion) + + + + $(Version) + $(ProductVersion) + $(VersionPrefix)-$(_PreReleaseLabel).final + + + + + + + + + + + + + runtimes/$(PackageTargetRuntime)/native + + + tools + + + + + + + + + + + + + + + + + + + + + + + + + true + + + + + true + + + + + runtimes/$(PackageTargetRuntime)/native + true + + + + + From 4da53c9a2c1d6a9f8d883809ce12066a96d3e14b Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Fri, 17 Oct 2025 12:34:41 -0700 Subject: [PATCH 3/5] Remove double import --- src/coreclr/.nuget/pkgproj.props | 2 -- src/coreclr/.nuget/pkgproj.targets | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/coreclr/.nuget/pkgproj.props b/src/coreclr/.nuget/pkgproj.props index ddebcfbac6ea7b..e16e1ddbabe56c 100644 --- a/src/coreclr/.nuget/pkgproj.props +++ b/src/coreclr/.nuget/pkgproj.props @@ -1,6 +1,4 @@ - - diff --git a/src/coreclr/.nuget/pkgproj.targets b/src/coreclr/.nuget/pkgproj.targets index 520110c8064d67..bd88c7268ec2d0 100644 --- a/src/coreclr/.nuget/pkgproj.targets +++ b/src/coreclr/.nuget/pkgproj.targets @@ -1,6 +1,4 @@ - - $(ProductVersion) From a23a186932096935ade96c751917f8e9f9585efa Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Fri, 17 Oct 2025 14:13:09 -0700 Subject: [PATCH 4/5] Cleanup from typos --- src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props | 4 +++- .../.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props index f5139a1d63ddcf..d6194b76463998 100644 --- a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props +++ b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Directory.Build.props @@ -1,4 +1,6 @@ - false + + false + diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj index a79df0e1131e85..0d739b4df02dba 100644 --- a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj +++ b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj @@ -1,7 +1,5 @@ - - DotNetSdk true false Provides support for building IL projects. From 787dded65afcc6dfc221e8d628b05768a811d995 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Fri, 17 Oct 2025 14:23:53 -0700 Subject: [PATCH 5/5] Add a readme file for the IL SDK package --- src/coreclr/.nuget/Microsoft.NET.Sdk.IL/PACKAGE.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 src/coreclr/.nuget/Microsoft.NET.Sdk.IL/PACKAGE.md diff --git a/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/PACKAGE.md b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/PACKAGE.md new file mode 100644 index 00000000000000..684cd9a4c53762 --- /dev/null +++ b/src/coreclr/.nuget/Microsoft.NET.Sdk.IL/PACKAGE.md @@ -0,0 +1,3 @@ +## About + +Provides targets to enable building .NET assemblies from .NET IL source files.