[Android] Fixed selection logic with header/footer in CollectionView #32215
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for intercepting web resource requests in BlazorWebView across iOS, Windows, and Android platforms. The changes enable applications to customize or override resource loading behavior through a new WebResourceRequested event.
Key changes:
- Added a new public API
WebResourceRequestedevent toBlazorWebViewfor intercepting web resource requests - Implemented platform-specific request interception mechanisms for iOS, Windows, and Android
- Fixed iOS-specific issues including deprecated API usage and JavaScript text input panel handling
- Updated localization files across multiple languages
Reviewed Changes
Copilot reviewed 293 out of 3941 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/BlazorWebView/src/Maui/iOS/IOSWebViewManager.cs | Implemented custom text input panel handler and added request interception support |
| src/BlazorWebView/src/Maui/iOS/BlazorWebViewHandler.iOS.cs | Added webview scrolling configuration and request interception logic |
| src/BlazorWebView/src/Maui/Windows/WinUIWebViewManager.cs | Integrated request interception into Windows WebView2 request handling |
| src/BlazorWebView/src/Maui/PublicAPI/*/PublicAPI.Unshipped.txt | Documented new public API surface for WebResourceRequested event |
| src/BlazorWebView/src/Maui/IBlazorWebView.cs | Extended interface to support web request interception |
| src/BlazorWebView/src/Maui/BlazorWebView.cs | Implemented WebResourceRequested event and interface methods |
| src/BlazorWebView/src/Maui/Android/WebKitWebViewClient.cs | Refactored request handling to support interception |
| src/BlazorWebView/src/Maui/Android/BlazorWebViewHandler.Android.cs | Updated type references to use global namespace qualifiers |
| src/BlazorWebView/src/Maui/Android/BlazorWebChromeClient.cs | Updated type references to use global namespace qualifiers |
| src/BlazorWebView/samples/BlazorWpfApp/BlazorWpfApp.csproj | Updated target framework to include Windows SDK version |
| src/BlazorWebView/samples/BlazorWinFormsApp/BlazorWinFormsApp.csproj | Removed unnecessary IsTestProject property |
| src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj | Enabled unsafe blocks and removed unused file link |
| loc/**/templatestrings.json.lcl | Updated localization files with translations and metadata |
| loc/**/MauiGResources.resx.lcl | Added new localized error messages for XAML parsing |
| loc/**/ErrorMessages.resx.lcl | Updated localized error message translations |
| loc/**/StringResources.resx.lcl | Updated localized UI string translations |
Comments suppressed due to low confidence (1)
src/BlazorWebView/src/Maui/BlazorWebView.cs:1
- Corrected spelling of 'ReponseContentNotFound' to 'ResponseContentNotFound'.
using System;
kubaflo
changed the title
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Oct 28, 2025
|
Do we need to update the screenshots ? |
Exactly, it is |
Yes, thanks! Updated |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
Adjusted SelectableItemsViewAdapter to correctly handle selection when header or footer templates are present. Updated Issue21375 test case to include header and footer templates.
github-actions
bot
force-pushed
the
fix-32212
branch
from
e430d0b to
82c908a
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Adjusted SelectableItemsViewAdapter to correctly handle selection when header or footer templates are present. Updated Issue21375 test case to include header and footer templates.
Issues Fixed
Fixes #32212
Regressing PR #29818