Replies: 2 comments 7 replies
-
My personal opinion as a complete outsider: The codebase already requires lots of external libraries and tools, eg. the whole Dotnet SDK. Could we add a dependency on Ionide.ProjInfo.FCS in a standalone project (either in the codebase or outside) which could then be called out-of-process. IMO using an improved and polished version of safesparrow/fsharp-benchmark-generator out-of-process would be useful, and could be used in various scenarios. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'm okay with having it as test dependency, i think we even have it already for some tests. |
Beta Was this translation helpful? Give feedback.
7 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
in safesparrow#1 I've added a (unit/integration) test to verify the behaviour of the parallelization.
As @safesparrow correctly points out, constructing the
FSharpProjectOptions
is going to be a churn over time to maintain.Would the F# team be ok with having Ionide.ProjInfo as a test dependency?
Using Ionide.ProjInfo.FCS might be less convenient because of the FCS NuGet dependency.
Copying the contents of https://github.com/ionide/proj-info/blob/main/src/Ionide.ProjInfo.FCS/Library.fs might be easier to go with.
Thoughts? @vzarytovskii @KevinRansom @dsyme @baronfel
Beta Was this translation helpful? Give feedback.
All reactions