Make attribute target mismatch a warning and not an error. (#18492)

* make attribute targets mismatches a warning and not an error.

* release notes

* update tests

* update baselines

* Update baselines

* Move attribute form logic to an AP

* Fix merge

Author: edgarfgp

docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@@ -54,6 +54,7 @@
 * Warning for "useless null handling" works with piped syntax constructs now ([PR #18331](https://github.com/dotnet/fsharp/pull/18331))
 * Make indent in generated overridden member code depend on the context, not fix to 4. ([PR #18341](https://github.com/dotnet/fsharp/pull/18341))
 * Adjust caller info attribute error message range ([PR #18388](https://github.com/dotnet/fsharp/pull/18388))
+* Make attribute targets mismatch a warning and not an error ([PR #18492](https://github.com/dotnet/fsharp/pull/18492))
 
 ### Breaking Changes
 * Struct unions with overlapping fields now generate mappings needed for reading via reflection ([Issue #18121](https://github.com/dotnet/fsharp/issues/17797), [PR #18274](https://github.com/dotnet/fsharp/pull/17877))

src/Compiler/Checking/Expressions/CheckExpressions.fs

@@ -3187,6 +3187,24 @@ let BuildRecdFieldSet g m objExpr (rfinfo: RecdFieldInfo) argExpr =
     let wrap, objExpr, _readonly, _writeonly = mkExprAddrOfExpr g boxity false DefinitelyMutates objExpr None m
     wrap (mkRecdFieldSetViaExprAddr (objExpr, rfinfo.RecdFieldRef, rfinfo.TypeInst, argExpr, m) )
 
+// This is used to check the target of an attribute with the form of
+// Long Form: [<target:attribute-name(arguments)>]
+// Short Form: [<attribute-name(arguments)>]
+let (|LongFormAttrTarget|UnrecognizedLongAttrTarget|ShortFormAttributeTarget|) (targetIndicator: Ident option) =
+    match targetIndicator with
+    | Some id when id.idText = "assembly" -> LongFormAttrTarget AttributeTargets.Assembly
+    | Some id when id.idText = "module" -> LongFormAttrTarget AttributeTargets.Module
+    | Some id when id.idText = "return" -> LongFormAttrTarget AttributeTargets.ReturnValue
+    | Some id when id.idText = "field" -> LongFormAttrTarget AttributeTargets.Field
+    | Some id when id.idText = "property" -> LongFormAttrTarget AttributeTargets.Property
+    | Some id when id.idText = "method" -> LongFormAttrTarget AttributeTargets.Method
+    | Some id when id.idText = "param" -> LongFormAttrTarget AttributeTargets.Parameter
+    | Some id when id.idText = "type" -> LongFormAttrTarget AttributeTargets.TyconDecl
+    | Some id when id.idText = "constructor" -> LongFormAttrTarget AttributeTargets.Constructor
+    | Some id when id.idText = "event" -> LongFormAttrTarget AttributeTargets.Event
+    | Some id -> UnrecognizedLongAttrTarget id
+    | None -> ShortFormAttributeTarget
+
 //-------------------------------------------------------------------------
 // Helpers dealing with named and optional args at callsites
 //-------------------------------------------------------------------------
@@ -11344,30 +11362,21 @@ and TcAttributeEx canFail (cenv: cenv) (env: TcEnv) attrTgt attrEx (synAttr: Syn
                     (validOnDefault, inheritedDefault)
                 | _ ->
                     (validOnDefault, inheritedDefault)
-        let possibleTgts = enum validOn &&& attrTgt
-        let directedTgts =
+        let attributeTargets = enum validOn &&& attrTgt
+        let directedTargets =
             match targetIndicator with
-            | Some id when id.idText = "assembly" -> AttributeTargets.Assembly
-            | Some id when id.idText = "module" -> AttributeTargets.Module
-            | Some id when id.idText = "return" -> AttributeTargets.ReturnValue
-            | Some id when id.idText = "field" -> AttributeTargets.Field
-            | Some id when id.idText = "property" -> AttributeTargets.Property
-            | Some id when id.idText = "method" -> AttributeTargets.Method
-            | Some id when id.idText = "param" -> AttributeTargets.Parameter
-            | Some id when id.idText = "type" -> AttributeTargets.TyconDecl
-            | Some id when id.idText = "constructor" -> AttributeTargets.Constructor
-            | Some id when id.idText = "event" -> AttributeTargets.Event
-            | Some id ->
-                errorR(Error(FSComp.SR.tcUnrecognizedAttributeTarget(), id.idRange))
-                possibleTgts
-            // mask explicit targets
-            | _ -> possibleTgts &&& ~~~ attrEx
-        let constrainedTgts = possibleTgts &&& directedTgts
-        if constrainedTgts = enum 0 then
-            if (directedTgts = AttributeTargets.Assembly || directedTgts = AttributeTargets.Module) then
+            | LongFormAttrTarget attrTarget -> attrTarget
+            | UnrecognizedLongAttrTarget attrTarget ->
+                errorR(Error(FSComp.SR.tcUnrecognizedAttributeTarget(), attrTarget.idRange))
+                attributeTargets
+            | ShortFormAttributeTarget -> attributeTargets &&& ~~~ attrEx
+      
+        let constrainedTargets = attributeTargets &&& directedTargets
+        if constrainedTargets = enum 0 then
+            if (directedTargets = AttributeTargets.Assembly || directedTargets = AttributeTargets.Module) then
                 error(Error(FSComp.SR.tcAttributeIsNotValidForLanguageElementUseDo(), mAttr))
             else
-                error(Error(FSComp.SR.tcAttributeIsNotValidForLanguageElement(), mAttr))
+                warning(Error(FSComp.SR.tcAttributeIsNotValidForLanguageElement(), mAttr))
 
         match ResolveObjectConstructor cenv.nameResolver env.DisplayEnv mAttr ad ty with
         | Exception _ when canFail = TcCanFail.IgnoreAllErrors || canFail = TcCanFail.IgnoreMemberResoutionError -> [ ], true
@@ -11428,19 +11437,19 @@ and TcAttributeEx canFail (cenv: cenv) (env: TcEnv) attrTgt attrEx (synAttr: Syn
                     if isStruct then error (Error(FSComp.SR.tcCustomAttributeMustBeReferenceType(), m))
                     if args.Length <> ilMethRef.ArgTypes.Length then error (Error(FSComp.SR.tcCustomAttributeArgumentMismatch(), m))
                     let args = args |> List.map mkAttribExpr
-                    Attrib(tcref, ILAttrib ilMethRef, args, namedAttribArgMap, isAppliedToGetterOrSetter, Some constrainedTgts, m)
+                    Attrib(tcref, ILAttrib ilMethRef, args, namedAttribArgMap, isAppliedToGetterOrSetter, Some constrainedTargets, m)
 
                 | Expr.App (InnerExprPat(ExprValWithPossibleTypeInst(vref, _, _, _)), _, _, args, _) ->
                     let args = args |> List.collect (function Expr.Const (Const.Unit, _, _) -> [] | expr -> tryDestRefTupleExpr expr) |> List.map mkAttribExpr
-                    Attrib(tcref, FSAttrib vref, args, namedAttribArgMap, isAppliedToGetterOrSetter, Some constrainedTgts, mAttr)
+                    Attrib(tcref, FSAttrib vref, args, namedAttribArgMap, isAppliedToGetterOrSetter, Some constrainedTargets, mAttr)
 
                 | _ ->
                     error (Error(FSComp.SR.tcCustomAttributeMustInvokeConstructor(), mAttr))
 
             | _ ->
                 error(Error(FSComp.SR.tcAttributeExpressionsMustBeConstructorCalls(), mAttr))
 
-        [ (constrainedTgts, attrib) ], false
+        [ (constrainedTargets, attrib) ], false
 
 and TcAttributesWithPossibleTargetsEx canFail (cenv: cenv) env attrTgt attrEx synAttribs =