Merge branch 'main' into UpdateNuget_14.0

Author: KevinRansom

.config/service-branch-merge.json

@@ -10,8 +10,8 @@
             "ExtraSwitches": "-QuietComments"
         },
         "main": {
-            "MergeToBranch": "release/dev17.14",
+            "MergeToBranch": "release/dev18.0",
             "ExtraSwitches": "-QuietComments"
         }
     }
-}
+}

.github/copilot-instructions.md

@@ -0,0 +1,34 @@
+# GitHub Copilot Instructions for F# Compiler
+
+## Language and Environment
+- Use modern F# with functional-first approach
+- Target .NET Standard 2.0 for compatibility
+- Avoid external dependencies - the codebase is self-contained
+
+## Code Style and Standards
+- Follow [coding standards](docs/coding-standards.md), especially:
+  - Prefer immutability and pure functions
+  - Use consistent naming (see abbreviation guide)
+  - Process complex types recursively with pattern matching
+  - Avoid single-character identifiers except in established patterns
+- This project uses .fsi signature files. When adding a new public API to a namespace/module which will be consumed from other file, add it to the respective .fsi signature file as well
+- Follow [overview](docs/overview.md) for key compiler data formats and representations
+
+## Type System Handling
+- When working with `TType` instances, use appropriate stripping functions:
+  - `stripTyparEqns` - Removes inference equations from type parameters
+  - `stripTyEqns` - Removes type equations and type abbreviations
+  - `stripTyEqnsAndErase` - Also erases compilation representations
+  - Match the appropriate stripper to the context (e.g., display vs compilation)
+  - Check equality with `typeEquiv` after stripping rather than direct comparison
+
+## Core Data Structures
+- Use F# discriminated unions for type representations
+- Respect representation hiding through access control
+- Use `remapX` functions when transforming types across boundaries
+- Be aware of performance implications for recursive type operations
+
+## Documentation and Naming
+- Document public APIs with XML comments
+- Use descriptive function names that indicate transformation direction
+- Follow established naming conventions in error messages

.github/policies/resourceManagement.yml

@@ -0,0 +1,43 @@
+id: 
+name: GitOps.PullRequestIssueManagement
+description: GitOps.PullRequestIssueManagement primitive
+owner: 
+resource: repository
+disabled: false
+where: 
+configuration:
+  resourceManagementConfiguration:
+    eventResponderTasks:
+    - if:
+      - payloadType: Issues
+      - labelAdded:
+          label: Breaking-change
+      then:
+      - addReply:
+          reply: >-
+            Refer to the [.NET SDK breaking change guidelines](https://github.com/dotnet/sdk/blob/main/documentation/project-docs/breaking-change-guidelines.md#required-process-for-all-net-sdk-breaking-changes)
+      description: Add breaking change doc instructions to issue
+    - if:
+      - payloadType: Pull_Request
+      - labelAdded:
+          label: Breaking-change
+      then:
+      - addLabel:
+          label: needs-breaking-change-doc-created
+      - addReply:
+          reply: >-
+            Added `needs-breaking-change-doc-created` label because this PR has the `breaking-change` label. 
+
+
+            When you commit this breaking change:
+
+
+            1. [ ] Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the [breaking change documentation template](https://aka.ms/dotnet/docs/new-breaking-change-issue), then remove this `needs-breaking-change-doc-created` label.
+
+            2. [ ] Ask a committer to mail the `.NET SDK Breaking Change Notification` email list.
+
+
+            You can refer to the [.NET SDK breaking change guidelines](https://github.com/dotnet/sdk/blob/main/documentation/project-docs/breaking-change-guidelines.md)
+      description: Add breaking change instructions to PR.
+onFailure: 
+onSuccess: 

DEVGUIDE.md

@@ -252,6 +252,15 @@ For example:
 module TimeCritical =
 ```
 
+For stress testing async code you can use a custom `FSharp.Test.StressAttribute`.
+For example, applied to a single xUnit test case:
+```fsharp
+[<Theory; Stress(Count = 1000)>]
+```
+it will start it many times at the same time, and execute in parallel.
+
+
+
 
 ### Updating FCS surface area baselines
 

FSharp.Profiles.props

@@ -6,6 +6,16 @@
     <DefineConstants>BUILDING_WITH_LKG;$(DefineConstants)</DefineConstants>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.fsproj' and $(TolerateUnusedBindings) != 'true'">
+    <WarningsAsErrors>1182;$(WarningsAsErrors)</WarningsAsErrors>
+    <WarnOn>1182;$(WarnOn)</WarnOn>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.fsproj' and $(TolerateUnusedBindings) == 'true'">
+    <WarningsNotAsErrors>1182;$(WarningsNotAsErrors)</WarningsNotAsErrors>
+    <NoWarn>1182;$(NoWarn)</NoWarn>
+  </PropertyGroup>
+
   <PropertyGroup Condition="'$(Configuration)' != 'Proto' and '$(BUILDING_USING_DOTNET)' != 'true' and '$(MSBuildProjectExtension)' == '.fsproj'"> <!-- VB.NET does not understand "preview". It only knows "old","older" and "boomer" :-)) (jk)-->
     <LangVersion>preview</LangVersion>
   </PropertyGroup>

FSharpBuild.Directory.Build.props

@@ -27,7 +27,6 @@
     <SymStoreDirectory>$(ArtifactsDir)\SymStore</SymStoreDirectory>
     <ProtoOutputPath>$(ArtifactsDir)\Bootstrap</ProtoOutputPath>
     <ValueTupleImplicitPackageVersion>4.4.0</ValueTupleImplicitPackageVersion>
-    <WarnOn>$(WarnOn);1182</WarnOn>
     <WarningsAsErrors>0025;$(WarningsAsErrors)</WarningsAsErrors>
     <OtherFlags>$(OtherFlags) --nowarn:3384</OtherFlags>
     <OtherFlags>$(OtherFlags) --times --nowarn:75</OtherFlags>

NuGet.config

@@ -8,7 +8,7 @@
     <clear />
     <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
     <!--  Begin: Package sources from DotNet-msbuild-Trusted -->
-    <add key="darc-pub-DotNet-msbuild-Trusted-0ca03f8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-DotNet-msbuild-Trusted-0ca03f84/nuget/v3/index.json" />
+    <add key="darc-pub-DotNet-msbuild-Trusted-7a09d5e" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-DotNet-msbuild-Trusted-7a09d5ee/nuget/v3/index.json" />
     <!--  End: Package sources from DotNet-msbuild-Trusted -->
     <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
     <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />

azure-pipelines-PR.yml

@@ -208,6 +208,11 @@ stages:
         enablePublishBuildAssets: true
         enablePublishUsingPipelines: $(_PublishUsingPipelines)
         enableSourceBuild: true
+        sourceBuildParameters:
+          platforms:
+          - name: 'Managed'
+            container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9'
+            buildArguments: '--source-build'
         enableTelemetry: true
         helixRepo: dotnet/fsharp
         jobs:

azure-pipelines.yml

@@ -103,6 +103,11 @@ extends:
           enablePublishBuildAssets: true
           enablePublishUsingPipelines: $(_PublishUsingPipelines)
           enableSourceBuild: true
+          sourceBuildParameters:
+            platforms:
+            - name: 'Managed'
+              container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9'
+              buildArguments: '--source-build'
           enableTelemetry: true
           helixRepo: dotnet/fsharp
           jobs:

buildtools/fslex/fslex.fsproj

@@ -5,7 +5,8 @@
     <TargetFramework>$(FSharpNetCoreProductTargetFramework)</TargetFramework>
     <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
     <RollForward Condition="'$(BUILDING_USING_DOTNET)' == 'true'">LatestMajor</RollForward>
-    <NoWarn>$(NoWarn);64;1182;1204</NoWarn>         <!--Temporary fix for sourcebuild -->
+    <NoWarn>$(NoWarn);64;1204</NoWarn>  <!--Temporary fix for sourcebuild -->
+    <TolerateUnusedBindings>true</TolerateUnusedBindings>
   </PropertyGroup>
 
   <PropertyGroup>