Fixes reloading files multiple times. Closes #1120 #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrytrinder
force-pushed
the
reload-twice
branch
from
29578eb to
95ce038
Compare
garrytrinder
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the issue of files being reloaded multiple times by implementing a debounce mechanism. Key changes include:
- Introduction of a debounce timer and corresponding lock to throttle file change events.
- Removal of redundant FileSystemWatcher event handlers (Created, Deleted, and Renamed).
- Disposal of the debounce timer in the Dispose method to ensure proper cleanup.
Comments suppressed due to low confidence (2)
dev-proxy-abstractions/BaseLoader.cs:16
- [nitpick] The type 'Lock' is not a standard locking type; if this is a custom implementation, consider renaming it to better convey its purpose, or evaluate using a standard locking primitive such as an object for clarity.
private readonly Lock _debounceLock = new();
dev-proxy-abstractions/BaseLoader.cs:98
- Ensure that the removal of event handlers for Created, Deleted, and Renamed is intentional, as omitting these may lead to missed file reloads if such events are required in the future.
_watcher.Created += File_Changed;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reloading files multiple times. Closes #1120