Implicit cast in pattern matching switch.

[The-Futurist]

Look at this fragment:

  var newnode = statement switch
  {
      JuliaParser.ScopeStatementContext => CreateScopeStatement(statement),
      JuliaParser.StructStatementContext => CreateStructStatement((JuliaParser.StructStatementContext)statement),
      JuliaParser.Proc_statementContext => CreateProcedureStatement((JuliaParser.Proc_statementContext)statement),
      _ => new AstNode()
  };

The first match does not compile but perhaps it could? it seems safe to cast statement to the type automatically - or am I missing something?

[HaloFour]

var newnode = statement switch
  {
      JuliaParser.ScopeStatementContext stmt => CreateScopeStatement(stmt),
      JuliaParser.StructStatementContext stmt => CreateStructStatement(stmt),
      JuliaParser.Proc_statementContext stmt => CreateProcedureStatement(stmt),
      _ => new AstNode()
  };

[The-Futurist]

Perfect !

[333fred]

it seems safe to cast statement to the type automatically - or am I missing something?

It would be a highly breaking change, as it could change what overload resolution determines is the most applicable method for anything that uses statement.