From 2ae2916baa0bb8416b6c9ec6c6593ce3b40ffafe Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 21 Jun 2025 16:09:05 +0000 Subject: [PATCH 1/4] Initial plan for issue From 4002b67b1b9b2ff5dfdcc3faa1d8181337c083fa Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 21 Jun 2025 16:16:37 +0000 Subject: [PATCH 2/4] Quarantine HubConnectionCanSendAndReceiveGroupMessages test Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --- src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs index 46ac0ded803b..1076ffb81f56 100644 --- a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs +++ b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs @@ -52,6 +52,7 @@ public async Task HubConnectionCanSendAndReceiveMessages(HttpTransportType trans } } + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] From 7cf2772299ec32e03bb56c9995150a4042dd957a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 21 Jun 2025 16:22:48 +0000 Subject: [PATCH 3/4] Fix QuarantinedTest attribute placement to follow standard pattern Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --- src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs index 1076ffb81f56..ac9f2058a0ba 100644 --- a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs +++ b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs @@ -52,10 +52,10 @@ public async Task HubConnectionCanSendAndReceiveMessages(HttpTransportType trans } } - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] public async Task HubConnectionCanSendAndReceiveGroupMessages(HttpTransportType transportType, string protocolName) { using (StartVerifiableLog()) From a6091435a36536ef3598784901ec5ad7a6e87cc4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 21 Jun 2025 19:12:36 +0000 Subject: [PATCH 4/4] Quarantine all five Redis end-to-end tests with issue #62435 Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --- src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs index ac9f2058a0ba..f3501fb69c1e 100644 --- a/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs +++ b/src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs @@ -35,6 +35,7 @@ public RedisEndToEndTests(RedisServerFixture serverFixture) [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] public async Task HubConnectionCanSendAndReceiveMessages(HttpTransportType transportType, string protocolName) { using (StartVerifiableLog()) @@ -117,6 +118,7 @@ public async Task CanSendAndReceiveUserMessagesFromMultipleConnectionsWithSameUs [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] public async Task CanSendAndReceiveUserMessagesWhenOneConnectionWithUserDisconnects(HttpTransportType transportType, string protocolName) { // Regression test: @@ -146,6 +148,7 @@ public async Task CanSendAndReceiveUserMessagesWhenOneConnectionWithUserDisconne [ConditionalTheory] [SkipIfDockerNotPresent] [MemberData(nameof(TransportTypesAndProtocolTypes))] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] public async Task HubConnectionCanSendAndReceiveGroupMessagesGroupNameWithPatternIsTreatedAsLiteral(HttpTransportType transportType, string protocolName) { using (StartVerifiableLog()) @@ -214,6 +217,7 @@ public async Task CanSendAndReceiveUserMessagesUserNameWithPatternIsTreatedAsLit [SkipIfDockerNotPresent] [InlineData("messagepack")] [InlineData("json")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/62435")] public async Task StatefulReconnectPreservesMessageFromOtherServer(string protocolName) { using (StartVerifiableLog())