Skip to content

Evaluate if changes are needed for ServiceKeyLookupMode #62054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ericstj opened this issue May 21, 2025 · 1 comment
Open

Evaluate if changes are needed for ServiceKeyLookupMode #62054

ericstj opened this issue May 21, 2025 · 1 comment
Labels
area-blazor Includes: Blazor, Razor Components area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-signalr Includes: SignalR clients and servers
Milestone
.NET 10 Planning

Comments

@ericstj
Copy link
Member

ericstj commented May 21, 2025

See https://github.com/dotnet/dotnet/pull/644/files#r2100901895

dotnet/runtime#114929 added support for ServiceKeyLookupMode since AspNetCore is reading this attribute and consuming the key value it may need to have different behavior for ServiceKeyLookupMode.InheritKey vs ServiceKeyLookupMode.NullKey. Let this issue track investigating that and adding any necessary tests.
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 21, 2025
@ericstj ericstj mentioned this issue May 21, 2025
Merged
@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-signalr Includes: SignalR clients and servers area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels May 21, 2025
@BrennanConroy BrennanConroy added the area-blazor Includes: Blazor, Razor Components label May 22, 2025
@javiercn
Copy link
Member

@ericstj I'm not supper familiar with this area, but let me see if my thinking is correct.

  • This affects Get(Required)KeyedService calls within the framework.
  • The behavior is about whether when resolving a Keyed service dependencies also use the same key during resolution.

Am I understanding this correctly?

@ilonatommy ilonatommy added this to the .NET 10 Planning milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
.NET 10 Planning
Development

No branches or pull requests
5 participants
@captainsafia @javiercn @BrennanConroy @ericstj @ilonatommy