Skip to content

Commit e5ab127

Browse files
authored
Update OAuth providers #4684 (#25112)
1 parent 112d821 commit e5ab127

File tree

6 files changed

+14
-13
lines changed

6 files changed

+14
-13
lines changed

src/Security/Authentication/Facebook/src/FacebookDefaults.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ public static class FacebookDefaults
1010
public static readonly string DisplayName = "Facebook";
1111

1212
// https://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow#login
13-
public static readonly string AuthorizationEndpoint = "https://www.facebook.com/v4.0/dialog/oauth";
13+
public static readonly string AuthorizationEndpoint = "https://www.facebook.com/v8.0/dialog/oauth";
1414

15-
public static readonly string TokenEndpoint = "https://graph.facebook.com/v4.0/oauth/access_token";
15+
public static readonly string TokenEndpoint = "https://graph.facebook.com/v8.0/oauth/access_token";
1616

17-
public static readonly string UserInformationEndpoint = "https://graph.facebook.com/v4.0/me";
17+
public static readonly string UserInformationEndpoint = "https://graph.facebook.com/v8.0/me";
1818
}
1919
}

src/Security/Authentication/Google/src/GoogleDefaults.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ public static class GoogleDefaults
1414

1515
public static readonly string DisplayName = "Google";
1616

17-
// https://developers.google.com/identity/protocols/OAuth2WebServer
17+
// https://developers.google.com/identity/protocols/oauth2/web-server#httprest
1818
public static readonly string AuthorizationEndpoint = "https://accounts.google.com/o/oauth2/v2/auth";
1919

20-
public static readonly string TokenEndpoint = "https://www.googleapis.com/oauth2/v4/token";
20+
public static readonly string TokenEndpoint = "https://oauth2.googleapis.com/token";
2121

2222
// https://developers.google.com/apis-explorer/#search/oauth2/oauth2/v2/
2323
public static readonly string UserInformationEndpoint = "https://www.googleapis.com/oauth2/v2/userinfo";

src/Security/Authentication/OpenIdConnect/samples/OpenIdConnectSample/Startup.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void ConfigureServices(IServiceCollection services)
110110
o.Authority = Configuration["oidc:authority"];
111111
*/
112112
// https://github.com/IdentityServer/IdentityServer4.Demo/blob/master/src/IdentityServer4Demo/Config.cs
113-
o.ClientId = "server.hybrid";
113+
o.ClientId = "hybrid";
114114
o.ClientSecret = "secret"; // for code flow
115115
o.Authority = "https://demo.identityserver.io/";
116116

src/Security/Authentication/samples/SocialSample/Startup.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void ConfigureServices(IServiceCollection services)
117117
})
118118
// You must first create an app with GitHub and add its ID and Secret to your user-secrets.
119119
// https://github.com/settings/applications/
120-
// https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/
120+
// https://docs.github.com/en/developers/apps/authorizing-oauth-apps
121121
.AddOAuth("GitHub", "Github", o =>
122122
{
123123
o.ClientId = Configuration["github:clientid"];
@@ -156,7 +156,7 @@ public void ConfigureServices(IServiceCollection services)
156156
})
157157
// You must first create an app with GitHub and add its ID and Secret to your user-secrets.
158158
// https://github.com/settings/applications/
159-
// https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/
159+
// https://docs.github.com/en/developers/apps/authorizing-oauth-apps
160160
.AddOAuth("GitHub-AccessToken", "GitHub AccessToken only", o =>
161161
{
162162
o.ClientId = Configuration["github-token:clientid"];
@@ -171,9 +171,10 @@ public void ConfigureServices(IServiceCollection services)
171171
};
172172
})
173173
// https://demo.identityserver.io/
174+
// https://github.com/IdentityServer/IdentityServer4.Demo/blob/master/src/IdentityServer4Demo/Config.cs
174175
.AddOAuth("IdentityServer", "Identity Server", o =>
175176
{
176-
o.ClientId = "server.code";
177+
o.ClientId = "interactive.public";
177178
o.ClientSecret = "secret";
178179
o.CallbackPath = new PathString("/signin-identityserver");
179180
o.AuthorizationEndpoint = "https://demo.identityserver.io/connect/authorize";

src/Security/Authentication/test/FacebookTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ public async Task NestedMapWillNotAffectRedirect()
233233
var transaction = await server.SendAsync("http://example.com/base/login");
234234
Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode);
235235
var location = transaction.Response.Headers.Location.AbsoluteUri;
236-
Assert.Contains("https://www.facebook.com/v4.0/dialog/oauth", location);
236+
Assert.Contains("https://www.facebook.com/v8.0/dialog/oauth", location);
237237
Assert.Contains("response_type=code", location);
238238
Assert.Contains("client_id=", location);
239239
Assert.Contains("redirect_uri=" + UrlEncoder.Default.Encode("http://example.com/base/signin-facebook"), location);
@@ -266,7 +266,7 @@ public async Task MapWillNotAffectRedirect()
266266
var transaction = await server.SendAsync("http://example.com/login");
267267
Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode);
268268
var location = transaction.Response.Headers.Location.AbsoluteUri;
269-
Assert.Contains("https://www.facebook.com/v4.0/dialog/oauth", location);
269+
Assert.Contains("https://www.facebook.com/v8.0/dialog/oauth", location);
270270
Assert.Contains("response_type=code", location);
271271
Assert.Contains("client_id=", location);
272272
Assert.Contains("redirect_uri=" + UrlEncoder.Default.Encode("http://example.com/signin-facebook"), location);
@@ -301,7 +301,7 @@ public async Task ChallengeWillTriggerRedirection()
301301
var transaction = await server.SendAsync("http://example.com/challenge");
302302
Assert.Equal(HttpStatusCode.Redirect, transaction.Response.StatusCode);
303303
var location = transaction.Response.Headers.Location.AbsoluteUri;
304-
Assert.Contains("https://www.facebook.com/v4.0/dialog/oauth", location);
304+
Assert.Contains("https://www.facebook.com/v8.0/dialog/oauth", location);
305305
Assert.Contains("response_type=code", location);
306306
Assert.Contains("client_id=", location);
307307
Assert.Contains("redirect_uri=", location);

src/Security/Authentication/test/GoogleTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,7 @@ private HttpMessageHandler CreateBackchannel()
10201020
{
10211021
Sender = req =>
10221022
{
1023-
if (req.RequestUri.AbsoluteUri == "https://www.googleapis.com/oauth2/v4/token")
1023+
if (req.RequestUri.AbsoluteUri == "https://oauth2.googleapis.com/token")
10241024
{
10251025
return ReturnJsonResponse(new
10261026
{

0 commit comments

Comments
 (0)