Fixing IIS Tests (#5682)

Author: jkotalik

build/dependencies.props

@@ -130,6 +130,7 @@
     <MicrosoftAspNetCoreAspNetCoreModuleStablePackageVersion>2.2.0</MicrosoftAspNetCoreAspNetCoreModuleStablePackageVersion>
     <MicrosoftAspNetCoreAspNetCoreModuleV2StablePackageVersion>2.2.0</MicrosoftAspNetCoreAspNetCoreModuleV2StablePackageVersion>
     <MicrosoftAspNetIdentityEntityFrameworkPackageVersion>2.2.1</MicrosoftAspNetIdentityEntityFrameworkPackageVersion>
+    <MicrosoftAspNetCoreServerIISStablePackageVersion>2.2.0</MicrosoftAspNetCoreServerIISStablePackageVersion>
     <MicrosoftAspNetWebApiClientPackageVersion>5.2.6</MicrosoftAspNetWebApiClientPackageVersion>
     <MicrosoftAzureDocumentDBCorePackageVersion>1.7.1</MicrosoftAzureDocumentDBCorePackageVersion>
     <MicrosoftAzureKeyVaultPackageVersion>2.3.2</MicrosoftAzureKeyVaultPackageVersion>

src/DefaultBuilder/test/Microsoft.AspNetCore.FunctionalTests/Microsoft.AspNetCore.FunctionalTests.csproj

@@ -18,5 +18,6 @@
     <Reference Include="Microsoft.AspNetCore" />
     <Reference Include="Microsoft.AspNetCore.Server.IntegrationTesting" />
     <Reference Include="Microsoft.AspNetCore.Server.IntegrationTesting.IIS" />
+    <Reference Include="Microsoft.Extensions.Logging.Testing" />
   </ItemGroup>
 </Project>

src/Servers/IIS/ResolveIisReferences.targets

@@ -16,7 +16,7 @@ with the right MSBuild incantations to get output copied to the right place.
       <ItemGroup Condition=" '@(Reference->AnyHaveMetadataValue('Identity', 'AspNetCoreModuleV2'))' == 'true' ">
         <Reference Remove="AspNetCoreModuleV2" />
         <NativeProjectReference Include="$(MSBuildThisFileDirectory)src\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj" />
-        <NativeProjectReference Include="$(MSBuildThisFileDirectory)src\AspNetCoreModuleV2\OutOfProcessRequestHandler\OutOfProcessRequestHandler.vcxproj" />
+        <NativeProjectReference Include="$(MSBuildThisFileDirectory)src\AspNetCoreModuleV2\OutOfProcessRequestHandler\OutOfProcessRequestHandler.vcxproj" HandlerPath="2.0.0" />
         <NativeProjectReference Include="$(MSBuildThisFileDirectory)src\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj" />
       </ItemGroup>
 
@@ -26,7 +26,7 @@ with the right MSBuild incantations to get output copied to the right place.
           <!-- Set the arch-->
           <SetPlatform>Platform=x64</SetPlatform>
           <!-- The base path for the output. -->
-          <LinkBase>x64\</LinkBase>
+          <LinkBase>x64\%(HandlerPath)\</LinkBase>
           <!-- This reference assembly doesn't need -->
           <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
           <!-- NativeContent is a custom type of item group which is assigned a target path after project references are resolved.  -->
@@ -48,7 +48,7 @@ with the right MSBuild incantations to get output copied to the right place.
           <!-- Set the arch-->
           <SetPlatform>Platform=x86</SetPlatform>
           <!-- The base path for the output. -->
-          <LinkBase>x86\</LinkBase>
+          <LinkBase>x86\%(HandlerPath)\</LinkBase>
           <!-- This reference assembly doesn't need -->
           <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
           <!-- NativeContent is a custom type of item group which is assigned a target path after project references are resolved.  -->

src/Servers/IIS/src/Microsoft.AspNetCore.Server.IIS/Microsoft.AspNetCore.Server.IIS.csproj

@@ -19,9 +19,16 @@
     <Content Include="$(PackageId).targets" PackagePath="build/$(TargetFramework)/" />
   </ItemGroup>
 
+  <Target Name="ValidateNativeComponentsBuilt" AfterTargets="Build" >
+    <Error Text="Required dll from ANCM has not been built. To build ANCM, you must use MSBuild.exe."
+        Condition="'$(OS)' == 'Windows_NT' AND !Exists('$(AspNetCoreModuleV2InProcessHandlerDll)')" />
+  </Target>
+
+  <ItemGroup Condition="'$(OS)' == 'Windows_NT' AND '$(VCTargetsPath)' != ''">
+    <NativeProjectReference Include="$(MSBuildThisFileDirectory)..\AspNetCoreModuleV2\InProcessRequestHandler\InProcessRequestHandler.vcxproj" />
+  </ItemGroup>
+
   <ItemGroup>
-    <Reference Include="AspNetCoreModule" Condition="'$(OS)' == 'Windows_NT'" />
-    <Reference Include="AspNetCoreModuleV2" Condition="'$(OS)' == 'Windows_NT'" />
     <Reference Include="Microsoft.AspNetCore.Authentication.Core" />
     <Reference Include="Microsoft.AspNetCore.Connections.Abstractions" />
     <Reference Include="Microsoft.AspNetCore.Hosting.Abstractions" />

src/Servers/IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj

@@ -13,10 +13,25 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <Import Project="..\..\build\assets.props" />
+
   <ItemGroup>
     <EmbeddedResource Include="Http.config" />
   </ItemGroup>
 
+  <Target Name="ValidateNativeComponentsBuilt" AfterTargets="Build" Condition="'$(OS)' == 'Windows_NT'">
+    <Error Text="Required dll from ANCM has not been built. To build ANCM, you must use MSBuild.exe."
+          Condition="!Exists('$(AspNetCoreModuleV1ShimDll)')
+            OR !Exists('$(AspNetCoreModuleV2ShimDll)')
+            OR !Exists('$(AspNetCoreModuleV2OutOfProcessHandlerDll)')" />
+  </Target>
+
+  <ItemGroup Condition="'$(OS)' == 'Windows_NT' AND '$(VCTargetsPath)' != ''">
+    <NativeProjectReference Include="$(MSBuildThisFileDirectory)..\AspNetCoreModuleV1\AspNetCore\AspNetCore.vcxproj" />
+    <NativeProjectReference Include="$(MSBuildThisFileDirectory)..\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj" />
+    <NativeProjectReference Include="$(MSBuildThisFileDirectory)..\AspNetCoreModuleV2\OutOfProcessRequestHandler\OutOfProcessRequestHandler.vcxproj" HandlerPath="2.0.0" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="$(RepositoryRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
     <Reference Include="Microsoft.NETCore.Windows.ApiSets" />

src/Servers/IIS/test/Common.FunctionalTests/Utilities/Helpers.cs

@@ -25,7 +25,7 @@ public static class Helpers
 
         public static string GetTestWebSitePath(string name)
         {
-            return Path.Combine(TestPathUtilities.GetSolutionRootDirectory("IISIntegration"),"test", "WebSites", name);
+            return Path.Combine(TestPathUtilities.GetSolutionRootDirectory("IISIntegration"),"test", "testassets", name);
         }
 
         public static string GetInProcessTestSitesPath()

src/Servers/IIS/test/Common.FunctionalTests/Utilities/IISTestSiteFixture.cs

@@ -50,7 +50,7 @@ public IISTestSiteFixture() : this(_ => { })
         {
         }
 
-        public IISTestSiteFixture(Action<IISDeploymentParameters> configure)
+        internal IISTestSiteFixture(Action<IISDeploymentParameters> configure)
         {
             var logging = AssemblyTestLog.ForAssembly(typeof(IISTestSiteFixture).Assembly);
             _loggerFactory = logging.CreateLoggerFactory(null, nameof(IISTestSiteFixture));

src/Servers/IIS/test/IIS.BackwardsCompatibility.FunctionalTests/BackwardsCompatibilityTests.cs

@@ -29,7 +29,7 @@ public async Task CheckBackwardsCompatibilityIsUsed()
             {
                 if (handle.ModuleName == "aspnetcorev2.dll")
                 {
-                    Assert.Equal("12.2.18287.0", handle.FileVersionInfo.FileVersion);
+                    Assert.Equal("12.2.18316.0", handle.FileVersionInfo.FileVersion);
                     return;
                 }
             }

src/Servers/IIS/test/IIS.ForwardsCompatibility.FunctionalTests/ForwardsCompatibilityTests.cs

@@ -28,7 +28,7 @@ public async Task CheckForwardsCompatibilityIsUsed()
             {
                 if (handle.ModuleName == "aspnetcorev2_inprocess.dll")
                 {
-                    Assert.Equal("12.2.18287.0", handle.FileVersionInfo.FileVersion);
+                    Assert.Equal("12.2.18316.0", handle.FileVersionInfo.FileVersion);
                     return;
                 }
             }

src/Servers/IIS/test/IIS.Tests/Utilities/TestServer.cs

@@ -31,7 +31,8 @@ public class TestServer: IDisposable, IStartup
         private const string HWebCoreDll = "hwebcore.dll";
 
         internal static string HostableWebCoreLocation => Environment.ExpandEnvironmentVariables($@"%windir%\system32\inetsrv\{HWebCoreDll}");
-        internal static string BasePath => Path.GetDirectoryName(new Uri(typeof(TestServer).Assembly.CodeBase).AbsolutePath);
+        internal static string BasePath => Path.Combine(Path.GetDirectoryName(new Uri(typeof(TestServer).Assembly.CodeBase).AbsolutePath),
+                                                        Environment.Is64BitProcess ? "x64" : "x86");
 
         internal static string AspNetCoreModuleLocation => Path.Combine(BasePath, AspNetCoreModuleDll);