PR feedback and clean up

Author: JamesNK

src/Http/Http.Extensions/src/DisableHttpMetricsAttribute.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics;
 using Microsoft.AspNetCore.Http.Metadata;
 
 namespace Microsoft.AspNetCore.Http;
@@ -9,6 +10,12 @@ namespace Microsoft.AspNetCore.Http;
 /// Specifies that HTTP request duration metrics is disabled for an endpoint.
 /// </summary>
 [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class)]
+[DebuggerDisplay("{ToString(),nq}")]
 public sealed class DisableHttpMetricsAttribute : Attribute, IDisableHttpMetricsMetadata
 {
+    /// <inheritdoc/>
+    public override string ToString()
+    {
+        return "DisableHttpMetrics";
+    }
 }

src/Http/Http.Extensions/src/EndpointDescriptionAttribute.cs

@@ -29,7 +29,7 @@ public EndpointDescriptionAttribute(string description)
     /// <inheritdoc />
     public string Description { get; }
 
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return $"Description: {Description ?? "(null)"}";

src/Http/Http.Extensions/src/EndpointSummaryAttribute.cs

@@ -26,7 +26,7 @@ public EndpointSummaryAttribute(string summary)
     /// <inheritdoc />
     public string Summary { get; }
 
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return DebuggerHelpers.GetDebugText(nameof(Summary), Summary);

src/Http/Http.Extensions/src/HttpMetricsEndpointConventionBuilderExtensions.cs

@@ -10,6 +10,8 @@ namespace Microsoft.AspNetCore.Builder;
 /// </summary>
 public static class HttpMetricsEndpointConventionBuilderExtensions
 {
+    private static readonly DisableHttpMetricsAttribute _disableHttpMetricsAttribute = new DisableHttpMetricsAttribute();
+
     /// <summary>
     /// Specifies that HTTP request duration metrics is disabled for an endpoint.
     /// </summary>
@@ -18,7 +20,7 @@ public static class HttpMetricsEndpointConventionBuilderExtensions
     /// <returns>The original convention builder parameter.</returns>
     public static TBuilder DisableHttpMetrics<TBuilder>(this TBuilder builder) where TBuilder : IEndpointConventionBuilder
     {
-        builder.Add(b => b.Metadata.Add(new DisableHttpMetricsAttribute()));
+        builder.Add(b => b.Metadata.Add(_disableHttpMetricsAttribute));
         return builder;
     }
 }

src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt

@@ -3,4 +3,5 @@ Microsoft.AspNetCore.Http.HttpValidationProblemDetails.HttpValidationProblemDeta
 Microsoft.AspNetCore.Builder.HttpMetricsEndpointConventionBuilderExtensions
 Microsoft.AspNetCore.Http.DisableHttpMetricsAttribute
 Microsoft.AspNetCore.Http.DisableHttpMetricsAttribute.DisableHttpMetricsAttribute() -> void
+override Microsoft.AspNetCore.Http.DisableHttpMetricsAttribute.ToString() -> string!
 static Microsoft.AspNetCore.Builder.HttpMetricsEndpointConventionBuilderExtensions.DisableHttpMetrics<TBuilder>(this TBuilder builder) -> TBuilder

src/Http/Http/src/PublicAPI.Unshipped.txt

@@ -1 +1,2 @@
 #nullable enable
+override Microsoft.AspNetCore.Http.Timeouts.DisableRequestTimeoutAttribute.ToString() -> string!

src/Http/Http/src/Timeouts/DisableRequestTimeoutAttribute.cs

@@ -1,6 +1,8 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics;
+
 namespace Microsoft.AspNetCore.Http.Timeouts;
 
 /// <summary>
@@ -10,6 +12,12 @@ namespace Microsoft.AspNetCore.Http.Timeouts;
 /// Completely disables the request timeouts middleware from applying to this endpoint.
 /// </remarks>
 [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class)]
+[DebuggerDisplay("{ToString(),nq}")]
 public sealed class DisableRequestTimeoutAttribute : Attribute
 {
+    /// <inheritdoc/>
+    public override string ToString()
+    {
+        return "DisableRequestTimeout";
+    }
 }

src/Http/Routing/src/ExcludeFromDescriptionAttribute.cs

@@ -17,7 +17,7 @@ public sealed class ExcludeFromDescriptionAttribute : Attribute, IExcludeFromDes
     /// <inheritdoc />
     public bool ExcludeFromDescription => true;
 
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return DebuggerHelpers.GetDebugText(nameof(ExcludeFromDescription), ExcludeFromDescription);

src/Middleware/CORS/src/DisableCorsAttribute.cs

@@ -11,7 +11,7 @@ namespace Microsoft.AspNetCore.Cors;
 [DebuggerDisplay("{ToString(),nq}")]
 public class DisableCorsAttribute : Attribute, IDisableCorsAttribute
 {
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return "CORS Disable";

src/Middleware/CORS/src/EnableCorsAttribute.cs

@@ -33,7 +33,7 @@ public EnableCorsAttribute(string? policyName)
     /// <inheritdoc />
     public string? PolicyName { get; set; }
 
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return DebuggerHelpers.GetDebugText(nameof(PolicyName), PolicyName, prefix: "CORS");

src/Security/Authorization/Core/src/AllowAnonymousAttribute.cs

@@ -13,7 +13,7 @@ namespace Microsoft.AspNetCore.Authorization;
 [DebuggerDisplay("{ToString(),nq}")]
 public class AllowAnonymousAttribute : Attribute, IAllowAnonymous
 {
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return "AllowAnonymous";

src/Security/Authorization/Core/src/AuthorizeAttribute.cs

@@ -43,7 +43,7 @@ public AuthorizeAttribute(string policy)
     /// </summary>
     public string? AuthenticationSchemes { get; set; }
 
-    /// <inheritdoc/>>
+    /// <inheritdoc/>
     public override string ToString()
     {
         return DebuggerHelpers.GetDebugText(nameof(Policy), Policy, nameof(Roles), Roles, nameof(AuthenticationSchemes), AuthenticationSchemes, includeNullValues: false, prefix: "Authorize");