Merge fixes

John Luo · John Luo · commit c2aa2957f6ce · 2019-01-14T14:13:40.000-08:00
diff --git a/eng/Baseline.Designer.props b/eng/Baseline.Designer.props
@@ -754,15 +754,15 @@
   </ItemGroup>
   <!-- Package: Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-->
   <PropertyGroup Condition=" '$(PackageId)' == 'Microsoft.AspNetCore.Mvc.Razor.ViewCompilation' ">
-    <BaselinePackageVersion>2.1.1</BaselinePackageVersion>
+    <BaselinePackageVersion>2.2.0</BaselinePackageVersion>
   </PropertyGroup>
   <ItemGroup Condition=" '$(PackageId)' == 'Microsoft.AspNetCore.Mvc.Razor.ViewCompilation' AND '$(TargetFramework)' == 'net461' ">
-    <BaselinePackageReference Include="Microsoft.AspNetCore.Hosting" Version="[2.1.1, )" />
-    <BaselinePackageReference Include="Microsoft.AspNetCore.Mvc.RazorPages" Version="[2.1.1, )" />
+    <BaselinePackageReference Include="Microsoft.AspNetCore.Hosting" Version="[2.2.0, )" />
+    <BaselinePackageReference Include="Microsoft.AspNetCore.Mvc.RazorPages" Version="[2.2.0, )" />
   </ItemGroup>
   <ItemGroup Condition=" '$(PackageId)' == 'Microsoft.AspNetCore.Mvc.Razor.ViewCompilation' AND '$(TargetFramework)' == 'netcoreapp2.0' ">
-    <BaselinePackageReference Include="Microsoft.AspNetCore.Hosting" Version="[2.1.1, )" />
-    <BaselinePackageReference Include="Microsoft.AspNetCore.Mvc.RazorPages" Version="[2.1.1, )" />
+    <BaselinePackageReference Include="Microsoft.AspNetCore.Hosting" Version="[2.2.0, )" />
+    <BaselinePackageReference Include="Microsoft.AspNetCore.Mvc.RazorPages" Version="[2.2.0, )" />
   </ItemGroup>
   <!-- Package: Microsoft.AspNetCore.Mvc.RazorPages-->
   <PropertyGroup Condition=" '$(PackageId)' == 'Microsoft.AspNetCore.Mvc.RazorPages' ">
diff --git a/eng/ProjectReferences.props b/eng/ProjectReferences.props
@@ -122,8 +122,8 @@
     <ProjectReferenceProvider Include="Microsoft.AspNetCore.Mvc.ViewFeatures" ProjectPath="$(RepositoryRoot)src\Mvc\src\Microsoft.AspNetCore.Mvc.ViewFeatures\Microsoft.AspNetCore.Mvc.ViewFeatures.csproj" />
     <ProjectReferenceProvider Include="Microsoft.AspNetCore.Mvc.WebApiCompatShim" ProjectPath="$(RepositoryRoot)src\Mvc\src\Microsoft.AspNetCore.Mvc.WebApiCompatShim\Microsoft.AspNetCore.Mvc.WebApiCompatShim.csproj" />
     <ProjectReferenceProvider Include="Microsoft.AspNetCore.Mvc" ProjectPath="$(RepositoryRoot)src\Mvc\src\Microsoft.AspNetCore.Mvc\Microsoft.AspNetCore.Mvc.csproj" />
-    <ProjectReferenceProvider Include="Microsoft.AspNetCore.Mvc.Razor.ViewCompilation" ProjectPath="$(RepositoryRoot)src\Mvc\ViewCompilation\src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj" />    <ProjectReferenceProvider Include="Microsoft.AspNetCore.Mvc.Razor.ViewCompilation" ProjectPath="$(RepositoryRoot)src\Mvc\ViewCompilation\src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj" />
     <ProjectReferenceProvider Include="Microsoft.Extensions.ApiDescription.Tasks" ProjectPath="$(RepositoryRoot)src\Mvc\src\Microsoft.Extensions.ApiDescription.Design\Microsoft.Extensions.ApiDescription.Design.csproj" />
+    <ProjectReferenceProvider Include="Microsoft.AspNetCore.Mvc.Razor.ViewCompilation" ProjectPath="$(RepositoryRoot)src\Mvc\ViewCompilation\src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj" />
     <ProjectReferenceProvider Include="Microsoft.AspNetCore.ApplicationInsights.HostingStartup" ProjectPath="$(RepositoryRoot)src\Azure\ApplicationInsights.HostingStartup\src\Microsoft.AspNetCore.ApplicationInsights.HostingStartup.csproj" />
     <ProjectReferenceProvider Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" ProjectPath="$(RepositoryRoot)src\Azure\AzureAD\Authentication.AzureAD.UI\src\Microsoft.AspNetCore.Authentication.AzureAD.UI.csproj" />
     <ProjectReferenceProvider Include="Microsoft.AspNetCore.Authentication.AzureADB2C.UI" ProjectPath="$(RepositoryRoot)src\Azure\AzureAD\Authentication.AzureADB2C.UI\src\Microsoft.AspNetCore.Authentication.AzureADB2C.UI.csproj" />
diff --git a/src/Mvc/Mvc.sln b/src/Mvc/Mvc.sln
diff --git a/src/Mvc/ViewCompilation/test/FunctionalTests/CoreCLRTests/SimpleAppTest_CoreCLR.cs b/src/Mvc/ViewCompilation/test/FunctionalTests/CoreCLRTests/SimpleAppTest_CoreCLR.cs
@@ -21,7 +21,7 @@ public SimpleAppTest_CoreCLR(
 
         public ApplicationTestFixture Fixture { get; }
 
-        [Fact]
+        [Fact(Skip = "Needs to be rewritten")]
         public async Task Precompilation_WorksForSimpleApps()
         {
             using (StartLog(out var loggerFactory))
diff --git a/src/Mvc/ViewCompilation/test/FunctionalTests/Infrastructure/ApplicationTestFixture.cs b/src/Mvc/ViewCompilation/test/FunctionalTests/Infrastructure/ApplicationTestFixture.cs
@@ -23,7 +23,7 @@ public abstract class ApplicationTestFixture : IDisposable
 
         static ApplicationTestFixture()
         {
-            SolutionDirectory = TestPathUtilities.GetSolutionRootDirectory("RazorViewCompilation");
+            SolutionDirectory = TestPathUtilities.GetSolutionRootDirectory("Mvc");
             if (!SolutionDirectory.EndsWith(Path.DirectorySeparatorChar.ToString()))
             {
                 SolutionDirectory += Path.DirectorySeparatorChar;
diff --git a/src/Mvc/ViewCompilation/test/FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj b/src/Mvc/ViewCompilation/test/FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj
@@ -1,20 +1,22 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <DefineConstants>$(DefineConstants);__remove_this_to__GENERATE_BASELINES</DefineConstants>
     <DefineConstants Condition="'$(GenerateBaseLines)'=='true'">$(DefineConstants);GENERATE_BASELINES</DefineConstants>
     <SignAssembly>false</SignAssembly>
     <PublicSign>false</PublicSign>
     <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
+
+    <RuntimeIdentifier Condition="'$(TargetFramework)' == 'net461'">win7-x64</RuntimeIdentifier>
   </PropertyGroup>
 
   <ItemGroup>
     <EmbeddedResource Include="Resources\*" />
     <Compile Include="Infrastructure\*.cs" />
     <Compile Include="DesktopTests\*.cs" Condition="'$(TargetFramework)'=='net461'" />
-    <Compile Include="CoreCLRTests\*.cs" Condition="'$(TargetFramework)'=='netcoreapp2.1'" />
+    <Compile Include="CoreCLRTests\*.cs" Condition="'$(TargetFramework)'=='netcoreapp2.2'" />
   </ItemGroup>
 
   <ItemGroup>
@@ -32,7 +34,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\testassets\ApplicationUsingRelativePaths\ApplicationUsingRelativePaths.csproj" />
     <ProjectReference Include="..\..\testassets\ApplicationWithConfigureMvc\ApplicationWithConfigureMvc.csproj" />
     <ProjectReference Include="..\..\testassets\ApplicationWithCustomInputFiles\ApplicationWithCustomInputFiles.csproj" />
     <ProjectReference Include="..\..\testassets\ApplicationWithParseErrors\ApplicationWithParseErrors.csproj" />
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
     <DefineConstants>$(DefineConstants);TEST123</DefineConstants>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
     <MvcRazorEmbedViewSources>true</MvcRazorEmbedViewSources>
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
   </PropertyGroup>
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithRazorSdkNeitherUsed/ApplicationWithRazorSdkNeitherUsed.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithRazorSdkNeitherUsed/ApplicationWithRazorSdkNeitherUsed.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <!--
       Turning off precompilation on will also turn off Razor SDK.
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithRazorSdkPrecompilationUsed/ApplicationWithRazorSdkPrecompilationUsed.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithRazorSdkPrecompilationUsed/ApplicationWithRazorSdkPrecompilationUsed.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <!--
       Turning precompilation on will turn off Razor SDK.
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithRazorSdkUsed/ApplicationWithRazorSdkUsed.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithRazorSdkUsed/ApplicationWithRazorSdkUsed.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/Mvc/ViewCompilation/testassets/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj b/src/Mvc/ViewCompilation/testassets/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
   </PropertyGroup>
diff --git a/src/Mvc/ViewCompilation/testassets/Directory.Build.props b/src/Mvc/ViewCompilation/testassets/Directory.Build.props
@@ -1,9 +1,6 @@
 <Project>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
 
-  <PropertyGroup>
-    <!-- Bug in SelfHostDeployer prevents desktop applications from being published without a rid. -->
-    <RuntimeIdentifier Condit
   <PropertyGroup>
     <!-- Bug in SelfHostDeployer prevents desktop applications from being published without a rid. -->
     <RuntimeIdentifier Condition="'$(TargetFramework)' == 'net461'">win7-x64</RuntimeIdentifier>
diff --git a/src/Mvc/ViewCompilation/testassets/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj b/src/Mvc/ViewCompilation/testassets/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
     <MvcRazorEmbedViewSources>true</MvcRazorEmbedViewSources>
diff --git a/src/Mvc/ViewCompilation/testassets/RazorPagesApp/RazorPagesApp.csproj b/src/Mvc/ViewCompilation/testassets/RazorPagesApp/RazorPagesApp.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
   </PropertyGroup>
diff --git a/src/Mvc/ViewCompilation/testassets/SimpleApp/SimpleApp.csproj b/src/Mvc/ViewCompilation/testassets/SimpleApp/SimpleApp.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
     <RuntimeIdentifiers>win7-x86;debian-x64</RuntimeIdentifiers>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
diff --git a/src/Mvc/ViewCompilation/testassets/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj b/src/Mvc/ViewCompilation/testassets/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <AssemblyName>NewAssemblyName</AssemblyName>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
 
     <MvcRazorCompileOnPublish>true</MvcRazorCompileOnPublish>
   </PropertyGroup>
diff --git a/src/Mvc/ViewCompilation/testassets/StrongNamedApp/StrongNamedApp.csproj b/src/Mvc/ViewCompilation/testassets/StrongNamedApp/StrongNamedApp.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
+    <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks>
     <SignAssembly>true</SignAssembly>
     <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public SimpleAppTest_CoreCLR(`
`21`	`21`
`22`	`22`	`public ApplicationTestFixture Fixture { get; }`
`23`	`23`
`24`		`- [Fact]`
	`24`	`+ [Fact(Skip = "Needs to be rewritten")]`
`25`	`25`	`public async Task Precompilation_WorksForSimpleApps()`
`26`	`26`	`{`
`27`	`27`	`using (StartLog(out var loggerFactory))`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public abstract class ApplicationTestFixture : IDisposable`
`23`	`23`
`24`	`24`	`static ApplicationTestFixture()`
`25`	`25`	`{`
`26`		`- SolutionDirectory = TestPathUtilities.GetSolutionRootDirectory("RazorViewCompilation");`
	`26`	`+ SolutionDirectory = TestPathUtilities.GetSolutionRootDirectory("Mvc");`
`27`	`27`	`if (!SolutionDirectory.EndsWith(Path.DirectorySeparatorChar.ToString()))`
`28`	`28`	`{`
`29`	`29`	`SolutionDirectory += Path.DirectorySeparatorChar;`