Fix HRESULT <-> bool conversion warnings (#54988)

GrabYourPitchforks · web-flow · commit bd18f5602ee5 · 2024-04-06T02:58:43.000Z
diff --git a/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/WebConfigConfigurationSource.cpp b/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/WebConfigConfigurationSource.cpp
@@ -12,7 +12,7 @@ std::shared_ptr<ConfigurationSection> WebConfigConfigurationSource::GetSection(c
     const CComBSTR applicationConfigPath = m_application.GetAppConfigPath();
 
     IAppHostElement* sectionElement;
-    if (LOG_IF_FAILED(m_manager->GetAdminSection(bstrAspNetCoreSection, applicationConfigPath, &sectionElement)))
+    if (FAILED_LOG(m_manager->GetAdminSection(bstrAspNetCoreSection, applicationConfigPath, &sectionElement)))
     {
         return nullptr;
     }
diff --git a/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.cpp b/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.cpp
@@ -73,7 +73,7 @@ IN_PROCESS_APPLICATION::StopClr()
     // Signal shutdown
     if (m_pShutdownEvent != nullptr)
     {
-        LOG_IF_FAILED(SetEvent(m_pShutdownEvent));
+        LOG_LAST_ERROR_IF(!SetEvent(m_pShutdownEvent));
     }
 
     // Need to wait for either the app to be initialized, the worker thread to exit, or the shutdown timeout.

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ std::shared_ptr<ConfigurationSection> WebConfigConfigurationSource::GetSection(c`
`12`	`12`	`const CComBSTR applicationConfigPath = m_application.GetAppConfigPath();`
`13`	`13`
`14`	`14`	`IAppHostElement* sectionElement;`
`15`		`- if (LOG_IF_FAILED(m_manager->GetAdminSection(bstrAspNetCoreSection, applicationConfigPath, &sectionElement)))`
	`15`	`+ if (FAILED_LOG(m_manager->GetAdminSection(bstrAspNetCoreSection, applicationConfigPath, &sectionElement)))`
`16`	`16`	`{`
`17`	`17`	`return nullptr;`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ IN_PROCESS_APPLICATION::StopClr()`
`73`	`73`	`// Signal shutdown`
`74`	`74`	`if (m_pShutdownEvent != nullptr)`
`75`	`75`	`{`
`76`		`- LOG_IF_FAILED(SetEvent(m_pShutdownEvent));`
	`76`	`+ LOG_LAST_ERROR_IF(!SetEvent(m_pShutdownEvent));`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`// Need to wait for either the app to be initialized, the worker thread to exit, or the shutdown timeout.`