Update all built-in AuthenticationSchemeOptions to initialize Events (#62595)

Author: halter73

src/Security/Authentication/Certificate/src/CertificateAuthenticationOptions.cs

@@ -10,6 +10,14 @@ namespace Microsoft.AspNetCore.Authentication.Certificate;
 /// </summary>
 public class CertificateAuthenticationOptions : AuthenticationSchemeOptions
 {
+    /// <summary>
+    /// Initializes a new instance of <see cref="CertificateAuthenticationOptions"/>.
+    /// </summary>
+    public CertificateAuthenticationOptions()
+    {
+        Events = new CertificateAuthenticationEvents();
+    }
+
     /// <summary>
     /// Value indicating the types of certificates accepted by the authentication middleware.
     /// </summary>

src/Security/Authentication/JwtBearer/src/JwtBearerOptions.cs

@@ -32,6 +32,7 @@ public JwtBearerOptions()
         SecurityTokenValidators = new List<ISecurityTokenValidator> { _defaultHandler };
 #pragma warning restore CS0618 // Type or member is obsolete
         TokenHandlers = new List<TokenHandler> { _defaultTokenHandler };
+        Events = new JwtBearerEvents();
     }
 
     /// <summary>

src/Security/Authentication/Negotiate/src/NegotiateOptions.cs

@@ -8,6 +8,14 @@ namespace Microsoft.AspNetCore.Authentication.Negotiate;
 /// </summary>
 public class NegotiateOptions : AuthenticationSchemeOptions
 {
+    /// <summary>
+    /// Initializes a new instance of <see cref="NegotiateOptions"/>.
+    /// </summary>
+    public NegotiateOptions()
+    {
+        Events = new NegotiateEvents();
+    }
+
     /// <summary>
     /// The object provided by the application to process events raised by the negotiate authentication handler.
     /// The application may use the existing NegotiateEvents instance and assign delegates only to the events it

src/Security/Authentication/Negotiate/test/Negotiate.Test/NegotiateHandlerTests.cs

@@ -20,6 +20,13 @@ namespace Microsoft.AspNetCore.Authentication.Negotiate;
 
 public class NegotiateHandlerTests
 {
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
+    {
+        var options = new NegotiateOptions();
+        Assert.NotNull(options.Events);
+    }
+
     [Fact]
     public async Task Anonymous_MissingConnectionFeatures_ThrowsNotSupported()
     {

src/Security/Authentication/test/BearerTokenTests.cs

@@ -23,4 +23,11 @@ protected override void RegisterAuth(AuthenticationBuilder services, Action<Bear
     {
         services.AddBearerToken(configure);
     }
+
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
+    {
+        var options = new BearerTokenOptions();
+        Assert.NotNull(options.Events);
+    }
 }

src/Security/Authentication/test/CertificateTests.cs

@@ -22,6 +22,12 @@ namespace Microsoft.AspNetCore.Authentication.Certificate.Test;
 
 public class ClientCertificateAuthenticationTests
 {
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
+    {
+        var options = new CertificateAuthenticationOptions();
+        Assert.NotNull(options.Events);
+    }
 
     [Fact]
     public async Task VerifySchemeDefaults()

src/Security/Authentication/test/CookieTests.cs

@@ -32,6 +32,13 @@ protected override void RegisterAuth(AuthenticationBuilder services, Action<Cook
         services.AddCookie(configure);
     }
 
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
+    {
+        var options = new CookieAuthenticationOptions();
+        Assert.NotNull(options.Events);
+    }
+
     [Fact]
     public async Task NormalRequestPassesThrough()
     {

src/Security/Authentication/test/FacebookTests.cs

@@ -42,6 +42,13 @@ protected override void ConfigureDefaults(FacebookOptions o)
         o.SignInScheme = "auth1";
     }
 
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
+    {
+        var options = new FacebookOptions();
+        Assert.NotNull(options.Events);
+    }
+
     [Fact]
     public async Task ThrowsIfAppIdMissing()
     {

src/Security/Authentication/test/GoogleTests.cs

@@ -42,6 +42,13 @@ protected override void ConfigureDefaults(GoogleOptions o)
         o.SignInScheme = "auth1";
     }
 
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
+    {
+        var options = new GoogleOptions();
+        Assert.NotNull(options.Events);
+    }
+
     [Fact]
     public async Task ChallengeWillTriggerRedirection()
     {

src/Security/Authentication/test/JwtBearerTests.cs

@@ -33,15 +33,14 @@ public class JwtBearerTests : SharedAuthenticationTests<JwtBearerOptions>
 
     protected override void RegisterAuth(AuthenticationBuilder services, Action<JwtBearerOptions> configure)
     {
-        services.AddJwtBearer(o =>
-        {
-            ConfigureDefaults(o);
-            configure.Invoke(o);
-        });
+        services.AddJwtBearer(configure);
     }
 
-    private void ConfigureDefaults(JwtBearerOptions o)
+    [Fact]
+    public void EventsPropertyIsInitializedOnConstruction()
     {
+        var options = new JwtBearerOptions();
+        Assert.NotNull(options.Events);
     }
 
     [Fact]