Change default for queryStringDelete (#21586)

Author: brianchance

src/Middleware/Rewrite/src/IISUrlRewrite/UrlRewriteFileParser.cs

@@ -219,7 +219,7 @@ private void ParseUrlAction(XElement urlAction, UrlRewriteRuleBuilder builder, b
                     else
                     {
                         var redirectType = ParseEnum(urlAction, RewriteTags.RedirectType, RedirectType.Permanent);
-                        action = new RedirectAction((int)redirectType, urlPattern, appendQuery);
+                        action = new RedirectAction((int)redirectType, urlPattern, appendQuery, !appendQuery, escapeBackReferences: false);
                     }
                     break;
                 case ActionType.AbortRequest:

src/Middleware/Rewrite/src/UrlActions/RedirectAction.cs

@@ -28,19 +28,6 @@ public RedirectAction(
             EscapeBackReferences = escapeBackReferences;
         }
 
-        public RedirectAction(
-            int statusCode,
-            Pattern pattern,
-            bool queryStringAppend)
-            : this(
-                statusCode,
-                pattern,
-                queryStringAppend,
-                queryStringDelete: true,
-                escapeBackReferences: false)
-        {
-        }
-
         public override void ApplyAction(RewriteContext context, BackReferenceCollection ruleBackReferences, BackReferenceCollection conditionBackReferences)
         {
             var pattern = Url.Evaluate(context, ruleBackReferences, conditionBackReferences);
@@ -58,7 +45,6 @@ public override void ApplyAction(RewriteContext context, BackReferenceCollection
                 return;
             }
 
-
             if (pattern.IndexOf("://", StringComparison.Ordinal) == -1 && pattern[0] != '/')
             {
                 pattern = '/' + pattern;

src/Middleware/Rewrite/test/IISUrlRewrite/MiddleWareTests.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -399,7 +399,7 @@ public async Task VerifyTrackAllCaptures()
 
             var response = await server.CreateClient().GetAsync("article/23?p1=123&p2=abc");
 
-            Assert.Equal("/blogposts/article/abc", response.Headers.Location.OriginalString);
+            Assert.Equal("/blogposts/article/abc?p1=123&p2=abc", response.Headers.Location.OriginalString);
         }
 
         [Fact]
@@ -427,7 +427,7 @@ public async Task VerifyTrackAllCapturesRuleAndConditionCapture()
 
             var response = await server.CreateClient().GetAsync("article/23?p1=123&p2=abc");
 
-            Assert.Equal("/blog/article/23/abc", response.Headers.Location.OriginalString);
+            Assert.Equal("/blog/article/23/abc?p1=123&p2=abc", response.Headers.Location.OriginalString);
         }
 
         [Fact]