Rename the feature switch to IsCustomAwaitableSupported to align with other feature switch naming

Author: eerhardt

src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs

@@ -32,11 +32,11 @@ internal sealed partial class DefaultHubDispatcher<[DynamicallyAccessedMembers(H
     private readonly Func<HubLifetimeContext, Exception?, Task>? _onDisconnectedMiddleware;
     private readonly HubLifetimeManager<THub> _hubLifetimeManager;
 
-    [FeatureSwitchDefinition("Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport")]
+    [FeatureSwitchDefinition("Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported")]
     [FeatureGuard(typeof(RequiresDynamicCodeAttribute))]
     [FeatureGuard(typeof(RequiresUnreferencedCodeAttribute))]
-    private static bool CustomAwaitableSupport { get; } =
-        AppContext.TryGetSwitch("Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport", out bool customAwaitableSupport) ? customAwaitableSupport : true;
+    private static bool IsCustomAwaitableSupported { get; } =
+        AppContext.TryGetSwitch("Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported", out bool customAwaitableSupport) ? customAwaitableSupport : true;
 
     public DefaultHubDispatcher(IServiceScopeFactory serviceScopeFactory, IHubContext<THub> hubContext, bool enableDetailedErrors,
         bool disableImplicitFromServiceParameters, ILogger<DefaultHubDispatcher<THub>> logger, List<IHubFilter>? hubFilters, HubLifetimeManager<THub> lifetimeManager)
@@ -768,7 +768,7 @@ private void DiscoverHubMethods(bool disableImplicitFromServiceParameters)
                 throw new NotSupportedException($"Duplicate definitions of '{methodName}'. Overloading is not supported.");
             }
 
-            var executor = CustomAwaitableSupport
+            var executor = IsCustomAwaitableSupported
                 ? CreateObjectMethodExecutor(methodInfo, hubTypeInfo)
                 : ObjectMethodExecutor.CreateTrimAotCompatible(methodInfo, hubTypeInfo);
 
@@ -780,8 +780,8 @@ private void DiscoverHubMethods(bool disableImplicitFromServiceParameters)
         }
     }
 
-    [RequiresUnreferencedCode("Using SignalR with 'Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport=true' is not trim compatible.")]
-    [RequiresDynamicCode("Using SignalR with 'Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport=true' is not native AOT compatible.")]
+    [RequiresUnreferencedCode("Using SignalR with 'Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported=true' is not trim compatible.")]
+    [RequiresDynamicCode("Using SignalR with 'Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported=true' is not native AOT compatible.")]
     private static ObjectMethodExecutor CreateObjectMethodExecutor(MethodInfo methodInfo, TypeInfo targetType)
        => ObjectMethodExecutor.Create(methodInfo, targetType);
 

src/SignalR/server/Core/src/Microsoft.AspNetCore.SignalR.Core.WarningSuppressions.xml

@@ -6,7 +6,7 @@
       <argument>IL2026</argument>
       <property name="Scope">member</property>
       <property name="Target">M:Microsoft.AspNetCore.SignalR.Internal.DefaultHubDispatcher`1.DiscoverHubMethods(System.Boolean)</property>
-      <property name="Justification">This warning is left in the product so developers get an ILLink warning when trimming an app when Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport=true.</property>
+      <property name="Justification">This warning is left in the product so developers get an ILLink warning when trimming an app when Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported=true.</property>
     </attribute>
   </assembly>
 </linker>

src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/NativeAotTests.cs

@@ -120,7 +120,7 @@ private static void RunNativeAotTest(Func<Task> test)
     {
         var options = new RemoteInvokeOptions();
         options.RuntimeConfigurationOptions.Add("System.Runtime.CompilerServices.RuntimeFeature.IsDynamicCodeSupported", "false");
-        options.RuntimeConfigurationOptions.Add("Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport", "false");
+        options.RuntimeConfigurationOptions.Add("Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported", "false");
         options.RuntimeConfigurationOptions.Add("System.Text.Json.JsonSerializer.IsReflectionEnabledByDefault", "false");
 
         using var remoteHandle = RemoteExecutor.Invoke(test, options);

src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.TrimmingTests/Microsoft.AspNetCore.SignalR.TrimmingTests.proj

@@ -2,7 +2,7 @@
 
   <ItemGroup>
     <TestConsoleAppSourceFiles Include="TestTypedClients.cs">
-      <DisabledFeatureSwitches>Microsoft.AspNetCore.SignalR.Hub.CustomAwaitableSupport</DisabledFeatureSwitches>
+      <DisabledFeatureSwitches>Microsoft.AspNetCore.SignalR.Hub.IsCustomAwaitableSupported</DisabledFeatureSwitches>
     </TestConsoleAppSourceFiles>
   </ItemGroup>