Skip to content

Commit 910e5ad

Browse files
authored
Reference InprocessTestSite in CreateDefaultBuilderApp and Disable Failing Tests (#6318)
1 parent afb9201 commit 910e5ad

File tree

6 files changed

+6
-15
lines changed

6 files changed

+6
-15
lines changed

src/DefaultBuilder/testassets/CreateDefaultBuilderApp/CreateDefaultBuilderApp.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<OutputType>Exe</OutputType>
77
<TargetFramework>netcoreapp3.0</TargetFramework>
88
<UserSecretsId>aspnetcore-CreateDefaultBuilder-20170424224131</UserSecretsId>
9+
<InProcessTestSite>true</InProcessTestSite>
910
</PropertyGroup>
1011

1112
<ItemGroup>

src/Http/Http/test/StreamPipeReaderTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public async Task ReadExamineEntireReadAsyncReturnsNewData()
151151
Assert.NotEqual(readResult, readResult2);
152152
}
153153

154-
[Fact]
154+
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")]
155155
public async Task ReadCanBeCancelledViaProvidedCancellationToken()
156156
{
157157
var pipeReader = new StreamPipeReader(new HangingStream());

src/MusicStore/test/MusicStore.E2ETests/NtlmAuthentationTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace E2ETests
1717
public class NtlmAuthenticationTests : LoggedTest
1818
{
1919
public static TestMatrix TestVariants
20-
=> TestMatrix.ForServers(ServerType.IISExpress, ServerType.HttpSys)
20+
=> TestMatrix.ForServers(/*ServerType.IISExpress https://github.com/aspnet/AspNetCore/issues/6170*/ ServerType.HttpSys)
2121
.WithTfms(Tfm.NetCoreApp30)
2222
.WithAllApplicationTypes()
2323
.WithAllArchitectures();

src/MusicStore/test/MusicStore.E2ETests/OpenIdConnectTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace E2ETests
1414
public class OpenIdConnectTests : LoggedTest
1515
{
1616
public static TestMatrix TestVariants
17-
=> TestMatrix.ForServers(ServerType.IISExpress, ServerType.Kestrel)
17+
=> TestMatrix.ForServers(/* ServerType.IISExpress https://github.com/aspnet/AspNetCore/issues/6170 */ ServerType.Kestrel)
1818
.WithTfms(Tfm.NetCoreApp30);
1919

2020
[ConditionalTheory]

src/MusicStore/test/MusicStore.E2ETests/SmokeTests.cs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,14 @@ namespace E2ETests
1616
public class SmokeTests : LoggedTest
1717
{
1818
public static TestMatrix TestVariants
19-
=> TestMatrix.ForServers(ServerType.IISExpress, ServerType.Kestrel, ServerType.HttpSys)
19+
=> TestMatrix.ForServers(/* ServerType.IISExpress, https://github.com/aspnet/AspNetCore/issues/6170*/ ServerType.Kestrel, ServerType.HttpSys)
2020
.WithTfms(Tfm.NetCoreApp30)
2121
.WithAllApplicationTypes()
2222
.WithAllAncmVersions()
2323
.WithAllHostingModels();
2424

25-
// ANCM In-process cannot run on netcoreapp2.1 and below
26-
public static TestMatrix TestVariantsWithoutInproc
27-
=> TestMatrix.ForServers(ServerType.IISExpress, ServerType.Kestrel, ServerType.HttpSys)
28-
.WithTfms(Tfm.NetCoreApp30)
29-
.WithAllApplicationTypes()
30-
.WithAllAncmVersions()
31-
.WithHostingModels(HostingModel.OutOfProcess)
32-
.WithAllArchitectures();
33-
3425
[ConditionalTheory]
3526
[MemberData(nameof(TestVariants))]
36-
[MemberData(nameof(TestVariantsWithoutInproc))]
3727
public async Task Smoke_Tests(TestVariant variant)
3828
{
3929
var testName = $"SmokeTestSuite_{variant}";

src/Servers/test/FunctionalTests/ResponseTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public ResponseTests(ITestOutputHelper output) : base(output)
2525
}
2626

2727
public static TestMatrix TestVariants
28-
=> TestMatrix.ForServers(ServerType.IISExpress, ServerType.Kestrel, /* ServerType.Nginx, https://github.com/aspnet/AspNetCore-Internal/issues/1525 */ ServerType.HttpSys)
28+
=> TestMatrix.ForServers(/* ServerType.IISExpress, https://github.com/aspnet/AspNetCore/issues/6168, */ ServerType.Kestrel, /* ServerType.Nginx, https://github.com/aspnet/AspNetCore-Internal/issues/1525 */ ServerType.HttpSys)
2929
.WithTfms(Tfm.NetCoreApp30)
3030
.WithAllAncmVersions()
3131
.WithAllHostingModels();

0 commit comments

Comments
 (0)