Annotate Microsoft.AspNetCore.Http with nullable attributes (#22928)

* Annotate Microsoft.AspNetCore.Http with nullable attributes

* Annotate Hosting with nullable

Author: pranavkm

src/Hosting/Abstractions/ref/Microsoft.AspNetCore.Hosting.Abstractions.csproj

@@ -2,6 +2,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks>
+    <Nullable>annotations</Nullable>
   </PropertyGroup>
   <ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'">
     <Compile Include="Microsoft.AspNetCore.Hosting.Abstractions.netcoreapp.cs" />

src/Hosting/Abstractions/ref/Microsoft.AspNetCore.Hosting.Abstractions.netcoreapp.cs

@@ -93,8 +93,8 @@ public partial interface IWebHostBuilder
         Microsoft.AspNetCore.Hosting.IWebHostBuilder ConfigureAppConfiguration(System.Action<Microsoft.AspNetCore.Hosting.WebHostBuilderContext, Microsoft.Extensions.Configuration.IConfigurationBuilder> configureDelegate);
         Microsoft.AspNetCore.Hosting.IWebHostBuilder ConfigureServices(System.Action<Microsoft.AspNetCore.Hosting.WebHostBuilderContext, Microsoft.Extensions.DependencyInjection.IServiceCollection> configureServices);
         Microsoft.AspNetCore.Hosting.IWebHostBuilder ConfigureServices(System.Action<Microsoft.Extensions.DependencyInjection.IServiceCollection> configureServices);
-        string GetSetting(string key);
-        Microsoft.AspNetCore.Hosting.IWebHostBuilder UseSetting(string key, string value);
+        string? GetSetting(string key);
+        Microsoft.AspNetCore.Hosting.IWebHostBuilder UseSetting(string key, string? value);
     }
     public partial interface IWebHostEnvironment : Microsoft.Extensions.Hosting.IHostEnvironment
     {

src/Hosting/Abstractions/src/IWebHostBuilder.cs

@@ -50,14 +50,14 @@ public interface IWebHostBuilder
         /// </summary>
         /// <param name="key">The key of the setting to look up.</param>
         /// <returns>The value the setting currently contains.</returns>
-        string GetSetting(string key);
+        string? GetSetting(string key);
 
         /// <summary>
         /// Add or replace a setting in the configuration.
         /// </summary>
         /// <param name="key">The key of the setting to add or replace.</param>
         /// <param name="value">The value of the setting to add or replace.</param>
         /// <returns>The <see cref="IWebHostBuilder"/>.</returns>
-        IWebHostBuilder UseSetting(string key, string value);
+        IWebHostBuilder UseSetting(string key, string? value);
     }
-}
+}

src/Hosting/Abstractions/src/Microsoft.AspNetCore.Hosting.Abstractions.csproj

@@ -8,6 +8,7 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;hosting</PackageTags>
     <IsPackable>false</IsPackable>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

src/Hosting/Abstractions/src/WebHostBuilderContext.cs

@@ -13,11 +13,11 @@ public class WebHostBuilderContext
         /// <summary>
         /// The <see cref="IWebHostEnvironment" /> initialized by the <see cref="IWebHost" />.
         /// </summary>
-        public IWebHostEnvironment HostingEnvironment { get; set; }
+        public IWebHostEnvironment HostingEnvironment { get; set; } = default!;
 
         /// <summary>
         /// The <see cref="IConfiguration" /> containing the merged configuration of the application and the <see cref="IWebHost" />.
         /// </summary>
-        public IConfiguration Configuration { get; set; }
+        public IConfiguration Configuration { get; set; } = default!;
     }
 }

src/Http/Http.Abstractions/ref/Microsoft.AspNetCore.Http.Abstractions.netcoreapp.cs

@@ -14,7 +14,7 @@ protected EndpointBuilder() { }
     public partial interface IApplicationBuilder
     {
         System.IServiceProvider ApplicationServices { get; set; }
-        System.Collections.Generic.IDictionary<string, object> Properties { get; }
+        System.Collections.Generic.IDictionary<string, object?> Properties { get; }
         Microsoft.AspNetCore.Http.Features.IFeatureCollection ServerFeatures { get; }
         Microsoft.AspNetCore.Http.RequestDelegate Build();
         Microsoft.AspNetCore.Builder.IApplicationBuilder New();
@@ -108,13 +108,13 @@ public BadHttpRequestException(string message, int statusCode, System.Exception
     public abstract partial class ConnectionInfo
     {
         protected ConnectionInfo() { }
-        public abstract System.Security.Cryptography.X509Certificates.X509Certificate2 ClientCertificate { get; set; }
+        public abstract System.Security.Cryptography.X509Certificates.X509Certificate2? ClientCertificate { get; set; }
         public abstract string Id { get; set; }
-        public abstract System.Net.IPAddress LocalIpAddress { get; set; }
+        public abstract System.Net.IPAddress? LocalIpAddress { get; set; }
         public abstract int LocalPort { get; set; }
-        public abstract System.Net.IPAddress RemoteIpAddress { get; set; }
+        public abstract System.Net.IPAddress? RemoteIpAddress { get; set; }
         public abstract int RemotePort { get; set; }
-        public abstract System.Threading.Tasks.Task<System.Security.Cryptography.X509Certificates.X509Certificate2> GetClientCertificateAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));
+        public abstract System.Threading.Tasks.Task<System.Security.Cryptography.X509Certificates.X509Certificate2?> GetClientCertificateAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken));
     }
     public partial class CookieBuilder
     {
@@ -231,7 +231,7 @@ protected HttpContext() { }
         public abstract System.Threading.CancellationToken RequestAborted { get; set; }
         public abstract System.IServiceProvider RequestServices { get; set; }
         public abstract Microsoft.AspNetCore.Http.HttpResponse Response { get; }
-        public abstract Microsoft.AspNetCore.Http.ISession? Session { get; set; }
+        public abstract Microsoft.AspNetCore.Http.ISession Session { get; set; }
         public abstract string TraceIdentifier { get; set; }
         public abstract System.Security.Claims.ClaimsPrincipal User { get; set; }
         public abstract Microsoft.AspNetCore.Http.WebSocketManager WebSockets { get; }
@@ -326,7 +326,7 @@ public static partial class HttpResponseWritingExtensions
     }
     public partial interface IHttpContextAccessor
     {
-        Microsoft.AspNetCore.Http.HttpContext HttpContext { get; set; }
+        Microsoft.AspNetCore.Http.HttpContext? HttpContext { get; set; }
     }
     public partial interface IHttpContextFactory
     {

src/Http/Http.Abstractions/src/ConnectionInfo.cs

@@ -15,16 +15,16 @@ public abstract class ConnectionInfo
         /// </summary>
         public abstract string Id { get; set; }
 
-        public abstract IPAddress RemoteIpAddress { get; set; }
+        public abstract IPAddress? RemoteIpAddress { get; set; }
 
         public abstract int RemotePort { get; set; }
 
-        public abstract IPAddress LocalIpAddress { get; set; }
+        public abstract IPAddress? LocalIpAddress { get; set; }
 
         public abstract int LocalPort { get; set; }
 
-        public abstract X509Certificate2 ClientCertificate { get; set; }
+        public abstract X509Certificate2? ClientCertificate { get; set; }
 
-        public abstract Task<X509Certificate2> GetClientCertificateAsync(CancellationToken cancellationToken = new CancellationToken());
+        public abstract Task<X509Certificate2?> GetClientCertificateAsync(CancellationToken cancellationToken = new CancellationToken());
     }
 }

src/Http/Http.Abstractions/src/HttpContext.cs

@@ -68,7 +68,7 @@ public abstract class HttpContext
         /// <summary>
         /// Gets or sets the object used to manage user session data for this request.
         /// </summary>
-        public abstract ISession? Session { get; set; }
+        public abstract ISession Session { get; set; }
 
         /// <summary>
         /// Aborts the connection underlying this request.

src/Http/Http.Abstractions/src/IApplicationBuilder.cs

@@ -26,7 +26,7 @@ public interface IApplicationBuilder
         /// <summary>
         /// Gets a key/value collection that can be used to share data between middleware.
         /// </summary>
-        IDictionary<string, object> Properties { get; }
+        IDictionary<string, object?> Properties { get; }
 
         /// <summary>
         /// Adds a middleware delegate to the application's request pipeline.

src/Http/Http.Abstractions/src/IHttpContextAccessor.cs

@@ -15,6 +15,6 @@ public interface IHttpContextAccessor
         /// <summary>
         /// Gets or sets the current <see cref="HttpContext"/>. Returns <see langword="null" /> if there is no active <see cref="HttpContext" />.
         /// </summary>
-        HttpContext HttpContext { get; set; }
+        HttpContext? HttpContext { get; set; }
     }
 }