Skip to content

Commit 85ae259

Browse files
Fix Http/3 tests (#50852)
1 parent 36e03b5 commit 85ae259

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ static async Task<HttpResponseMessage> SendRequestAsync(HttpProtocols protocol,
393393

394394
[ConditionalFact]
395395
[MsQuicSupported]
396-
[SkipOnCI("https://github.com/dotnet/aspnetcore/issues/50833")]
396+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/50833")]
397397
public async Task POST_ServerCompletesWithoutReadingRequestBody_ClientGetsResponse()
398398
{
399399
// Arrange
@@ -430,6 +430,8 @@ public async Task POST_ServerCompletesWithoutReadingRequestBody_ClientGetsRespon
430430

431431
var response = await responseTask.DefaultTimeout();
432432

433+
requestContent.CompleteStream();
434+
433435
// Assert
434436
response.EnsureSuccessStatusCode();
435437
Assert.Equal(HttpVersion.Version30, response.Version);
@@ -698,7 +700,7 @@ public async Task GET_ServerAbort_ClientReceivesAbort(HttpProtocols protocol)
698700

699701
[ConditionalFact]
700702
[MsQuicSupported]
701-
[SkipOnCI("https://github.com/dotnet/aspnetcore/issues/50833")]
703+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/50833")]
702704
public async Task POST_Expect100Continue_Get100Continue()
703705
{
704706
// Arrange
@@ -726,7 +728,7 @@ public async Task POST_Expect100Continue_Get100Continue()
726728

727729
// Act
728730
using var cts = new CancellationTokenSource();
729-
cts.CancelAfter(TimeSpan.FromSeconds(1));
731+
cts.CancelAfter(TimeSpan.FromSeconds(30));
730732
var responseTask = client.SendAsync(request, cts.Token);
731733

732734
var response = await responseTask.DefaultTimeout();
@@ -958,7 +960,7 @@ await ServerRetryHelper.BindPortsWithRetry(async port =>
958960
[ConditionalTheory]
959961
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/38008")]
960962
[MsQuicSupported]
961-
//[InlineData(HttpProtocols.Http3)] Skip: see https://github.com/dotnet/aspnetcore/issues/50833
963+
[InlineData(HttpProtocols.Http3)]
962964
[InlineData(HttpProtocols.Http2)]
963965
public async Task POST_ClientCancellationBidirectional_RequestAbortRaised(HttpProtocols protocol)
964966
{
@@ -1059,7 +1061,8 @@ public async Task POST_ClientCancellationBidirectional_RequestAbortRaised(HttpPr
10591061
// Verify HTTP/2 and HTTP/3 match behavior
10601062
[ConditionalTheory]
10611063
[MsQuicSupported]
1062-
//[InlineData(HttpProtocols.Http3)] Skip: see https://github.com/dotnet/aspnetcore/issues/50833
1064+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/50833")]
1065+
[InlineData(HttpProtocols.Http3)]
10631066
[InlineData(HttpProtocols.Http2)]
10641067
public async Task POST_Bidirectional_LargeData_Cancellation_Error(HttpProtocols protocol)
10651068
{

0 commit comments

Comments
 (0)