[SignalR] [Java] Fix NPE when closing hub connection during negotiation

Author: Sejsel

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/HubConnection.java

@@ -445,7 +445,8 @@ private Completable stop(String errorMessage) {
         CompletableSubject subject = CompletableSubject.create();
         startTask.onErrorComplete().subscribe(() ->
         {
-            Completable stop = connectionState.transport.stop();
+            Transport transport = connectionState.transport;
+            Completable stop = (transport != null) ? transport.stop() : Completable.complete();
             stop.subscribe(() -> subject.onComplete(), e -> subject.onError(e));
         });
 

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/HubConnectionTest.java

@@ -2781,6 +2781,29 @@ public void negotiateSentOnStart() {
         List<HttpRequest> sentRequests = client.getSentRequests();
         assertEquals(1, sentRequests.size());
         assertEquals("http://example.com/negotiate?negotiateVersion=1", sentRequests.get(0).getUrl());
+
+        hubConnection.stop().blockingAwait();
+        assertTrue(true);
+    }
+
+    @Test
+    public void closeWithPendingNegotiate() {
+        TestHttpClient client = new TestHttpClient()
+                .on("POST", (req) -> Single.just(new HttpResponse(404, "", TestUtils.emptyByteBuffer)).delay(200, TimeUnit.MILLISECONDS));
+
+        HubConnection hubConnection = HubConnectionBuilder
+                .create("http://example.com")
+                .withHttpClient(client)
+                .build();
+
+        Completable start = hubConnection.start();
+        assertEquals(HubConnectionState.CONNECTING, hubConnection.getConnectionState());
+        hubConnection.stop().timeout(3, TimeUnit.SECONDS).blockingAwait();
+        assertEquals(HubConnectionState.DISCONNECTED, hubConnection.getConnectionState());
+
+        HttpRequestException exception = assertThrows(HttpRequestException.class, () -> start.blockingAwait(10, TimeUnit.SECONDS));
+        assertEquals("Unexpected status code returned from negotiate: 404 .", exception.getMessage());
+        assertEquals(404, exception.getStatusCode());
     }
 
     @Test