Skip to content

Commit 645a4ae

Browse files
Remove network.protocol.name from request duration metric (#51593)
Co-authored-by: James Newton-King <james@newtonking.com>
1 parent 50ffcdd commit 645a4ae

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/Hosting/Hosting/src/Internal/HostingMetrics.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ public HostingMetrics(IMeterFactory meterFactory)
2424
_activeRequestsCounter = _meter.CreateUpDownCounter<long>(
2525
"http.server.active_requests",
2626
unit: "{request}",
27-
description: "Number of HTTP requests that are currently active on the server.");
27+
description: "Number of active HTTP server requests.");
2828

2929
_requestDuration = _meter.CreateHistogram<double>(
3030
"http.server.request.duration",
3131
unit: "s",
32-
description: "Measures the duration of inbound HTTP requests.");
32+
description: "Duration of HTTP server requests.");
3333
}
3434

3535
// Note: Calling code checks whether counter is enabled.
@@ -54,7 +54,6 @@ public void RequestEnd(string protocol, bool isHttps, string scheme, string meth
5454

5555
if (_requestDuration.Enabled)
5656
{
57-
tags.Add("network.protocol.name", "http");
5857
if (TryGetHttpVersion(protocol, out var httpVersion))
5958
{
6059
tags.Add("network.protocol.version", httpVersion);

src/Hosting/Hosting/test/HostingMetricsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ public void MultipleRequests()
9292
static void AssertRequestDuration(CollectedMeasurement<double> measurement, string httpVersion, int statusCode, string exceptionName = null, bool? unhandledRequest = null)
9393
{
9494
Assert.True(measurement.Value > 0);
95-
Assert.Equal("http", (string)measurement.Tags["network.protocol.name"]);
9695
Assert.Equal(httpVersion, (string)measurement.Tags["network.protocol.version"]);
9796
Assert.Equal(statusCode, (int)measurement.Tags["http.response.status_code"]);
9897
if (exceptionName == null)

0 commit comments

Comments
 (0)