Fix Blazor WebAssembly perf benchmarks (#56811)

Author: MackinnonBuck

eng/Versions.props

@@ -310,7 +310,7 @@
     <NewtonsoftJsonVersion>13.0.3</NewtonsoftJsonVersion>
     <NSwagApiDescriptionClientVersion>13.0.4</NSwagApiDescriptionClientVersion>
     <PhotinoNETVersion>2.5.2</PhotinoNETVersion>
-    <MicrosoftPlaywrightVersion>1.28.0</MicrosoftPlaywrightVersion>
+    <MicrosoftPlaywrightVersion>1.45.1</MicrosoftPlaywrightVersion>
     <PollyExtensionsHttpVersion>3.0.0</PollyExtensionsHttpVersion>
     <PollyVersion>7.2.4</PollyVersion>
     <SeleniumSupportVersion>4.22.0</SeleniumSupportVersion>

src/Components/benchmarkapps/Wasm.Performance/Driver/Program.cs

@@ -8,13 +8,14 @@
 using System.Text.Json;
 using Microsoft.AspNetCore.Hosting.Server;
 using Microsoft.AspNetCore.Hosting.Server.Features;
-using OpenQA.Selenium;
-using DevHostServerProgram = Microsoft.AspNetCore.Components.WebAssembly.DevServer.Server.Program;
+using Microsoft.Playwright;
 
 namespace Wasm.Performance.Driver;
 
 public class Program
 {
+    private const bool RunHeadless = true;
+
     internal static TaskCompletionSource<BenchmarkResult> BenchmarkResultTask;
 
     public static async Task<int> Main(string[] args)
@@ -51,7 +52,18 @@ public static async Task<int> Main(string[] args)
         // This write is required for the benchmarking infrastructure.
         Console.WriteLine("Application started.");
 
-        using var browser = await Selenium.CreateBrowser(default, captureBrowserMemory: isStressRun);
+        var browserArgs = new List<string>();
+        if (isStressRun)
+        {
+            browserArgs.Add("--enable-precise-memory-info");
+        }
+
+        using var playwright = await Playwright.CreateAsync();
+        await using var browser = await playwright.Chromium.LaunchAsync(new()
+        {
+            Headless = RunHeadless,
+            Args = browserArgs,
+        });
         using var testApp = StartTestApp();
         using var benchmarkReceiver = StartBenchmarkResultReceiver();
         var testAppUrl = GetListeningUrl(testApp);
@@ -67,19 +79,20 @@ public static async Task<int> Main(string[] args)
         var timeForEachRun = TimeSpan.FromMinutes(3);
 
         var launchUrl = $"{testAppUrl}?resultsUrl={UrlEncoder.Default.Encode(receiverUrl)}#automated";
-        browser.Url = launchUrl;
-        browser.Navigate();
+        var page = await browser.NewPageAsync();
+        await page.GotoAsync(launchUrl);
+        page.Console += WriteBrowserConsoleMessage;
 
         do
         {
             BenchmarkResultTask = new TaskCompletionSource<BenchmarkResult>();
             using var runCancellationToken = new CancellationTokenSource(timeForEachRun);
-            using var registration = runCancellationToken.Token.Register(() =>
+            using var registration = runCancellationToken.Token.Register(async () =>
             {
-                string exceptionMessage = $"Timed out after {timeForEachRun}.";
+                var exceptionMessage = $"Timed out after {timeForEachRun}.";
                 try
                 {
-                    var innerHtml = browser.FindElement(By.CssSelector(":first-child")).GetAttribute("innerHTML");
+                    var innerHtml = await page.GetAttributeAsync(":first-child", "innerHTML");
                     exceptionMessage += Environment.NewLine + "Browser state: " + Environment.NewLine + innerHtml;
                 }
                 catch
@@ -107,6 +120,11 @@ public static async Task<int> Main(string[] args)
         return 0;
     }
 
+    private static void WriteBrowserConsoleMessage(object sender, IConsoleMessage message)
+    {
+        Console.WriteLine($"[Browser Log]: {message.Text}");
+    }
+
     private static void FormatAsBenchmarksOutput(BenchmarkResult benchmarkResult, bool includeMetadata, bool isStressRun)
     {
         // Sample of the the format: https://github.com/aspnet/Benchmarks/blob/e55f9e0312a7dd019d1268c1a547d1863f0c7237/src/Benchmarks/Program.cs#L51-L67
@@ -252,31 +270,20 @@ static void PrettyPrint(BenchmarkResult benchmarkResult)
         }
     }
 
-    static IHost StartTestApp()
+    static WebApplication StartTestApp()
     {
-        var args = new[]
-        {
-                "--urls", "http://127.0.0.1:0",
-                "--applicationpath", typeof(TestApp.Program).Assembly.Location,
-#if DEBUG
-                "--contentroot",
-                Path.GetFullPath(typeof(Program).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>()
-                    .First(f => f.Key == "TestAppLocatiion")
-                    .Value)
-#endif
-            };
-
-        var host = DevHostServerProgram.BuildWebHost(args);
-        RunInBackgroundThread(host.Start);
-        return host;
+        string[] args = ["--urls", "http://127.0.0.1:0"];
+        var app = WebApplication.Create(args);
+        app.MapStaticAssets();
+        app.MapFallbackToFile("index.html");
+
+        RunInBackgroundThread(app.Start);
+        return app;
     }
 
     static IHost StartBenchmarkResultReceiver()
     {
-        var args = new[]
-        {
-                "--urls", "http://127.0.0.1:0",
-            };
+        string[] args = ["--urls", "http://127.0.0.1:0"];
 
         var host = Host.CreateDefaultBuilder(args)
             .ConfigureWebHostDefaults(builder => builder.UseStartup<BenchmarkDriverStartup>())

src/Components/benchmarkapps/Wasm.Performance/Driver/Selenium.cs

@@ -8,32 +8,16 @@
     <!-- WebDriver is not strong-named, so this test project cannot be strong named either. -->
     <SignAssembly>false</SignAssembly>
     <IsTestAssetProject>true</IsTestAssetProject>
-    <RuntimeIdentifier Condition=" '$(DotNetBuildSourceOnly)' != 'true' ">linux-x64</RuntimeIdentifier>
-    <SelfContained Condition=" '$(DotNetBuildSourceOnly)' != 'true' ">true</SelfContained>
     <Nullable>annotations</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
     <Reference Include="Microsoft.AspNetCore" />
     <Reference Include="Microsoft.AspNetCore.Cors" />
     <Reference Include="Microsoft.AspNetCore.Components.WebAssembly.Server" />
-    <Reference Include="Selenium.Support" />
-    <Reference Include="Selenium.WebDriver" />
+    <Reference Include="Microsoft.Playwright" Condition="'$(IsPlaywrightAvailable)' == 'true'" />
+    <Reference Include="Microsoft.Playwright" ExcludeAssets="build" Condition="'$(IsPlaywrightAvailable)' != 'true'" />
     <ProjectReference Include="..\TestApp\Wasm.Performance.TestApp.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Compile Include="..\..\..\WebAssembly\DevServer\src\Server\*.cs" />
-  </ItemGroup>
-
-  <Target Name="_AddTestProjectMetadataAttributes" BeforeTargets="BeforeCompile">
-    <ItemGroup>
-      <AssemblyAttribute
-        Include="System.Reflection.AssemblyMetadataAttribute">
-        <_Parameter1>TestAppLocatiion</_Parameter1>
-        <_Parameter2>$(MSBuildThisFileDirectory)..\TestApp\</_Parameter2>
-      </AssemblyAttribute>
-  </ItemGroup>
-  </Target>
-
 </Project>

src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj

@@ -5,22 +5,16 @@ See https://github.com/aspnet/Benchmarks#benchmarks for usage guidance on using
 
 ### Running the benchmarks
 
-The TestApp is a regular BlazorWASM project and can be run using `dotnet run`. The Driver is an app that connects against an existing Selenium server, and speaks the Benchmark protocol. You generally do not need to run the Driver locally, but if you were to do so, you can either start a selenium-server instance and run using `dotnet run [<selenium-server-port>]` or run it inside a Linux-based docker container.
+The TestApp is a regular BlazorWASM project and can be run using `dotnet run`. The Driver is an app that uses Playwright to launch a browser and run the test app, reporting benchmark results in Crank's protocol format. You generally do not need to run the Driver locally, you can do so if needed via `dotnet run`.
 
-Here are the commands you would need to run it locally inside docker:
-
-1. `dotnet publish -c Release Driver/Wasm.Performance.Driver.csproj`
-2. `docker build -t blazor-local -f ./local.dockerfile . `
-3. `docker run -it blazor-local`
-
-To run the benchmark app in the Benchmark server, run
+The benchmark app can also be run using [Crank](https://github.com/dotnet/crank?tab=readme-ov-file). To run the benchmark app in the Benchmark server, follow the Crank installation steps and then run:
 
 ```
-dotnet run -- --config aspnetcore/src/Components/benchmarkapps/Wasm.Performance/benchmarks.compose.json application.endpoints <BenchmarkServerUri> --scenario blazorwasmbenchmark
+crank --config https://github.com/dotnet/aspnetcore/blob/main/src/Components/benchmarkapps/Wasm.Performance/benchmarks.compose.json?raw=true --config https://github.com/aspnet/Benchmarks/blob/main/scenarios/aspnet.profiles.yml?raw=true --scenario blazorwasmbenchmark --profile aspnet-perf-lin
 ```
 
 If you have local changes that you'd like to benchmark, the easiest way is to push your local changes and tell the server to use your branch:
 
 ```
-dotnet run -- --config aspnetcore/src/Components/benchmarkapps/Wasm.Performance/benchmarks.compose.json application.endpoints <BenchmarkServerUri> --scenario blazorwasmbenchmark --application.buildArguments "gitBranch=mylocalchanges"
-```
+crank --config https://github.com/dotnet/aspnetcore/blob/main/src/Components/benchmarkapps/Wasm.Performance/benchmarks.compose.json?raw=true --config https://github.com/aspnet/Benchmarks/blob/main/scenarios/aspnet.profiles.yml?raw=true --scenario blazorwasmbenchmark --profile aspnet-perf-lin --application.buildArguments gitBranch=myLocalChanges --application.source.branchOrCommit myLocalChanges
+```

src/Components/benchmarkapps/Wasm.Performance/README.md

@@ -5,7 +5,7 @@
     <IsTestAssetProject>true</IsTestAssetProject>
     <!--
       Chrome in docker appears to run in to cache corruption issues when the cache is read multiple times over.
-      Clien caching isn't part of our performance measurement, so we'll skip it.
+      Client caching isn't part of our performance measurement, so we'll skip it.
     -->
     <BlazorCacheBootResources>false</BlazorCacheBootResources>
   </PropertyGroup>

src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj

@@ -25,22 +25,12 @@ RUN git init \
 
 RUN ./restore.sh
 RUN npm run build
-RUN .dotnet/dotnet publish -c Release --no-restore -o /app ./src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj
+RUN .dotnet/dotnet publish -c Release -r linux-x64 --sc true -o /app ./src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj
 RUN chmod +x /app/Wasm.Performance.Driver
 
 WORKDIR /app
-# NOTE: This has been commented out because it is causing our builds to get a build warning
-#       because we are pulling this container image from docker.io. We should consider whether
-#       we need this code in our repo at all, and if not remove it.
-#       If we do need it then we need to get the container image imported into mcr.microsoft.com
-#
-#       I have opened up a PR to do this, however it is not certain we'll be allowed to do this
-#       and there is further legal/compliance work that needs to be done. In the meantime commenting
-#       this out should get our builds to green again whilst this issue is resolved.
-#
-#       PR: https://github.com/microsoft/mcr/pull/3232
-#
-# FROM selenium/standalone-chrome:124.0 as final
+
+FROM mcr.microsoft.com/playwright/dotnet:v1.45.1-jammy-amd64 AS final
 COPY --from=build ./app ./
 COPY ./exec.sh ./
 

src/Components/benchmarkapps/Wasm.Performance/dockerfile

@@ -1,5 +1,3 @@
 #!/usr/bin/env bash
 
-/opt/bin/start-selenium-standalone.sh&
 ./Wasm.Performance.Driver $StressRunDuration
-