Replat on HTTP/3 changes, fixing up minor nits to be compatible with h3-25 (#18912)

Author: jkotalik

src/Servers/Kestrel/Core/ref/Microsoft.AspNetCore.Server.Kestrel.Core.netcoreapp.cs

@@ -239,6 +239,8 @@ public partial interface IHttpHeadersHandler
     {
         void OnHeader(System.ReadOnlySpan<byte> name, System.ReadOnlySpan<byte> value);
         void OnHeadersComplete(bool endStream);
+        void OnStaticIndexedHeader(int index);
+        void OnStaticIndexedHeader(int index, System.ReadOnlySpan<byte> value);
     }
     public partial interface IHttpRequestLineHandler
     {

src/Servers/Kestrel/Core/src/CoreStrings.resx

@@ -581,4 +581,4 @@ For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?l
   <data name="TransportNotFound" xml:space="preserve">
     <value>Unable to resolve service for type 'Microsoft.AspNetCore.Connections.IConnectionListenerFactory' while attempting to activate 'Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer'.</value>
   </data>
-</root>
+</root>

src/Servers/Kestrel/Core/src/Internal/Http/Http1ParsingHandler.cs

@@ -49,5 +49,15 @@ public void OnHeadersComplete(bool endStream)
 
         public void OnStartLine(HttpMethod method, HttpVersion version, Span<byte> target, Span<byte> path, Span<byte> query, Span<byte> customMethod, bool pathEncoded)
             => Connection.OnStartLine(method, version, target, path, query, customMethod, pathEncoded);
+
+        public void OnStaticIndexedHeader(int index)
+        {
+            throw new NotImplementedException();
+        }
+
+        public void OnStaticIndexedHeader(int index, ReadOnlySpan<byte> value)
+        {
+            throw new NotImplementedException();
+        }
     }
 }

src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs

@@ -1192,6 +1192,19 @@ private HttpResponseHeaders CreateResponseHeaders(bool appCompleted)
                 }
             }
 
+            // TODO allow customization of this.
+            if (ServerOptions.EnableAltSvc && _httpVersion < Http.HttpVersion.Http3) 
+            {
+                foreach (var option in ServerOptions.ListenOptions)
+                {
+                    if (option.Protocols == HttpProtocols.Http3)
+                    {
+                        responseHeaders.HeaderAltSvc = $"h3-25=\":{option.IPEndPoint.Port}\"; ma=84600";
+                        break;
+                    }
+                }
+            }
+
             if (ServerOptions.AddServerHeader && !responseHeaders.HasServer)
             {
                 responseHeaders.SetRawServer(Constants.ServerName, _bytesServer);

src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs

@@ -1375,6 +1375,16 @@ private async Task ReadInputAsync()
             }
         }
 
+        public void OnStaticIndexedHeader(int index)
+        {
+            throw new NotImplementedException();
+        }
+
+        public void OnStaticIndexedHeader(int index, ReadOnlySpan<byte> value)
+        {
+            throw new NotImplementedException();
+        }
+
         private class StreamCloseAwaitable : ICriticalNotifyCompletion
         {
             private static readonly Action _callbackCompleted = () => { };

src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3FrameType.cs

@@ -1,9 +1,9 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http3
+namespace System.Net.Http
 {
-    internal partial class Http3Frame
+    internal partial class Http3RawFrame
     {
         public void PrepareData()
         {

src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3Frame.Data.cs renamed to src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3RawFrame.Data.cs

@@ -1,9 +1,9 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http3
+namespace System.Net.Http
 {
-    internal partial class Http3Frame
+    internal partial class Http3RawFrame
     {
         public void PrepareGoAway()
         {

src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3Frame.GoAway.cs renamed to src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3RawFrame.GoAway.cs

@@ -1,9 +1,9 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http3
+namespace System.Net.Http
 {
-    internal partial class Http3Frame
+    internal partial class Http3RawFrame
     {
         public void PrepareHeaders()
         {

src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3Frame.Headers.cs renamed to src/Servers/Kestrel/Core/src/Internal/Http3/Frames/Http3RawFrame.Headers.cs

@@ -1,9 +1,9 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http3
+namespace System.Net.Http
 {
-    internal partial class Http3Frame
+    internal partial class Http3RawFrame
     {
         public void PrepareSettings()
         {