Don't restore npmproj files in parallel (#6560)

NPM does not handle this well, so only run one NPM command at a time

Author: natemcmaster

build/dependencies.props

@@ -20,7 +20,7 @@
     <!-- Determined by build tools -->
     <InternalAspNetCoreSdkPackageVersion>$(KoreBuildVersion)</InternalAspNetCoreSdkPackageVersion>
     <InternalAspNetCoreSiteExtensionSdkPackageVersion>$(KoreBuildVersion)</InternalAspNetCoreSiteExtensionSdkPackageVersion>
-    <InternalAspNetCoreSdkPackageVersion Condition=" '$(KoreBuildVersion)' == '' ">2.1.7-build-20190109.2</InternalAspNetCoreSdkPackageVersion>
+    <InternalAspNetCoreSdkPackageVersion Condition=" '$(KoreBuildVersion)' == '' ">2.1.7-build-20190110.2</InternalAspNetCoreSdkPackageVersion>
   </PropertyGroup>
 
   <!-- These are package versions that should not be overridden or updated by automation. -->

build/repo.props

@@ -70,17 +70,16 @@
     <!-- Project selection can be overridden on the command line by passing in -projects -->
     <When Condition="'$(Projects)' != ''">
       <ItemGroup>
-        <ProjectToBuild Include="$(Projects)" Exclude="@(ProjectToExclude)" />
+        <ProjectToBuild Include="$(Projects)" Exclude="@(ProjectToExclude)">
+          <RestoreInParallel Condition="'%(Extension)' == '.npmproj'">false</RestoreInParallel>
+        </ProjectToBuild>
       </ItemGroup>
     </When>
     <Otherwise>
       <ItemGroup>
-        <SamplesProject Include="$(RepositoryRoot)src\**\samples\**\*.csproj;"/>
-
-        <ProjectToExclude Include="@(SamplesProject)" Condition="'$(BuildSamples)' == 'false' "/>
-
-        <ProjectToBuild Condition="'$(SkipSignalRTypescriptClient)' != 'true'"
+        <ProjectToBuild Condition="'$(SkipNpm)' != 'true'"
                         Include="$(RepositoryRoot)src\SignalR\**\*.npmproj"
+                        RestoreInParallel="false"
                         Exclude="@(ProjectToExclude)" />
 
         <ProjectToBuild Include="
@@ -108,7 +107,9 @@
                           @(ProjectToExclude);
                           $(RepositoryRoot)**\node_modules\**\*;
                           $(RepositoryRoot)**\bin\**\*;
-                          $(RepositoryRoot)**\obj\**\*;" />
+                          $(RepositoryRoot)**\obj\**\*;">
+          <RestoreInParallel Condition="'%(Extension)' == '.npmproj'">false</RestoreInParallel>
+        </ProjectToBuild>
       </ItemGroup>
     </Otherwise>
   </Choose>

eng/scripts/CodeCheck.ps1

@@ -16,8 +16,8 @@ $repoRoot = Resolve-Path "$PSScriptRoot/../../"
 [string[]] $errors = @()
 
 function LogError([string]$message) {
-    Write-Host -f Red "error: $messsage"
-    $errors += $message
+    Write-Host -f Red "error: $message"
+    $script:errors += $message
 }
 
 try {
@@ -81,7 +81,6 @@ finally {
     Write-Host ""
 
     foreach ($err in $errors) {
-
         Write-Host -f Red "error : $err"
     }
 

eng/targets/Npm.Common.targets

@@ -13,8 +13,9 @@
   </Target>
 
   <Target Name="Restore">
-    <!-- Always use 'npm ci' because 'npm install' churns the package-lock.json file for no apparent reason. -->
-    <Exec Command="npm ci" />
+    <Message Importance="High" Text="Running npm install on $(MSBuildProjectFullPath)" />
+    <Exec Command="npm ci" Condition="'$(CI)' == 'true'" />
+    <Exec Command="npm install --no-optional" Condition="'$(CI)' != 'true'" />
   </Target>
 
   <Target Name="PrepareForBuild">

korebuild-lock.txt

@@ -1,2 +1,2 @@
-version:2.1.7-build-20190109.2
-commithash:ac3a3419fc03baebde26ce4ea3abc86fd701271c
+version:2.1.7-build-20190110.2
+commithash:00aefcfd284db33352f35bfa2c74c65f8580e372

src/SignalR/clients/ts/client-ts.npmproj

@@ -3,8 +3,15 @@
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>
+    <!-- The 'build' script for this package just build signalr and signalr-protocol-msgpack, so don't invoke build here. -->
+    <IsBuildable>false</IsBuildable>
     <IsTestProject>true</IsTestProject>
   </PropertyGroup>
 
+  <ItemGroup>
+    <ProjectReference Include="signalr\signalr.npmproj" />
+    <ProjectReference Include="signalr-protocol-msgpack\signalr-protocol-msgpack.npmproj" />
+  </ItemGroup>
+
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Directory.Build.targets))\Directory.Build.targets" />
 </Project>