Use new string.Split() overloads (#23683)

Author: martincostello

src/Hosting/Hosting/src/GenericHost/GenericWebHostedService.cs

@@ -73,7 +73,7 @@ public async Task StartAsync(CancellationToken cancellationToken)
                 {
                     serverAddressesFeature.PreferHostingUrls = WebHostUtilities.ParseBool(Configuration, WebHostDefaults.PreferHostingUrlsKey);
 
-                    foreach (var value in urls.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries))
+                    foreach (var value in urls.Split(';', StringSplitOptions.RemoveEmptyEntries))
                     {
                         addresses.Add(value);
                     }

src/Hosting/Hosting/src/Internal/WebHost.cs

@@ -306,7 +306,7 @@ private void EnsureServer()
                     {
                         serverAddressesFeature.PreferHostingUrls = WebHostUtilities.ParseBool(_config, WebHostDefaults.PreferHostingUrlsKey);
 
-                        foreach (var value in urls.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries))
+                        foreach (var value in urls.Split(';', StringSplitOptions.RemoveEmptyEntries))
                         {
                             addresses.Add(value);
                         }

src/Hosting/Hosting/src/Internal/WebHostOptions.cs

@@ -82,7 +82,7 @@ private IReadOnlyList<string> Split(string value)
             }
 
             var list = new List<string>();
-            foreach (var part in value.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries))
+            foreach (var part in value.Split(';', StringSplitOptions.RemoveEmptyEntries))
             {
                 var trimmedPart = part;
                 if (!string.IsNullOrEmpty(trimmedPart))

src/Shared/RazorViews/BaseView.cs

@@ -20,6 +20,7 @@ namespace Microsoft.Extensions.RazorViews
     internal abstract class BaseView
     {
         private static readonly Encoding UTF8NoBOM = new UTF8Encoding(encoderShouldEmitUTF8Identifier: false, throwOnInvalidBytes: true);
+        private static readonly char[] NewLineChars = new[] { '\r', '\n' };
         private readonly Stack<TextWriter> _textWriterStack = new Stack<TextWriter>();
 
         /// <summary>
@@ -292,8 +293,8 @@ protected string HtmlEncodeAndReplaceLineBreaks(string input)
 
             // Split on line breaks before passing it through the encoder.
             return string.Join("<br />" + Environment.NewLine,
-                input.Split(new[] { "\r\n" }, StringSplitOptions.None)
-                .SelectMany(s => s.Split(new[] { '\r', '\n' }, StringSplitOptions.None))
+                input.Split("\r\n", StringSplitOptions.None)
+                .SelectMany(s => s.Split(NewLineChars, StringSplitOptions.None))
                 .Select(HtmlEncoder.Encode));
         }
     }