Unquarantine passed and fixed tests (#29438)

BrennanConroy · web-flow · commit 3f7b205c7c73 · 2021-01-20T13:57:51.000-08:00
diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs
@@ -19,7 +19,6 @@ public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerF
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24688")]
         public override void EventDuringBatchRendering_CanTriggerDOMEvents()
         {
             base.EventDuringBatchRendering_CanTriggerDOMEvents();
diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs
@@ -35,7 +35,7 @@ protected override void InitializeAsyncCore()
         }
 
         [Theory]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27556")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27155")]
         [InlineData("en-US")]
         [InlineData("fr-FR")]
         public override void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture)
diff --git a/src/Components/test/E2ETest/Tests/BinaryHttpClientTest.cs b/src/Components/test/E2ETest/Tests/BinaryHttpClientTest.cs
@@ -43,7 +43,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
         public void CanSendAndReceiveBytes()
         {
             IssueRequest("/subdir/api/data");
diff --git a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs
@@ -42,7 +42,6 @@ public void BasicTestAppCanBeServed()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
         public void CanRenderTextOnlyComponent()
         {
             var appElement = Browser.MountTestComponent<TextOnlyComponent>();
diff --git a/src/Components/test/E2ETest/Tests/EventBubblingTest.cs b/src/Components/test/E2ETest/Tests/EventBubblingTest.cs
@@ -48,7 +48,6 @@ public void BubblingStandardEvent_FiredOnElementWithHandler()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
         public void BubblingStandardEvent_FiredOnElementWithoutHandler()
         {
             Browser.Exists(By.Id("button-without-onclick")).Click();
diff --git a/src/Components/test/E2ETest/Tests/EventTest.cs b/src/Components/test/E2ETest/Tests/EventTest.cs
@@ -177,7 +177,6 @@ public void PreventDefault_AppliesToFormOnSubmitHandlers()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]
         public void PreventDefault_DotNotApplyByDefault()
         {
             var appElement = Browser.MountTestComponent<EventPreventDefaultComponent>();
@@ -204,7 +203,6 @@ public void InputEvent_RespondsOnKeystrokes()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23757")]
         public void InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy()
         {
             // This test doesn't mean much on WebAssembly - it just shows that even if the CPU is locked
diff --git a/src/Components/test/E2ETest/Tests/FormsTest.cs b/src/Components/test/E2ETest/Tests/FormsTest.cs
@@ -195,7 +195,6 @@ public void InputTextAreaInteractsWithEditContext()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27398")]
         public void InputDateInteractsWithEditContext_NonNullableDateTime()
         {
             var appElement = MountTypicalValidationComponent();
@@ -304,7 +303,6 @@ public void InputCheckboxInteractsWithEditContext()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24850")]
         public void InputRadioGroupWithoutNameInteractsWithEditContext()
         {
             var appElement = MountTypicalValidationComponent();
@@ -344,7 +342,6 @@ IWebElement FindBestAirlineInput()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24850")]
         public void InputRadioGroupsWithNamesNestedInteractWithEditContext()
         {
             var appElement = MountTypicalValidationComponent();
diff --git a/src/Components/test/E2ETest/Tests/InputFileTest.cs b/src/Components/test/E2ETest/Tests/InputFileTest.cs
@@ -66,7 +66,6 @@ public void CanUploadSingleSmallFile()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26331")]
         public void CanUploadSingleLargeFile()
         {
             // Create a large text file
@@ -131,7 +130,6 @@ public void CanUploadMultipleFiles()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]
         public void CanUploadAndConvertImageFile()
         {
             var sourceImageId = "image-source";
diff --git a/src/Components/test/E2ETest/Tests/InteropTest.cs b/src/Components/test/E2ETest/Tests/InteropTest.cs
@@ -33,7 +33,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26288")]
         public void CanInvokeDotNetMethods()
         {
             // Arrange
diff --git a/src/Components/test/E2ETest/Tests/PerformanceTest.cs b/src/Components/test/E2ETest/Tests/PerformanceTest.cs
@@ -36,7 +36,6 @@ public void HasTitle()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
         public void BenchmarksRunWithoutError()
         {
             // In CI, we only verify that the benchmarks run without throwing any
diff --git a/src/Components/test/E2ETest/Tests/VirtualizationTest.cs b/src/Components/test/E2ETest/Tests/VirtualizationTest.cs
@@ -195,7 +195,6 @@ public void CancelsOutdatedRefreshes_Async()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24922")]
         public void CanUseViewportAsContainer()
         {
             Browser.MountTestComponent<VirtualizationComponent>();
diff --git a/src/Components/test/E2ETest/Tests/WebAssemblyLazyLoadTest.cs b/src/Components/test/E2ETest/Tests/WebAssemblyLazyLoadTest.cs
@@ -36,7 +36,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23856")]
         public void CanLazyLoadOnRouteChange()
         {
             // Navigate to a page without any lazy-loaded dependencies
@@ -61,7 +60,6 @@ public void CanLazyLoadOnRouteChange()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23856")]
         public void CanLazyLoadOnFirstVisit()
         {
             // Navigate to a page with lazy loaded assemblies for the first time
diff --git a/src/Hosting/test/FunctionalTests/ShutdownTests.cs b/src/Hosting/test/FunctionalTests/ShutdownTests.cs
@@ -26,7 +26,6 @@ public class ShutdownTests : LoggedTest
         public ShutdownTests(ITestOutputHelper output) : base(output) { }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23610")]
         [OSSkipCondition(OperatingSystems.Windows)]
         [OSSkipCondition(OperatingSystems.MacOSX)]
         public async Task ShutdownTestRun()
diff --git a/src/Hosting/test/FunctionalTests/WebHostBuilderTests.cs b/src/Hosting/test/FunctionalTests/WebHostBuilderTests.cs
@@ -22,7 +22,6 @@ public WebHostBuilderTests(ITestOutputHelper output) : base(output) { }
 
         [ConditionalTheory]
         [MemberData(nameof(TestVariants))]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27557")]
         public async Task InjectedStartup_DefaultApplicationNameIsEntryAssembly(TestVariant variant)
         {
             using (StartLog(out var loggerFactory))
diff --git a/src/Mvc/test/Mvc.FunctionalTests/HtmlGenerationTest.cs b/src/Mvc/test/Mvc.FunctionalTests/HtmlGenerationTest.cs
@@ -143,7 +143,6 @@ public Task HtmlGenerationWebSite_GeneratesExpectedResultsNotReadyForHelix(strin
             => HtmlGenerationWebSite_GeneratesExpectedResults(action, antiforgeryPath);
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25206")]
         public async Task HtmlGenerationWebSite_GeneratesExpectedResults_WithImageData()
         {
             await HtmlGenerationWebSite_GeneratesExpectedResults("Image", antiforgeryPath: null);
diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/test/ConcatenateFilesTest.cs b/src/Razor/Microsoft.NET.Sdk.Razor/test/ConcatenateFilesTest.cs
@@ -324,7 +324,6 @@ public void BundlesScopedCssFiles_DoesNotOverrideBundleForSameContents()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25623")]
         public async System.Threading.Tasks.Task BundlesScopedCssFiles_UpdatesBundleWhenContentsChange()
         {
             // Arrange
diff --git a/src/Servers/IIS/IIS/test/Common.FunctionalTests/Http2Tests.cs b/src/Servers/IIS/IIS/test/Common.FunctionalTests/Http2Tests.cs
@@ -38,7 +38,6 @@ public Http2Tests(IISTestSiteFixture fixture)
 
         public IISTestSiteFixture Fixture { get; }
 
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/28265")]
         [ConditionalTheory]
         [InlineData("GET")]
         [InlineData("HEAD")]
diff --git a/src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs b/src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
@@ -179,7 +179,6 @@ public async Task WriterThrowsCanceledException()
 
         [ConditionalFact]
         [Repeat]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26330")]
         public async Task ReaderThrowsCanceledException()
         {
             var readIsAsyncCompletionSource = CreateTaskCompletionSource();

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerF`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`[Fact]`
`22`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24688")]`
`23`	`22`	`public override void EventDuringBatchRendering_CanTriggerDOMEvents()`
`24`	`23`	`{`
`25`	`24`	`base.EventDuringBatchRendering_CanTriggerDOMEvents();`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ protected override void InitializeAsyncCore()`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`[Theory]`
`38`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27556")]`
	`38`	`+ [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27155")]`
`39`	`39`	`[InlineData("en-US")]`
`40`	`40`	`[InlineData("fr-FR")]`
`41`	`41`	`public override void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture)`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,6 @@ protected override void InitializeAsyncCore()`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`[Fact]`
`46`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]`
`47`	`46`	`public void CanSendAndReceiveBytes()`
`48`	`47`	`{`
`49`	`48`	`IssueRequest("/subdir/api/data");`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,6 @@ public void BasicTestAppCanBeServed()`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`[Fact]`
`45`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]`
`46`	`45`	`public void CanRenderTextOnlyComponent()`
`47`	`46`	`{`
`48`	`47`	`var appElement = Browser.MountTestComponent<TextOnlyComponent>();`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ public void BubblingStandardEvent_FiredOnElementWithHandler()`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`[Fact]`
`51`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]`
`52`	`51`	`public void BubblingStandardEvent_FiredOnElementWithoutHandler()`
`53`	`52`	`{`
`54`	`53`	`Browser.Exists(By.Id("button-without-onclick")).Click();`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,6 @@ public void PreventDefault_AppliesToFormOnSubmitHandlers()`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`[Fact]`
`180`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]`
`181`	`180`	`public void PreventDefault_DotNotApplyByDefault()`
`182`	`181`	`{`
`183`	`182`	`var appElement = Browser.MountTestComponent<EventPreventDefaultComponent>();`
`@@ -204,7 +203,6 @@ public void InputEvent_RespondsOnKeystrokes()`
`204`	`203`	`}`
`205`	`204`
`206`	`205`	`[Fact]`
`207`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23757")]`
`208`	`206`	`public void InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy()`
`209`	`207`	`{`
`210`	`208`	`// This test doesn't mean much on WebAssembly - it just shows that even if the CPU is locked`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,6 @@ public void InputTextAreaInteractsWithEditContext()`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`[Fact]`
`198`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27398")]`
`199`	`198`	`public void InputDateInteractsWithEditContext_NonNullableDateTime()`
`200`	`199`	`{`
`201`	`200`	`var appElement = MountTypicalValidationComponent();`
`@@ -304,7 +303,6 @@ public void InputCheckboxInteractsWithEditContext()`
`304`	`303`	`}`
`305`	`304`
`306`	`305`	`[Fact]`
`307`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24850")]`
`308`	`306`	`public void InputRadioGroupWithoutNameInteractsWithEditContext()`
`309`	`307`	`{`
`310`	`308`	`var appElement = MountTypicalValidationComponent();`
`@@ -344,7 +342,6 @@ IWebElement FindBestAirlineInput()`
`344`	`342`	`}`
`345`	`343`
`346`	`344`	`[Fact]`
`347`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24850")]`
`348`	`345`	`public void InputRadioGroupsWithNamesNestedInteractWithEditContext()`
`349`	`346`	`{`
`350`	`347`	`var appElement = MountTypicalValidationComponent();`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ public void CanUploadSingleSmallFile()`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`[Fact]`
`69`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26331")]`
`70`	`69`	`public void CanUploadSingleLargeFile()`
`71`	`70`	`{`
`72`	`71`	`// Create a large text file`
`@@ -131,7 +130,6 @@ public void CanUploadMultipleFiles()`
`131`	`130`	`}`
`132`	`131`
`133`	`132`	`[Fact]`
`134`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]`
`135`	`133`	`public void CanUploadAndConvertImageFile()`
`136`	`134`	`{`
`137`	`135`	`var sourceImageId = "image-source";`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ protected override void InitializeAsyncCore()`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`[Fact]`
`36`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26288")]`
`37`	`36`	`public void CanInvokeDotNetMethods()`
`38`	`37`	`{`
`39`	`38`	`// Arrange`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ public void HasTitle()`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`[Fact]`
`39`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]`
`40`	`39`	`public void BenchmarksRunWithoutError()`
`41`	`40`	`{`
`42`	`41`	`// In CI, we only verify that the benchmarks run without throwing any`