Skip to content

Commit 2c33bca

Browse files
Quarantine IIS test, fix Kestrel test (#29429)
1 parent eadca9d commit 2c33bca

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/Servers/IIS/IIS/test/Common.FunctionalTests/FrebTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ public async Task CheckFailedRequestEvents()
8686
[MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H1, SkipReason = "Shutdown hangs https://github.com/dotnet/aspnetcore/issues/25107")]
8787
[Repeat(10)]
8888
[RequiresIIS(IISCapability.FailedRequestTracingModule)]
89+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/29428")]
8990
public async Task CheckFrebDisconnect()
9091
{
9192
var result = await SetupFrebApp();

src/Servers/Kestrel/test/InMemory.FunctionalTests/UpgradeTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) .NET Foundation. All rights reserved.
1+
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

44
using System;
@@ -234,7 +234,7 @@ public async Task AcceptsRequestWithChunkedEncodingAndUpgrade()
234234
{
235235
Assert.False(feature.IsUpgradableRequest);
236236
Assert.Equal("chunked", context.Request.Headers[HeaderNames.TransferEncoding]);
237-
Assert.Equal(11, await context.Request.Body.ReadAsync(new byte[12], 0, 12));
237+
Assert.Equal(11, await context.Request.Body.ReadUntilEndAsync(new byte[100]));
238238
}
239239
else
240240
{
@@ -400,7 +400,7 @@ public async Task DoesNotThrowGivenCanceledReadResult()
400400
connectionTransportFeature.Transport.Input.CancelPendingRead();
401401

402402
// Use ReadAsync() instead of CopyToAsync() for this test since IsCanceled is only checked in
403-
// HttpRequestStream.ReadAsync() and not HttpRequestStream.CopyToAsync()
403+
// HttpRequestStream.ReadAsync() and not HttpRequestStream.CopyToAsync()
404404
Assert.Equal(0, await duplexStream.ReadAsync(new byte[1]));
405405
appCompletedTcs.SetResult(null);
406406
}

0 commit comments

Comments
 (0)