Sync shared code from runtime (#23853)

github-actions[bot] · web-flow · commit 241e45d2b997 · 2020-07-11T00:45:53.000Z
Co-authored-by: github-actions[bot] &lt;41898282+github-actions[bot]@users.noreply.github.com&gt;
diff --git a/src/Shared/runtime/NetEventSource.Common.cs b/src/Shared/runtime/NetEventSource.Common.cs
@@ -29,14 +29,9 @@ namespace System.Net
     // Usage:
     // - Operations that may allocate (e.g. boxing a value type, using string interpolation, etc.) or that may have computations
     //   at call sites should guard access like:
-    //       if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this, refArg1, valueTypeArg2); // entering an instance method with a value type arg
     //       if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, $"Found certificate: {cert}"); // info logging with a formattable string
     // - Operations that have zero allocations / measurable computations at call sites can use a simpler pattern, calling methods like:
-    //       NetEventSource.Enter(this);                   // entering an instance method
     //       NetEventSource.Info(this, "literal string");  // arbitrary message with a literal string
-    //       NetEventSource.Enter(this, refArg1, regArg2); // entering an instance method with two reference type arguments
-    //       NetEventSource.Enter(null);                   // entering a static method
-    //       NetEventSource.Enter(null, refArg1);          // entering a static method with one reference type argument
     //   Debug.Asserts inside the logging methods will help to flag some misuse if the DEBUG_NETEVENTSOURCE_MISUSE compilation constant is defined.
     //   However, because it can be difficult by observation to understand all of the costs involved, guarding can be done everywhere.
     // - NetEventSource.Fail calls typically do not need to be prefixed with an IsEnabled check, even if they allocate, as FailMessage
@@ -103,7 +98,7 @@ public static void Enter(object? thisOrContextObject, FormattableString? formatt
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(formattableString);
-            if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);
+            if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);
         }
 
         /// <summary>Logs entrance to a method.</summary>
@@ -115,7 +110,7 @@ public static void Enter(object? thisOrContextObject, object arg0, [CallerMember
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(arg0);
-            if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)})");
+            if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)})");
         }
 
         /// <summary>Logs entrance to a method.</summary>
@@ -129,7 +124,7 @@ public static void Enter(object? thisOrContextObject, object arg0, object arg1,
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(arg0);
             DebugValidateArg(arg1);
-            if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)})");
+            if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)})");
         }
 
         /// <summary>Logs entrance to a method.</summary>
@@ -145,7 +140,7 @@ public static void Enter(object? thisOrContextObject, object arg0, object arg1,
             DebugValidateArg(arg0);
             DebugValidateArg(arg1);
             DebugValidateArg(arg2);
-            if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)}, {Format(arg2)})");
+            if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)}, {Format(arg2)})");
         }
 
         [Event(EnterEventId, Level = EventLevel.Informational, Keywords = Keywords.EnterExit)]
@@ -163,7 +158,7 @@ public static void Exit(object? thisOrContextObject, FormattableString? formatta
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(formattableString);
-            if (Log.IsEnabled()) Log.Exit(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);
+            if (IsEnabled) Log.Exit(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);
         }
 
         /// <summary>Logs exit from a method.</summary>
@@ -175,7 +170,7 @@ public static void Exit(object? thisOrContextObject, object arg0, [CallerMemberN
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(arg0);
-            if (Log.IsEnabled()) Log.Exit(IdOf(thisOrContextObject), memberName, Format(arg0).ToString());
+            if (IsEnabled) Log.Exit(IdOf(thisOrContextObject), memberName, Format(arg0).ToString());
         }
 
         /// <summary>Logs exit from a method.</summary>
@@ -189,7 +184,7 @@ public static void Exit(object? thisOrContextObject, object arg0, object arg1, [
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(arg0);
             DebugValidateArg(arg1);
-            if (Log.IsEnabled()) Log.Exit(IdOf(thisOrContextObject), memberName, $"{Format(arg0)}, {Format(arg1)}");
+            if (IsEnabled) Log.Exit(IdOf(thisOrContextObject), memberName, $"{Format(arg0)}, {Format(arg1)}");
         }
 
         [Event(ExitEventId, Level = EventLevel.Informational, Keywords = Keywords.EnterExit)]
@@ -207,7 +202,7 @@ public static void Info(object? thisOrContextObject, FormattableString? formatta
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(formattableString);
-            if (Log.IsEnabled()) Log.Info(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);
+            if (IsEnabled) Log.Info(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);
         }
 
         /// <summary>Logs an information message.</summary>
@@ -219,7 +214,7 @@ public static void Info(object? thisOrContextObject, object? message, [CallerMem
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(message);
-            if (Log.IsEnabled()) Log.Info(IdOf(thisOrContextObject), memberName, Format(message).ToString());
+            if (IsEnabled) Log.Info(IdOf(thisOrContextObject), memberName, Format(message).ToString());
         }
 
         [Event(InfoEventId, Level = EventLevel.Informational, Keywords = Keywords.Default)]
@@ -237,7 +232,7 @@ public static void Error(object? thisOrContextObject, FormattableString formatta
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(formattableString);
-            if (Log.IsEnabled()) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(formattableString));
+            if (IsEnabled) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(formattableString));
         }
 
         /// <summary>Logs an error message.</summary>
@@ -249,7 +244,7 @@ public static void Error(object? thisOrContextObject, object message, [CallerMem
         {
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(message);
-            if (Log.IsEnabled()) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(message).ToString());
+            if (IsEnabled) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(message).ToString());
         }
 
         [Event(ErrorEventId, Level = EventLevel.Error, Keywords = Keywords.Default)]
@@ -268,7 +263,7 @@ public static void Fail(object? thisOrContextObject, FormattableString formattab
             // Don't call DebugValidateArg on args, as we expect Fail to be used in assert/failure situations
             // that should never happen in production, and thus we don't care about extra costs.
 
-            if (Log.IsEnabled()) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(formattableString));
+            if (IsEnabled) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(formattableString));
             Debug.Fail(Format(formattableString), $"{IdOf(thisOrContextObject)}.{memberName}");
         }
 
@@ -282,7 +277,7 @@ public static void Fail(object? thisOrContextObject, object message, [CallerMemb
             // Don't call DebugValidateArg on args, as we expect Fail to be used in assert/failure situations
             // that should never happen in production, and thus we don't care about extra costs.
 
-            if (Log.IsEnabled()) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(message).ToString());
+            if (IsEnabled) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(message).ToString());
             Debug.Fail(Format(message).ToString(), $"{IdOf(thisOrContextObject)}.{memberName}");
         }
 
@@ -311,7 +306,7 @@ public static void DumpBuffer(object? thisOrContextObject, byte[] buffer, [Calle
         [NonEvent]
         public static void DumpBuffer(object? thisOrContextObject, byte[] buffer, int offset, int count, [CallerMemberName] string? memberName = null)
         {
-            if (Log.IsEnabled())
+            if (IsEnabled)
             {
                 if (offset < 0 || offset > buffer.Length - count)
                 {
@@ -343,7 +338,7 @@ public static unsafe void DumpBuffer(object? thisOrContextObject, IntPtr bufferP
             Debug.Assert(bufferPtr != IntPtr.Zero);
             Debug.Assert(count >= 0);
 
-            if (Log.IsEnabled())
+            if (IsEnabled)
             {
                 var buffer = new byte[Math.Min(count, MaxDumpSize)];
                 fixed (byte* targetPtr = buffer)
@@ -369,7 +364,7 @@ public static void Associate(object first, object second, [CallerMemberName] str
         {
             DebugValidateArg(first);
             DebugValidateArg(second);
-            if (Log.IsEnabled()) Log.Associate(IdOf(first), memberName, IdOf(first), IdOf(second));
+            if (IsEnabled) Log.Associate(IdOf(first), memberName, IdOf(first), IdOf(second));
         }
 
         /// <summary>Logs a relationship between two objects.</summary>
@@ -383,7 +378,7 @@ public static void Associate(object? thisOrContextObject, object first, object s
             DebugValidateArg(thisOrContextObject);
             DebugValidateArg(first);
             DebugValidateArg(second);
-            if (Log.IsEnabled()) Log.Associate(IdOf(thisOrContextObject), memberName, IdOf(first), IdOf(second));
+            if (IsEnabled) Log.Associate(IdOf(thisOrContextObject), memberName, IdOf(first), IdOf(second));
         }
 
         [Event(AssociateEventId, Level = EventLevel.Informational, Keywords = Keywords.Default, Message = "[{2}]<-->[{3}]")]
@@ -396,7 +391,7 @@ private void Associate(string thisOrContextObject, string? memberName, string fi
         [Conditional("DEBUG_NETEVENTSOURCE_MISUSE")]
         private static void DebugValidateArg(object? arg)
         {
-            if (!Log.IsEnabled())
+            if (!IsEnabled)
             {
                 Debug.Assert(!(arg is ValueType), $"Should not be passing value type {arg?.GetType()} to logging without IsEnabled check");
                 Debug.Assert(!(arg is FormattableString), $"Should not be formatting FormattableString \"{arg}\" if tracing isn't enabled");
@@ -406,9 +401,12 @@ private static void DebugValidateArg(object? arg)
         [Conditional("DEBUG_NETEVENTSOURCE_MISUSE")]
         private static void DebugValidateArg(FormattableString? arg)
         {
-            Debug.Assert(Log.IsEnabled() || arg == null, $"Should not be formatting FormattableString \"{arg}\" if tracing isn't enabled");
+            Debug.Assert(IsEnabled || arg == null, $"Should not be formatting FormattableString \"{arg}\" if tracing isn't enabled");
         }
 
+        public static new bool IsEnabled =>
+            Log.IsEnabled();
+
         [NonEvent]
         public static string IdOf(object? value) => value != null ? value.GetType().Name + "#" + GetHashCode(value) : NullInstance;
 
diff --git a/src/Shared/runtime/Quic/Implementations/MsQuic/MsQuicConnection.cs b/src/Shared/runtime/Quic/Implementations/MsQuic/MsQuicConnection.cs
@@ -51,21 +51,17 @@ internal sealed class MsQuicConnection : QuicConnectionProvider
         // constructor for inbound connections
         public MsQuicConnection(IPEndPoint localEndPoint, IPEndPoint remoteEndPoint, IntPtr nativeObjPtr)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
             _localEndPoint = localEndPoint;
             _remoteEndPoint = remoteEndPoint;
             _ptr = nativeObjPtr;
 
             SetCallbackHandler();
             SetIdleTimeout(TimeSpan.FromSeconds(120));
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
         }
 
         // constructor for outbound connections
         public MsQuicConnection(QuicClientConnectionOptions options)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             // TODO need to figure out if/how we want to expose sessions
             // Creating a session per connection isn't ideal.
             _session = new MsQuicSession();
@@ -74,8 +70,6 @@ public MsQuicConnection(QuicClientConnectionOptions options)
 
             SetCallbackHandler();
             SetIdleTimeout(options.IdleTimeout);
-
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
         }
 
         internal override IPEndPoint LocalEndPoint
@@ -168,8 +162,6 @@ internal uint HandleEvent(ref ConnectionEvent connectionEvent)
 
         private uint HandleEventConnected(ConnectionEvent connectionEvent)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             SOCKADDR_INET inetAddress = MsQuicParameterHelpers.GetINetParam(MsQuicApi.Api, _ptr, (uint)QUIC_PARAM_LEVEL.CONNECTION, (uint)QUIC_PARAM_CONN.LOCAL_ADDRESS);
             _localEndPoint = MsQuicAddressHelpers.INetToIPEndPoint(inetAddress);
 
@@ -179,22 +171,18 @@ private uint HandleEventConnected(ConnectionEvent connectionEvent)
             // handle event shutdown initiated by transport
             _connectTcs.Complete(MsQuicStatusCodes.Success);
 
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
             return MsQuicStatusCodes.Success;
         }
 
         private uint HandleEventShutdownInitiatedByTransport(ConnectionEvent connectionEvent)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             if (!_connected)
             {
                 _connectTcs.CompleteException(new IOException("Connection has been shutdown."));
             }
 
             _acceptQueue.Writer.Complete();
 
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
 
             return MsQuicStatusCodes.Success;
         }
@@ -208,23 +196,14 @@ private uint HandleEventShutdownInitiatedByPeer(ConnectionEvent connectionEvent)
 
         private uint HandleEventShutdownComplete(ConnectionEvent connectionEvent)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             _shutdownTcs.Complete(MsQuicStatusCodes.Success);
-
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
             return MsQuicStatusCodes.Success;
         }
 
         private uint HandleEventNewStream(ConnectionEvent connectionEvent)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             MsQuicStream msQuicStream = new MsQuicStream(this, connectionEvent.StreamFlags, connectionEvent.Data.NewStream.Stream, inbound: true);
-
             _acceptQueue.Writer.TryWrite(msQuicStream);
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
-
             return MsQuicStatusCodes.Success;
         }
 
@@ -235,8 +214,6 @@ private uint HandleEventStreamsAvailable(ConnectionEvent connectionEvent)
 
         internal override async ValueTask<QuicStreamProvider> AcceptStreamAsync(CancellationToken cancellationToken = default)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             ThrowIfDisposed();
 
             MsQuicStream stream;
@@ -254,7 +231,6 @@ internal override async ValueTask<QuicStreamProvider> AcceptStreamAsync(Cancella
                 };
             }
 
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
             return stream;
         }
 
@@ -305,8 +281,6 @@ internal override ValueTask ConnectAsync(CancellationToken cancellationToken = d
         private MsQuicStream StreamOpen(
             QUIC_STREAM_OPEN_FLAG flags)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             IntPtr streamPtr = IntPtr.Zero;
             QuicExceptionHelpers.ThrowIfFailed(
                 MsQuicApi.Api.StreamOpenDelegate(
@@ -317,10 +291,7 @@ private MsQuicStream StreamOpen(
                 out streamPtr),
                 "Failed to open stream to peer.");
 
-            MsQuicStream stream = new MsQuicStream(this, flags, streamPtr, inbound: false);
-
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
-            return stream;
+            return new MsQuicStream(this, flags, streamPtr, inbound: false);
         }
 
         private void SetCallbackHandler()
@@ -337,15 +308,12 @@ private ValueTask ShutdownAsync(
             QUIC_CONNECTION_SHUTDOWN_FLAG Flags,
             long ErrorCode)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             uint status = MsQuicApi.Api.ConnectionShutdownDelegate(
                 _ptr,
                 (uint)Flags,
                 ErrorCode);
             QuicExceptionHelpers.ThrowIfFailed(status, "Failed to shutdown connection.");
 
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
             return _shutdownTcs.GetTypelessValueTask();
         }
 
@@ -377,8 +345,6 @@ private void Dispose(bool disposing)
                 return;
             }
 
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             if (_ptr != IntPtr.Zero)
             {
                 MsQuicApi.Api.ConnectionCloseDelegate?.Invoke(_ptr);
@@ -394,8 +360,6 @@ private void Dispose(bool disposing)
             }
 
             _disposed = true;
-
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
         }
 
         internal override ValueTask CloseAsync(long errorCode, CancellationToken cancellationToken = default)
diff --git a/src/Shared/runtime/Quic/Implementations/MsQuic/MsQuicListener.cs b/src/Shared/runtime/Quic/Implementations/MsQuic/MsQuicListener.cs
@@ -62,8 +62,6 @@ internal override IPEndPoint ListenEndPoint
 
         internal override async ValueTask<QuicConnectionProvider> AcceptConnectionAsync(CancellationToken cancellationToken = default)
         {
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);
-
             ThrowIfDisposed();
 
             MsQuicConnection connection;
@@ -81,7 +79,6 @@ await connection.SetSecurityConfigForConnection(_sslOptions.ServerCertificate!,
                 _options.CertificateFilePath,
                 _options.PrivateKeyFilePath).ConfigureAwait(false);
 
-            if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);
             return connection;
         }
 
diff --git a/src/Shared/runtime/Quic/Implementations/MsQuic/MsQuicStream.cs b/src/Shared/runtime/Quic/Implementations/MsQuic/MsQuicStream.cs

Original file line number	Diff line number	Diff line change
`@@ -29,14 +29,9 @@ namespace System.Net`
`29`	`29`	`// Usage:`
`30`	`30`	`// - Operations that may allocate (e.g. boxing a value type, using string interpolation, etc.) or that may have computations`
`31`	`31`	`// at call sites should guard access like:`
`32`		`- // if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this, refArg1, valueTypeArg2); // entering an instance method with a value type arg`
`33`	`32`	`// if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, $"Found certificate: {cert}"); // info logging with a formattable string`
`34`	`33`	`// - Operations that have zero allocations / measurable computations at call sites can use a simpler pattern, calling methods like:`
`35`		`- // NetEventSource.Enter(this); // entering an instance method`
`36`	`34`	`// NetEventSource.Info(this, "literal string"); // arbitrary message with a literal string`
`37`		`- // NetEventSource.Enter(this, refArg1, regArg2); // entering an instance method with two reference type arguments`
`38`		`- // NetEventSource.Enter(null); // entering a static method`
`39`		`- // NetEventSource.Enter(null, refArg1); // entering a static method with one reference type argument`
`40`	`35`	`// Debug.Asserts inside the logging methods will help to flag some misuse if the DEBUG_NETEVENTSOURCE_MISUSE compilation constant is defined.`
`41`	`36`	`// However, because it can be difficult by observation to understand all of the costs involved, guarding can be done everywhere.`
`42`	`37`	`// - NetEventSource.Fail calls typically do not need to be prefixed with an IsEnabled check, even if they allocate, as FailMessage`
`@@ -103,7 +98,7 @@ public static void Enter(object? thisOrContextObject, FormattableString? formatt`
`103`	`98`	`{`
`104`	`99`	`DebugValidateArg(thisOrContextObject);`
`105`	`100`	`DebugValidateArg(formattableString);`
`106`		`- if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);`
	`101`	`+ if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);`
`107`	`102`	`}`
`108`	`103`
`109`	`104`	`/// <summary>Logs entrance to a method.</summary>`
`@@ -115,7 +110,7 @@ public static void Enter(object? thisOrContextObject, object arg0, [CallerMember`
`115`	`110`	`{`
`116`	`111`	`DebugValidateArg(thisOrContextObject);`
`117`	`112`	`DebugValidateArg(arg0);`
`118`		`- if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)})");`
	`113`	`+ if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)})");`
`119`	`114`	`}`
`120`	`115`
`121`	`116`	`/// <summary>Logs entrance to a method.</summary>`
`@@ -129,7 +124,7 @@ public static void Enter(object? thisOrContextObject, object arg0, object arg1,`
`129`	`124`	`DebugValidateArg(thisOrContextObject);`
`130`	`125`	`DebugValidateArg(arg0);`
`131`	`126`	`DebugValidateArg(arg1);`
`132`		`- if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)})");`
	`127`	`+ if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)})");`
`133`	`128`	`}`
`134`	`129`
`135`	`130`	`/// <summary>Logs entrance to a method.</summary>`
`@@ -145,7 +140,7 @@ public static void Enter(object? thisOrContextObject, object arg0, object arg1,`
`145`	`140`	`DebugValidateArg(arg0);`
`146`	`141`	`DebugValidateArg(arg1);`
`147`	`142`	`DebugValidateArg(arg2);`
`148`		`- if (Log.IsEnabled()) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)}, {Format(arg2)})");`
	`143`	`+ if (IsEnabled) Log.Enter(IdOf(thisOrContextObject), memberName, $"({Format(arg0)}, {Format(arg1)}, {Format(arg2)})");`
`149`	`144`	`}`
`150`	`145`
`151`	`146`	`[Event(EnterEventId, Level = EventLevel.Informational, Keywords = Keywords.EnterExit)]`
`@@ -163,7 +158,7 @@ public static void Exit(object? thisOrContextObject, FormattableString? formatta`
`163`	`158`	`{`
`164`	`159`	`DebugValidateArg(thisOrContextObject);`
`165`	`160`	`DebugValidateArg(formattableString);`
`166`		`- if (Log.IsEnabled()) Log.Exit(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);`
	`161`	`+ if (IsEnabled) Log.Exit(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);`
`167`	`162`	`}`
`168`	`163`
`169`	`164`	`/// <summary>Logs exit from a method.</summary>`
`@@ -175,7 +170,7 @@ public static void Exit(object? thisOrContextObject, object arg0, [CallerMemberN`
`175`	`170`	`{`
`176`	`171`	`DebugValidateArg(thisOrContextObject);`
`177`	`172`	`DebugValidateArg(arg0);`
`178`		`- if (Log.IsEnabled()) Log.Exit(IdOf(thisOrContextObject), memberName, Format(arg0).ToString());`
	`173`	`+ if (IsEnabled) Log.Exit(IdOf(thisOrContextObject), memberName, Format(arg0).ToString());`
`179`	`174`	`}`
`180`	`175`
`181`	`176`	`/// <summary>Logs exit from a method.</summary>`
`@@ -189,7 +184,7 @@ public static void Exit(object? thisOrContextObject, object arg0, object arg1, [`
`189`	`184`	`DebugValidateArg(thisOrContextObject);`
`190`	`185`	`DebugValidateArg(arg0);`
`191`	`186`	`DebugValidateArg(arg1);`
`192`		`- if (Log.IsEnabled()) Log.Exit(IdOf(thisOrContextObject), memberName, $"{Format(arg0)}, {Format(arg1)}");`
	`187`	`+ if (IsEnabled) Log.Exit(IdOf(thisOrContextObject), memberName, $"{Format(arg0)}, {Format(arg1)}");`
`193`	`188`	`}`
`194`	`189`
`195`	`190`	`[Event(ExitEventId, Level = EventLevel.Informational, Keywords = Keywords.EnterExit)]`
`@@ -207,7 +202,7 @@ public static void Info(object? thisOrContextObject, FormattableString? formatta`
`207`	`202`	`{`
`208`	`203`	`DebugValidateArg(thisOrContextObject);`
`209`	`204`	`DebugValidateArg(formattableString);`
`210`		`- if (Log.IsEnabled()) Log.Info(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);`
	`205`	`+ if (IsEnabled) Log.Info(IdOf(thisOrContextObject), memberName, formattableString != null ? Format(formattableString) : NoParameters);`
`211`	`206`	`}`
`212`	`207`
`213`	`208`	`/// <summary>Logs an information message.</summary>`
`@@ -219,7 +214,7 @@ public static void Info(object? thisOrContextObject, object? message, [CallerMem`
`219`	`214`	`{`
`220`	`215`	`DebugValidateArg(thisOrContextObject);`
`221`	`216`	`DebugValidateArg(message);`
`222`		`- if (Log.IsEnabled()) Log.Info(IdOf(thisOrContextObject), memberName, Format(message).ToString());`
	`217`	`+ if (IsEnabled) Log.Info(IdOf(thisOrContextObject), memberName, Format(message).ToString());`
`223`	`218`	`}`
`224`	`219`
`225`	`220`	`[Event(InfoEventId, Level = EventLevel.Informational, Keywords = Keywords.Default)]`
`@@ -237,7 +232,7 @@ public static void Error(object? thisOrContextObject, FormattableString formatta`
`237`	`232`	`{`
`238`	`233`	`DebugValidateArg(thisOrContextObject);`
`239`	`234`	`DebugValidateArg(formattableString);`
`240`		`- if (Log.IsEnabled()) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(formattableString));`
	`235`	`+ if (IsEnabled) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(formattableString));`
`241`	`236`	`}`
`242`	`237`
`243`	`238`	`/// <summary>Logs an error message.</summary>`
`@@ -249,7 +244,7 @@ public static void Error(object? thisOrContextObject, object message, [CallerMem`
`249`	`244`	`{`
`250`	`245`	`DebugValidateArg(thisOrContextObject);`
`251`	`246`	`DebugValidateArg(message);`
`252`		`- if (Log.IsEnabled()) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(message).ToString());`
	`247`	`+ if (IsEnabled) Log.ErrorMessage(IdOf(thisOrContextObject), memberName, Format(message).ToString());`
`253`	`248`	`}`
`254`	`249`
`255`	`250`	`[Event(ErrorEventId, Level = EventLevel.Error, Keywords = Keywords.Default)]`
`@@ -268,7 +263,7 @@ public static void Fail(object? thisOrContextObject, FormattableString formattab`
`268`	`263`	`// Don't call DebugValidateArg on args, as we expect Fail to be used in assert/failure situations`
`269`	`264`	`// that should never happen in production, and thus we don't care about extra costs.`
`270`	`265`
`271`		`- if (Log.IsEnabled()) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(formattableString));`
	`266`	`+ if (IsEnabled) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(formattableString));`
`272`	`267`	`Debug.Fail(Format(formattableString), $"{IdOf(thisOrContextObject)}.{memberName}");`
`273`	`268`	`}`
`274`	`269`
`@@ -282,7 +277,7 @@ public static void Fail(object? thisOrContextObject, object message, [CallerMemb`
`282`	`277`	`// Don't call DebugValidateArg on args, as we expect Fail to be used in assert/failure situations`
`283`	`278`	`// that should never happen in production, and thus we don't care about extra costs.`
`284`	`279`
`285`		`- if (Log.IsEnabled()) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(message).ToString());`
	`280`	`+ if (IsEnabled) Log.CriticalFailure(IdOf(thisOrContextObject), memberName, Format(message).ToString());`
`286`	`281`	`Debug.Fail(Format(message).ToString(), $"{IdOf(thisOrContextObject)}.{memberName}");`
`287`	`282`	`}`
`288`	`283`
`@@ -311,7 +306,7 @@ public static void DumpBuffer(object? thisOrContextObject, byte[] buffer, [Calle`
`311`	`306`	`[NonEvent]`
`312`	`307`	`public static void DumpBuffer(object? thisOrContextObject, byte[] buffer, int offset, int count, [CallerMemberName] string? memberName = null)`
`313`	`308`	`{`
`314`		`- if (Log.IsEnabled())`
	`309`	`+ if (IsEnabled)`
`315`	`310`	`{`
`316`	`311`	`if (offset < 0 \|\| offset > buffer.Length - count)`
`317`	`312`	`{`
`@@ -343,7 +338,7 @@ public static unsafe void DumpBuffer(object? thisOrContextObject, IntPtr bufferP`
`343`	`338`	`Debug.Assert(bufferPtr != IntPtr.Zero);`
`344`	`339`	`Debug.Assert(count >= 0);`
`345`	`340`
`346`		`- if (Log.IsEnabled())`
	`341`	`+ if (IsEnabled)`
`347`	`342`	`{`
`348`	`343`	`var buffer = new byte[Math.Min(count, MaxDumpSize)];`
`349`	`344`	`fixed (byte* targetPtr = buffer)`
`@@ -369,7 +364,7 @@ public static void Associate(object first, object second, [CallerMemberName] str`
`369`	`364`	`{`
`370`	`365`	`DebugValidateArg(first);`
`371`	`366`	`DebugValidateArg(second);`
`372`		`- if (Log.IsEnabled()) Log.Associate(IdOf(first), memberName, IdOf(first), IdOf(second));`
	`367`	`+ if (IsEnabled) Log.Associate(IdOf(first), memberName, IdOf(first), IdOf(second));`
`373`	`368`	`}`
`374`	`369`
`375`	`370`	`/// <summary>Logs a relationship between two objects.</summary>`
`@@ -383,7 +378,7 @@ public static void Associate(object? thisOrContextObject, object first, object s`
`383`	`378`	`DebugValidateArg(thisOrContextObject);`
`384`	`379`	`DebugValidateArg(first);`
`385`	`380`	`DebugValidateArg(second);`
`386`		`- if (Log.IsEnabled()) Log.Associate(IdOf(thisOrContextObject), memberName, IdOf(first), IdOf(second));`
	`381`	`+ if (IsEnabled) Log.Associate(IdOf(thisOrContextObject), memberName, IdOf(first), IdOf(second));`
`387`	`382`	`}`
`388`	`383`
`389`	`384`	`[Event(AssociateEventId, Level = EventLevel.Informational, Keywords = Keywords.Default, Message = "[{2}]<-->[{3}]")]`
`@@ -396,7 +391,7 @@ private void Associate(string thisOrContextObject, string? memberName, string fi`
`396`	`391`	`[Conditional("DEBUG_NETEVENTSOURCE_MISUSE")]`
`397`	`392`	`private static void DebugValidateArg(object? arg)`
`398`	`393`	`{`
`399`		`- if (!Log.IsEnabled())`
	`394`	`+ if (!IsEnabled)`
`400`	`395`	`{`
`401`	`396`	`Debug.Assert(!(arg is ValueType), $"Should not be passing value type {arg?.GetType()} to logging without IsEnabled check");`
`402`	`397`	`Debug.Assert(!(arg is FormattableString), $"Should not be formatting FormattableString \"{arg}\" if tracing isn't enabled");`
`@@ -406,9 +401,12 @@ private static void DebugValidateArg(object? arg)`
`406`	`401`	`[Conditional("DEBUG_NETEVENTSOURCE_MISUSE")]`
`407`	`402`	`private static void DebugValidateArg(FormattableString? arg)`
`408`	`403`	`{`
`409`		`- Debug.Assert(Log.IsEnabled() \|\| arg == null, $"Should not be formatting FormattableString \"{arg}\" if tracing isn't enabled");`
	`404`	`+ Debug.Assert(IsEnabled \|\| arg == null, $"Should not be formatting FormattableString \"{arg}\" if tracing isn't enabled");`
`410`	`405`	`}`
`411`	`406`
	`407`	`+ public static new bool IsEnabled =>`
	`408`	`+ Log.IsEnabled();`
	`409`	`+`
`412`	`410`	`[NonEvent]`
`413`	`411`	`public static string IdOf(object? value) => value != null ? value.GetType().Name + "#" + GetHashCode(value) : NullInstance;`
`414`	`412`
Original file line number	Diff line number	Diff line change
`@@ -51,21 +51,17 @@ internal sealed class MsQuicConnection : QuicConnectionProvider`
`51`	`51`	`// constructor for inbound connections`
`52`	`52`	`public MsQuicConnection(IPEndPoint localEndPoint, IPEndPoint remoteEndPoint, IntPtr nativeObjPtr)`
`53`	`53`	`{`
`54`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`55`	`54`	`_localEndPoint = localEndPoint;`
`56`	`55`	`_remoteEndPoint = remoteEndPoint;`
`57`	`56`	`_ptr = nativeObjPtr;`
`58`	`57`
`59`	`58`	`SetCallbackHandler();`
`60`	`59`	`SetIdleTimeout(TimeSpan.FromSeconds(120));`
`61`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`62`	`60`	`}`
`63`	`61`
`64`	`62`	`// constructor for outbound connections`
`65`	`63`	`public MsQuicConnection(QuicClientConnectionOptions options)`
`66`	`64`	`{`
`67`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`68`		`-`
`69`	`65`	`// TODO need to figure out if/how we want to expose sessions`
`70`	`66`	`// Creating a session per connection isn't ideal.`
`71`	`67`	`_session = new MsQuicSession();`
`@@ -74,8 +70,6 @@ public MsQuicConnection(QuicClientConnectionOptions options)`
`74`	`70`
`75`	`71`	`SetCallbackHandler();`
`76`	`72`	`SetIdleTimeout(options.IdleTimeout);`
`77`		`-`
`78`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`79`	`73`	`}`
`80`	`74`
`81`	`75`	`internal override IPEndPoint LocalEndPoint`
`@@ -168,8 +162,6 @@ internal uint HandleEvent(ref ConnectionEvent connectionEvent)`
`168`	`162`
`169`	`163`	`private uint HandleEventConnected(ConnectionEvent connectionEvent)`
`170`	`164`	`{`
`171`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`172`		`-`
`173`	`165`	`SOCKADDR_INET inetAddress = MsQuicParameterHelpers.GetINetParam(MsQuicApi.Api, _ptr, (uint)QUIC_PARAM_LEVEL.CONNECTION, (uint)QUIC_PARAM_CONN.LOCAL_ADDRESS);`
`174`	`166`	`_localEndPoint = MsQuicAddressHelpers.INetToIPEndPoint(inetAddress);`
`175`	`167`
`@@ -179,22 +171,18 @@ private uint HandleEventConnected(ConnectionEvent connectionEvent)`
`179`	`171`	`// handle event shutdown initiated by transport`
`180`	`172`	`_connectTcs.Complete(MsQuicStatusCodes.Success);`
`181`	`173`
`182`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`183`	`174`	`return MsQuicStatusCodes.Success;`
`184`	`175`	`}`
`185`	`176`
`186`	`177`	`private uint HandleEventShutdownInitiatedByTransport(ConnectionEvent connectionEvent)`
`187`	`178`	`{`
`188`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`189`		`-`
`190`	`179`	`if (!_connected)`
`191`	`180`	`{`
`192`	`181`	`_connectTcs.CompleteException(new IOException("Connection has been shutdown."));`
`193`	`182`	`}`
`194`	`183`
`195`	`184`	`_acceptQueue.Writer.Complete();`
`196`	`185`
`197`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`198`	`186`
`199`	`187`	`return MsQuicStatusCodes.Success;`
`200`	`188`	`}`
`@@ -208,23 +196,14 @@ private uint HandleEventShutdownInitiatedByPeer(ConnectionEvent connectionEvent)`
`208`	`196`
`209`	`197`	`private uint HandleEventShutdownComplete(ConnectionEvent connectionEvent)`
`210`	`198`	`{`
`211`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`212`		`-`
`213`	`199`	`_shutdownTcs.Complete(MsQuicStatusCodes.Success);`
`214`		`-`
`215`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`216`	`200`	`return MsQuicStatusCodes.Success;`
`217`	`201`	`}`
`218`	`202`
`219`	`203`	`private uint HandleEventNewStream(ConnectionEvent connectionEvent)`
`220`	`204`	`{`
`221`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`222`		`-`
`223`	`205`	`MsQuicStream msQuicStream = new MsQuicStream(this, connectionEvent.StreamFlags, connectionEvent.Data.NewStream.Stream, inbound: true);`
`224`		`-`
`225`	`206`	`_acceptQueue.Writer.TryWrite(msQuicStream);`
`226`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`227`		`-`
`228`	`207`	`return MsQuicStatusCodes.Success;`
`229`	`208`	`}`
`230`	`209`
`@@ -235,8 +214,6 @@ private uint HandleEventStreamsAvailable(ConnectionEvent connectionEvent)`
`235`	`214`
`236`	`215`	`internal override async ValueTask<QuicStreamProvider> AcceptStreamAsync(CancellationToken cancellationToken = default)`
`237`	`216`	`{`
`238`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`239`		`-`
`240`	`217`	`ThrowIfDisposed();`
`241`	`218`
`242`	`219`	`MsQuicStream stream;`
`@@ -254,7 +231,6 @@ internal override async ValueTask<QuicStreamProvider> AcceptStreamAsync(Cancella`
`254`	`231`	`};`
`255`	`232`	`}`
`256`	`233`
`257`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`258`	`234`	`return stream;`
`259`	`235`	`}`
`260`	`236`
`@@ -305,8 +281,6 @@ internal override ValueTask ConnectAsync(CancellationToken cancellationToken = d`
`305`	`281`	`private MsQuicStream StreamOpen(`
`306`	`282`	`QUIC_STREAM_OPEN_FLAG flags)`
`307`	`283`	`{`
`308`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`309`		`-`
`310`	`284`	`IntPtr streamPtr = IntPtr.Zero;`
`311`	`285`	`QuicExceptionHelpers.ThrowIfFailed(`
`312`	`286`	`MsQuicApi.Api.StreamOpenDelegate(`
`@@ -317,10 +291,7 @@ private MsQuicStream StreamOpen(`
`317`	`291`	`out streamPtr),`
`318`	`292`	`"Failed to open stream to peer.");`
`319`	`293`
`320`		`- MsQuicStream stream = new MsQuicStream(this, flags, streamPtr, inbound: false);`
`321`		`-`
`322`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`323`		`- return stream;`
	`294`	`+ return new MsQuicStream(this, flags, streamPtr, inbound: false);`
`324`	`295`	`}`
`325`	`296`
`326`	`297`	`private void SetCallbackHandler()`
`@@ -337,15 +308,12 @@ private ValueTask ShutdownAsync(`
`337`	`308`	`QUIC_CONNECTION_SHUTDOWN_FLAG Flags,`
`338`	`309`	`long ErrorCode)`
`339`	`310`	`{`
`340`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`341`		`-`
`342`	`311`	`uint status = MsQuicApi.Api.ConnectionShutdownDelegate(`
`343`	`312`	`_ptr,`
`344`	`313`	`(uint)Flags,`
`345`	`314`	`ErrorCode);`
`346`	`315`	`QuicExceptionHelpers.ThrowIfFailed(status, "Failed to shutdown connection.");`
`347`	`316`
`348`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`349`	`317`	`return _shutdownTcs.GetTypelessValueTask();`
`350`	`318`	`}`
`351`	`319`
`@@ -377,8 +345,6 @@ private void Dispose(bool disposing)`
`377`	`345`	`return;`
`378`	`346`	`}`
`379`	`347`
`380`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`381`		`-`
`382`	`348`	`if (_ptr != IntPtr.Zero)`
`383`	`349`	`{`
`384`	`350`	`MsQuicApi.Api.ConnectionCloseDelegate?.Invoke(_ptr);`
`@@ -394,8 +360,6 @@ private void Dispose(bool disposing)`
`394`	`360`	`}`
`395`	`361`
`396`	`362`	`_disposed = true;`
`397`		`-`
`398`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`399`	`363`	`}`
`400`	`364`
`401`	`365`	`internal override ValueTask CloseAsync(long errorCode, CancellationToken cancellationToken = default)`
Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,6 @@ internal override IPEndPoint ListenEndPoint`
`62`	`62`
`63`	`63`	`internal override async ValueTask<QuicConnectionProvider> AcceptConnectionAsync(CancellationToken cancellationToken = default)`
`64`	`64`	`{`
`65`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(this);`
`66`		`-`
`67`	`65`	`ThrowIfDisposed();`
`68`	`66`
`69`	`67`	`MsQuicConnection connection;`
`@@ -81,7 +79,6 @@ await connection.SetSecurityConfigForConnection(_sslOptions.ServerCertificate!,`
`81`	`79`	`_options.CertificateFilePath,`
`82`	`80`	`_options.PrivateKeyFilePath).ConfigureAwait(false);`
`83`	`81`
`84`		`- if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(this);`
`85`	`82`	`return connection;`
`86`	`83`	`}`
`87`	`84`