Chain coherent dependencies up through Extensions to EF Core packages (#8877)

* Chain coherent dependencies up through Extensions to EF Core packages
- should reduce incoherent PRs we get from `darc`
- react to AspNetCore-Tooling breaking changes
  - use C# Preview version in Blazor integration tests
    - update `EnsureOptions_ConfiguresDefaultParseOptions` test to match new C# version default
  - react to new newline encoding behavior; thanx @ajaybhargavb!
  - update product code and tests to use new GetItem API; thanx @NTaylorMullen!
    - RazorProjectFileSystem breaking change
    - update ref assemblies
- react to EF Core breaking changes
  - react to EF Core method rename
  - react to dotnet/efcore@ccfc5edbc7c8
  - react to dotnet/efcore@6cb41531df6d breaking change
    - disable new analyzer in `ScratchDatabaseFixture`
- skip `MvcTemplate_NoAuthImplAsync(...)` test for F#
  - #8996
- exclude some runtime assemblies from crossgen; thanx @BrennanConroy!
- add direct references to Mvc in AzureAD samples
  - unclear why the reference is no longer pulled in transitively

* Run `darc` to grab the latest
- CoreFx packages with version 4.6.0-preview4.19204.1 to ensure coherency
- core-setup packages with version 3.0.0-preview4-27604-05 to ensure coherency
- Extensions packages with verisn 3.0.0-preview4.19204.2 to ensure coherency
- EntityFrameworkCore packages with version 3.0.0-preview4.19204.7 from build 20190404.7
- AspNetCore-Tooling packages with version 3.0.0-preview4.19204.2 from build 20190404.2

Author: dougbu

eng/Version.Details.xml

@@ -8,6 +8,7 @@
   <ItemGroup>
     <Reference Include="Microsoft.AspNetCore.Authentication.AzureADB2C.UI" />
     <Reference Include="Microsoft.AspNetCore.HttpsPolicy" />
+    <Reference Include="Microsoft.AspNetCore.Mvc" />
     <Reference Include="Microsoft.AspNetCore.Server.IISIntegration" />
     <Reference Include="Microsoft.AspNetCore.Server.Kestrel" />
     <Reference Include="Microsoft.AspNetCore.StaticFiles" />

eng/Versions.props

@@ -12,6 +12,7 @@
   <ItemGroup>
     <Reference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" />
     <Reference Include="Microsoft.AspNetCore.HttpsPolicy" />
+    <Reference Include="Microsoft.AspNetCore.Mvc" />
     <Reference Include="Microsoft.AspNetCore.Server.IISIntegration" />
     <Reference Include="Microsoft.AspNetCore.Server.Kestrel" />
     <Reference Include="Microsoft.AspNetCore.StaticFiles" />

src/Azure/AzureAD/samples/AzureADB2CSample/AzureADB2CSample.csproj

@@ -490,10 +490,10 @@ public void Render_BindToElementFallback_SpecifiesValueAndChangeEvent_BodyConten
                 frame => AssertFrame.Element(frame, "div", 7, 0),
                 frame => AssertFrame.Attribute(frame, "value", "42", 1),
                 frame => AssertFrame.Attribute(frame, "onchange", typeof(EventCallback), 2),
-                frame => AssertFrame.Whitespace(frame, 3),
+                frame => AssertFrame.MarkupWhitespace(frame, 3),
                 frame => AssertFrame.Element(frame, "span", 2, 4),
                 frame => AssertFrame.Text(frame, "42", 5),
-                frame => AssertFrame.Whitespace(frame, 6));
+                frame => AssertFrame.MarkupWhitespace(frame, 6));
         }
 
         [Fact]

src/Azure/AzureAD/samples/AzureADSample/AzureADSample.csproj

@@ -132,10 +132,10 @@ public void Render_BodyChildContent_Generic()
                 frame => AssertFrame.Component(frame, "Test.RenderChildContentString", 3, 0),
                 frame => AssertFrame.Attribute(frame, "Value", "HI", 1),
                 frame => AssertFrame.Attribute(frame, RenderTreeBuilder.ChildContent, 2),
-                frame => AssertFrame.Whitespace(frame, 3),
+                frame => AssertFrame.MarkupWhitespace(frame, 3),
                 frame => AssertFrame.Element(frame, "div", 2, 4),
                 frame => AssertFrame.Text(frame, "hi", 5),
-                frame => AssertFrame.Whitespace(frame, 6));
+                frame => AssertFrame.MarkupWhitespace(frame, 6));
         }
 
         [Fact]
@@ -184,10 +184,10 @@ public void Render_BodyChildContent_Recursive()
                 frames,
                 frame => AssertFrame.Component(frame, "Test.RenderChildContent", 2, 0),
                 frame => AssertFrame.Attribute(frame, RenderTreeBuilder.ChildContent, 1),
-                frame => AssertFrame.Whitespace(frame, 2),
+                frame => AssertFrame.MarkupWhitespace(frame, 2),
                 frame => AssertFrame.Component(frame, "Test.RenderChildContent", 2, 3),
                 frame => AssertFrame.Attribute(frame, RenderTreeBuilder.ChildContent, 4),
-                frame => AssertFrame.Whitespace(frame, 6),
+                frame => AssertFrame.MarkupWhitespace(frame, 6),
                 frame => AssertFrame.Markup(frame, "\n    <div></div>\n  ", 5));
         }
 

src/Components/Blazor/Build/test/BindRazorIntegrationTest.cs

@@ -535,24 +535,24 @@ public class MyComponent : ComponentBase
             Assert.Collection(
                 frames,
                 frame => AssertFrame.Element(frame, "html", 9, 0),
-                frame => AssertFrame.Whitespace(frame, 1),
+                frame => AssertFrame.MarkupWhitespace(frame, 1),
                 frame => AssertFrame.Markup(frame, "<head><meta><meta></head>\n  ", 2),
                 frame => AssertFrame.Element(frame, "body", 5, 3),
-                frame => AssertFrame.Whitespace(frame, 4),
+                frame => AssertFrame.MarkupWhitespace(frame, 4),
                 frame => AssertFrame.Component(frame, "Test.MyComponent", 2, 5),
                 frame => AssertFrame.Attribute(frame, RenderTreeBuilder.ChildContent, 6),
-                frame => AssertFrame.Whitespace(frame, 16),
-                frame => AssertFrame.Whitespace(frame, 17));
+                frame => AssertFrame.MarkupWhitespace(frame, 16),
+                frame => AssertFrame.MarkupWhitespace(frame, 17));
 
             // Assert: Captured ChildContent frames are correct
             var childFrames = GetFrames((RenderFragment)frames[6].AttributeValue);
             Assert.Collection(
                 childFrames,
-                frame => AssertFrame.Whitespace(frame, 7),
+                frame => AssertFrame.MarkupWhitespace(frame, 7),
                 frame => AssertFrame.Markup(frame, "<div><span></span><span></span></div>\n      ", 8),
                 frame => AssertFrame.Element(frame, "div", 2, 9),
                 frame => AssertFrame.Text(frame, "hi", 10),
-                frame => AssertFrame.Whitespace(frame, 11),
+                frame => AssertFrame.MarkupWhitespace(frame, 11),
                 frame => AssertFrame.Markup(frame, "<div><span></span><span></span></div>\n      <div></div>\n      ", 12),
                 frame => AssertFrame.Element(frame, "div", 2, 13),
                 frame => AssertFrame.Text(frame, "hi", 14),

src/Components/Blazor/Build/test/ChildContentRazorIntegrationTest.cs

@@ -171,14 +171,14 @@ public void Render_GenericComponent_WithChildContent()
                 frame => AssertFrame.Component(frame, genericComponentType.FullName, 3, 0),
                 frame => AssertFrame.Attribute(frame, "Items", typeof(List<int>), 1),
                 frame => AssertFrame.Attribute(frame, RenderTreeBuilder.ChildContent, 2),
-                frame => AssertFrame.Whitespace(frame, 3),
+                frame => AssertFrame.MarkupWhitespace(frame, 3),
                 frame => AssertFrame.Element(frame, "div", 2, 4),
                 frame => AssertFrame.Text(frame, "0", 5),
-                frame => AssertFrame.Whitespace(frame, 6),
-                frame => AssertFrame.Whitespace(frame, 3),
+                frame => AssertFrame.MarkupWhitespace(frame, 6),
+                frame => AssertFrame.MarkupWhitespace(frame, 3),
                 frame => AssertFrame.Element(frame, "div", 2, 4),
                 frame => AssertFrame.Text(frame, "2", 5),
-                frame => AssertFrame.Whitespace(frame, 6));
+                frame => AssertFrame.MarkupWhitespace(frame, 6));
         }
 
         [Fact]

src/Components/Blazor/Build/test/ComponentRenderingRazorIntegrationTest.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -19,8 +19,17 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             return directory?.EnumerateItems() ?? Enumerable.Empty<RazorProjectItem>();
         }
 
+        [Obsolete("Use GetItem(string path, string fileKind)] instead")]
         public override RazorProjectItem GetItem(string path)
         {
+            return GetItem(path, fileKind: null);
+        }
+
+        public override RazorProjectItem GetItem(string path, string fileKind)
+        {
+            // We ignore fileKind here because the _root is pre-filled with project items that already have fileKinds defined. This is
+            // a unique circumstance where the RazorProjectFileSystem is actually pre-filled with all of its project items on construction.
+
             path = NormalizeAndEnsureValidPath(path);
             return _root.GetItem(path) ?? new NotFoundProjectItem(string.Empty, path);
         }
@@ -212,4 +221,4 @@ public FileNode(string path, RazorProjectItem projectItem)
             public RazorProjectItem ProjectItem { get; }
         }
     }
-}
+}

src/Components/Blazor/Build/test/GenericComponentRazorIntegrationTest.cs

@@ -60,7 +60,7 @@ static RazorIntegrationTestBase()
                 referenceAssemblies,
                 new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary));
 
-            CSharpParseOptions = new CSharpParseOptions(LanguageVersion.CSharp7_3);
+            CSharpParseOptions = new CSharpParseOptions(LanguageVersion.Preview);
         }
 
         public RazorIntegrationTestBase(ITestOutputHelper output)