Skip to content

Commit 17b6ce8

Browse files
author
John Luo
committed
Merge branch 'release/2.2'
2 parents f43a353 + 38c0d5a commit 17b6ce8

File tree

16 files changed

+462
-590
lines changed

16 files changed

+462
-590
lines changed

build/AzureIntegration.targets

Lines changed: 0 additions & 31 deletions
This file was deleted.

build/SharedFx.targets

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,28 @@
4444

4545
</Target>
4646

47+
<Target Name="BuildSiteExtension" DependsOnTargets="BuildMetapackages" Condition="'$(BuildSiteExtension)' == 'true'" >
48+
<PropertyGroup>
49+
<AzureIntegrationProjProperties>
50+
AspNetUniverseBuildOffline=true;
51+
DotNetRestoreSourcePropsPath=$(GeneratedRestoreSourcesPropsPath);
52+
DotNetPackageVersionPropsPath=$(GeneratedPackageVersionPropsPath);
53+
BuildNumber=$(BuildNumber);
54+
Configuration=$(Configuration);
55+
IsFinalBuild=$(IsFinalBuild);
56+
</AzureIntegrationProjProperties>
57+
</PropertyGroup>
58+
59+
<!-- Pack logging site extension -->
60+
<MSBuild Projects="$(RepositoryRoot)\src\SiteExtensions\LoggingBranch\LoggingBranch.csproj" Targets="Restore;Pack" Properties="$(AzureIntegrationProjProperties);PackageOutputPath=$(BuildDir)" />
61+
</Target>
62+
63+
<Target Name="GetSiteExtensionArtifactInfo" Condition="'$(BuildSiteExtension)' == 'true'" >
64+
<MSBuild Projects="$(RepositoryRoot)\src\SiteExtensions\LoggingBranch\LoggingBranch.csproj" Targets="GetArtifactInfo" Properties="PackageOutputPath=$(BuildDir);BuildNumber=$(BuildNumber);DesignTimeBuild=true;IsFinalBuild=$(IsFinalBuild)">
65+
<Output TaskParameter="TargetOutputs" ItemName="ArtifactInfo" />
66+
</MSBuild>
67+
</Target>
68+
4769
<Target Name="_BuildSharedFxProjects" DependsOnTargets="GeneratePropsFiles;ResolveCommitHash">
4870

4971
<PropertyGroup>

build/artifacts.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ This can be done once #4246 is complete, and done in conjunction with converting
2828
<PackageArtifact Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" Category="ship" />
2929
<PackageArtifact Include="Microsoft.AspNetCore.Authentication.Twitter" Category="ship" />
3030
<PackageArtifact Include="Microsoft.AspNetCore.Authentication.WsFederation" Category="ship" />
31+
<PackageArtifact Include="Microsoft.AspNetCore.AzureAppServices.SiteExtension.3.0" Category="noship" Condition="'$(BuildSiteExtension)' == 'true'" />
3132
<PackageArtifact Include="Microsoft.AspNetCore.AzureAppServices.HostingStartup" Category="ship" />
3233
<PackageArtifact Include="Microsoft.AspNetCore.AzureAppServicesIntegration" Category="ship" />
3334
<PackageArtifact Include="Microsoft.AspNetCore.Blazor" Category="ship" />

build/repo.props

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
<DisableSignCheckStrongName>true</DisableSignCheckStrongName>
2626

2727
<SharedSourcesFolder>$(RepositoryRoot)src\Shared\</SharedSourcesFolder>
28+
<SharedFxArchitecture Condition="'$(SharedFxArchitecture)' == ''">$(SharedFxRid.Substring($([MSBuild]::Add($(SharedFxRid.LastIndexOf('-')), 1))))</SharedFxArchitecture>
29+
<BuildSiteExtension>false</BuildSiteExtension>
30+
<BuildSiteExtension Condition="'$(BuildSiteExtension)' == 'true' AND '$(OS)' != 'Windows_NT'">false</BuildSiteExtension>
2831
</PropertyGroup>
2932

3033
<PropertyGroup Condition=" '$(BuildAllProjects)' == 'true' ">

build/repo.targets

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<Project>
22
<Import Project="RepositoryBuild.targets" />
3-
<Import Project="AzureIntegration.targets" />
43
<Import Project="SharedFx.targets" />
54
<Import Project="CodeSign.targets" />
65
<Import Project="Publish.targets" />
@@ -36,7 +35,7 @@
3635
<CompileDependsOn Condition=" '$(BuildAllProjects)' == 'true' ">$(CompileDependsOn);PackProjects;BuildRepositories;BuildSharedFx</CompileDependsOn>
3736

3837
<PackageDependsOn>$(PackageDependsOn);PackProjects</PackageDependsOn>
39-
<PackageDependsOn Condition=" '$(BuildAllProjects)' == 'true' ">$(PackageDependsOn);RemoveSharedFrameworkOnlyRefsFromNuspec</PackageDependsOn>
38+
<PackageDependsOn Condition=" '$(BuildAllProjects)' == 'true' ">$(PackageDependsOn);BuildSiteExtension;RemoveSharedFrameworkOnlyRefsFromNuspec</PackageDependsOn>
4039

4140
<TestDependsOn />
4241
<TestDependsOn Condition=" '$(_RunBuild)' == 'true' ">$(TestDependsOn);Compile</TestDependsOn>
@@ -93,7 +92,7 @@
9392
</ItemGroup>
9493
</Target>
9594

96-
<Target Name="ResolveRepoInfo" DependsOnTargets="_ResolveProjectArtifactsInfoShipped;_PrepareRepositories">
95+
<Target Name="ResolveRepoInfo" DependsOnTargets="_ResolveProjectArtifactsInfoShipped;_PrepareRepositories;GetSiteExtensionArtifactInfo">
9796
<!-- We need to pass the NETCoreApp package versions to msbuild so that it doesn't complain about us using a different one than it was restored against. -->
9897
<PropertyGroup>
9998
<DesignTimeBuildProps>$(BuildProperties);MicrosoftNETCoreAppPackageVersion=$(MicrosoftNETCoreAppPackageVersion);</DesignTimeBuildProps>

eng/PatchConfig.props

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ Later on, this will be checked using this condition:
1919
</PropertyGroup>
2020
<PropertyGroup Condition=" '$(VersionPrefix)' == '2.2.2' ">
2121
<PackagesInPatch>
22+
@aspnet/signalr;
23+
Microsoft.AspNetCore.Authentication.Google;
24+
Microsoft.AspNetCore.Http;
2225
</PackagesInPatch>
2326
</PropertyGroup>
2427

eng/scripts/CodeCheck.ps1

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ finally {
9090
Write-Host ""
9191

9292
foreach ($err in $errors) {
93-
9493
Write-Host -f Red "error : $err"
9594
}
9695

0 commit comments

Comments
 (0)