Merged PR 40657: Fix exit AcceptLoop in Http.Sys (#57319)

If an exception occurs during request processing we weren't exiting the accept loop which resulted in duplicating the accept loop.

Co-authored-by: Brennan Conroy <brecon@microsoft.com>

Author: wtgodbe

src/Servers/HttpSys/src/MessagePump.cs

@@ -279,29 +279,38 @@ private async Task ExecuteAsync()
                     continue;
                 }
 
-                try
+                if (_preferInlineScheduling)
                 {
-                    if (_preferInlineScheduling)
+                    try
                     {
                         await requestContext.ExecuteAsync();
                     }
-                    else
+                    catch (Exception ex)
+                    {
+                        // Request processing failed
+                        // Log the error message, release throttle and move on
+                        Log.RequestListenerProcessError(_messagePump._logger, ex);
+                    }
+                }
+                else
+                {
+                    try
                     {
                         // Queue another accept before we execute the request
                         ThreadPool.UnsafeQueueUserWorkItem(this, preferLocal: false);
 
                         // Use this thread to start the execution of the request (avoid the double threadpool dispatch)
                         await requestContext.ExecuteAsync();
-
-                        // We're done with this thread
-                        return;
                     }
-                }
-                catch (Exception ex)
-                {
-                    // Request processing failed
-                    // Log the error message, release throttle and move on
-                    Log.RequestListenerProcessError(_messagePump._logger, ex);
+                    catch (Exception ex)
+                    {
+                        // Request processing failed
+                        // Log the error message, release throttle and move on
+                        Log.RequestListenerProcessError(_messagePump._logger, ex);
+                    }
+
+                    // We're done with this thread, accept loop was continued via ThreadPool.UnsafeQueueUserWorkItem
+                    return;
                 }
             }