Skip to content

Commit 0fd7ef1

Browse files
Resolve potential XSS concerns from scanners in SignalR (#57180)
1 parent b4558f7 commit 0fd7ef1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ private async Task ProcessNegotiate(HttpContext context, HttpConnectionDispatche
344344
var queryStringVersionValue = queryStringVersion.ToString();
345345
if (!int.TryParse(queryStringVersionValue, out clientProtocolVersion))
346346
{
347-
error = $"The client requested an invalid protocol version '{queryStringVersionValue}'";
347+
error = $"The client requested a non-integer protocol version.";
348348
Log.InvalidNegotiateProtocolVersion(_logger, queryStringVersionValue);
349349
}
350350
else if (clientProtocolVersion < options.MinimumProtocolVersion)

src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public async Task InvalidNegotiateProtocolVersionThrows()
159159
var negotiateResponse = JsonConvert.DeserializeObject<JObject>(Encoding.UTF8.GetString(ms.ToArray()));
160160

161161
var error = negotiateResponse.Value<string>("error");
162-
Assert.Equal("The client requested an invalid protocol version 'Invalid'", error);
162+
Assert.Equal("The client requested a non-integer protocol version.", error);
163163

164164
var connectionId = negotiateResponse.Value<string>("connectionId");
165165
Assert.Null(connectionId);

0 commit comments

Comments
 (0)