From 402553f79c09d22f6ebcb793e0c9a76af1f40abb Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 6 May 2025 13:25:55 -0700 Subject: [PATCH 01/11] Switch to Central Package Management --- src/Directory.Packages.props | 55 +++++++++++++++++++ ...waysEncrypted.AzureKeyVaultProvider.csproj | 14 ++--- .../ref/Microsoft.Data.SqlClient.csproj | 24 ++++---- .../src/Microsoft.Data.SqlClient.csproj | 33 +++++------ .../netfx/ref/Microsoft.Data.SqlClient.csproj | 29 +++++----- .../netfx/src/Microsoft.Data.SqlClient.csproj | 23 ++++---- .../src/Microsoft.Data.SqlClient.csproj | 34 ++++++------ .../tests/Directory.Build.props | 4 +- .../Microsoft.Data.SqlClient.Tests.csproj | 43 +++++++-------- ....Data.SqlClient.ManualTesting.Tests.csproj | 43 ++++++++------- ...oft.Data.SqlClient.PerformanceTests.csproj | 7 +-- ...crosoft.Data.SqlClient.ExtUtilities.csproj | 4 +- ...rosoft.Data.SqlClient.TestUtilities.csproj | 6 +- .../Microsoft.SqlServer.Server.csproj | 4 +- tools/Directory.Packages.props | 18 ++++++ .../Microsoft.Cci.Extensions.csproj | 14 ++--- .../Microsoft.DotNet.GenAPI.csproj | 8 +-- tools/props/Versions.props | 55 +------------------ tools/targets/TrimDocsForIntelliSense.targets | 9 +-- 19 files changed, 217 insertions(+), 210 deletions(-) create mode 100644 src/Directory.Packages.props create mode 100644 tools/Directory.Packages.props diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props new file mode 100644 index 0000000000..bfd090fc59 --- /dev/null +++ b/src/Directory.Packages.props @@ -0,0 +1,55 @@ + + + true + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj b/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj index 294a5c02b2..8687566695 100644 --- a/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj +++ b/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj @@ -16,7 +16,7 @@ MIT true - + true $(SigningKeyPath) @@ -30,16 +30,16 @@ - + - - - - + + + + - + \ No newline at end of file diff --git a/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj index b587305bb5..057a75713d 100644 --- a/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj @@ -10,8 +10,8 @@ netcoreapp AnyCPU;x64;x86 - - + + true $(SigningKeyPath) $(SigningKeyPath) @@ -19,7 +19,6 @@ $(SigningKeyPath) - @@ -27,16 +26,15 @@ - - - - - - - - - + + + + + + + + + - diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj index f1c5c2d6e6..8c740bac71 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj @@ -17,7 +17,7 @@ true Core $(BaseProduct) true - $(NoWarn);IL2026;IL2057;IL2072;IL2075 + $(NoWarn);IL2026;IL2057;IL2072;IL2075 @@ -35,7 +35,7 @@ - + @@ -178,7 +178,7 @@ Microsoft\Data\SqlClient\AlwaysEncryptedKeyConverter.cs - + Microsoft\Data\SqlClient\ApplicationIntent.cs @@ -535,7 +535,7 @@ Microsoft\Data\SqlClient\SqlDbColumn.cs - + Microsoft\Data\SqlClient\SqlDelegatedTransaction.cs @@ -725,7 +725,6 @@ System\Diagnostics\CodeAnalysis.cs - @@ -760,7 +759,6 @@ - @@ -901,13 +899,11 @@ Microsoft\Data\SqlTypes\SqlFileStream.Windows.cs - - @@ -928,7 +924,6 @@ Microsoft\Data\SqlTypes\SqlFileStream.netcore.Unix.cs - @@ -937,7 +932,6 @@ - @@ -964,20 +958,19 @@ Microsoft.Data.SqlClient.SqlMetaData.xml - - - + + - - - - - - - + + + + + + + diff --git a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj index 77c7d66903..9f0e6041c0 100644 --- a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj @@ -2,13 +2,14 @@ false net462 - $(ObjFolder)$(Configuration)\$(AssemblyName)\ref\ + $(ObjFolder)$(Configuration)\$(AssemblyName)\ref\ $(BinFolder)$(Configuration)\$(AssemblyName)\ref\ $(OutputPath)\Microsoft.Data.SqlClient.xml Framework $(BaseProduct) - Debug;Release; + Debug;Release - + true $(SigningKeyPath) @@ -32,22 +33,20 @@ - - + + - $(MicrosoftDataSqlClientSniVersion) All runtime; build; native; contentfiles; analyzers; buildtransitive - - - - - - - - + + + + + + + + - diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj index 8b8bda848e..1e0f84dd49 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj @@ -369,7 +369,7 @@ Microsoft\Data\Sql\SqlDataSourceEnumerator.cs - + Microsoft\Data\SqlClient\AAsyncCallContext.cs @@ -704,7 +704,7 @@ Microsoft\Data\SqlClient\SqlDbColumn.cs - + Microsoft\Data\SqlClient\SqlDelegatedTransaction.cs @@ -962,20 +962,19 @@ - - + + - $(MicrosoftDataSqlClientSniVersion) All runtime; build; native; contentfiles; analyzers; buildtransitive - - - - - - - + + + + + + + diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj index 70f6b3ff2c..f18f9003cd 100644 --- a/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj @@ -1,20 +1,20 @@  - - net462;net8.0;net9.0 - true - - - + + net462;net8.0;net9.0 + true + + + - - - - - - - - - - + + - + + + + + + + + + \ No newline at end of file diff --git a/src/Microsoft.Data.SqlClient/tests/Directory.Build.props b/src/Microsoft.Data.SqlClient/tests/Directory.Build.props index e0916258e1..4f982d4ed9 100644 --- a/src/Microsoft.Data.SqlClient/tests/Directory.Build.props +++ b/src/Microsoft.Data.SqlClient/tests/Directory.Build.props @@ -1,5 +1,5 @@ - @@ -13,7 +13,7 @@ AnyCPU;x86;x64 Project - + false diff --git a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj index 646535116d..f562b361cd 100644 --- a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj @@ -76,35 +76,37 @@ - + + + runtime; build; native; contentfiles; analyzers; buildtransitive all - - - + runtime; build; native; contentfiles; analyzers; buildtransitive all - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - - - - - - - - - - + + + + + + + - + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + @@ -135,9 +137,6 @@ %(Filename)%(Extension) - - - PreserveNewest diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj index 5dfad69698..33dca536ee 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj @@ -321,47 +321,48 @@ - - - - + + runtime; build; native; contentfiles; analyzers; buildtransitive all - + runtime; build; native; contentfiles; analyzers; buildtransitive all - - runtime; build; native; contentfiles; analyzers; buildtransitive - all - - + - + - - - - - - - - + + + + + + + - - + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + PreserveNewest %(Filename)%(Extension) + + + PreserveNewest diff --git a/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj b/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj index cc06945c54..24bcaab242 100644 --- a/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj @@ -8,24 +8,19 @@ $(BinFolder)$(Configuration).$(Platform).$(AssemblyName) Microsoft.Data.SqlClient.PerformanceTests.Program - - - - - + - diff --git a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj index 710ddef2ef..a307ece5c9 100644 --- a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj +++ b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj @@ -4,8 +4,8 @@ Microsoft.Data.SqlClient.ExtUtilities.Runner - - + + diff --git a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj index f30ea24019..58fcfe942e 100644 --- a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj +++ b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj @@ -15,8 +15,8 @@ PreserveNewest - - - + + + diff --git a/src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj b/src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj index 2808094a25..48d163cab6 100644 --- a/src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj +++ b/src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj @@ -16,11 +16,11 @@ - + - + diff --git a/tools/Directory.Packages.props b/tools/Directory.Packages.props new file mode 100644 index 0000000000..e0f9ef7b88 --- /dev/null +++ b/tools/Directory.Packages.props @@ -0,0 +1,18 @@ + + + true + + + + + + + + + + + + + + + diff --git a/tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj b/tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj index 299e6c19ab..3c8676acac 100644 --- a/tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj +++ b/tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj @@ -16,13 +16,13 @@ - - - - - - - + + + + + + + diff --git a/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj b/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj index ae6c238182..1ee92e1808 100644 --- a/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj +++ b/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj @@ -12,10 +12,10 @@ - - - - + + + + diff --git a/tools/props/Versions.props b/tools/props/Versions.props index d4e2619f3b..4031ecde50 100644 --- a/tools/props/Versions.props +++ b/tools/props/Versions.props @@ -1,5 +1,6 @@ - + 6.1.0 0 @@ -21,58 +22,6 @@ 1.0.0-dev $(SqlServerPackageVersion) - - - 6.0.2 - 4.5.1 - 4.5.5 - 8.0.0 - 8.0.5 - 4.3.0 - - - - 1.13.2 - 8.0.0 - 8.0.1 - 7.7.1 - 7.7.1 - 4.3.0 - 8.0.1 - - - - 6.0.2 - 8.0.1 - 1.0.0 - - - - [1.44.1,2.0.0) - [4.7.0,5.0.0) - - - - 0.14.0 - 3.1.6 - 10.0.0-beta.25164.6 - 10.0.0-beta.25164.6 - 8.0.1 - 1.0.3 - 17.11.1 - 172.52.0 - 10.50.1600.1 - 160.1000.6 - 5.0.0 - 13.0.3 - 8.0.1 - 4.3.0 - 5.0.0 - 8.0.1 - 6.0.0 - 2.9.2 - 2.8.2 - $(NugetPackageVersion) $(NugetPackageVersion) diff --git a/tools/targets/TrimDocsForIntelliSense.targets b/tools/targets/TrimDocsForIntelliSense.targets index c178379dba..05feb26739 100644 --- a/tools/targets/TrimDocsForIntelliSense.targets +++ b/tools/targets/TrimDocsForIntelliSense.targets @@ -1,8 +1,9 @@ - - - + + + + - \ No newline at end of file + From 08fd276baf033f2f79cb56654cd2269aceb0d1c3 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 6 May 2025 17:27:48 -0700 Subject: [PATCH 02/11] Additional changes --- src/Directory.Packages.props | 5 ++++- .../Microsoft.Data.SqlClient.DockerLinuxTest.csproj | 2 +- .../Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index bfd090fc59..3d4201dda5 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -42,7 +42,9 @@ - + + + @@ -51,5 +53,6 @@ + diff --git a/src/Microsoft.Data.SqlClient/tests/Docker/DockerLinuxTest/Microsoft.Data.SqlClient.DockerLinuxTest.csproj b/src/Microsoft.Data.SqlClient/tests/Docker/DockerLinuxTest/Microsoft.Data.SqlClient.DockerLinuxTest.csproj index bd320959f7..9232bf78af 100644 --- a/src/Microsoft.Data.SqlClient/tests/Docker/DockerLinuxTest/Microsoft.Data.SqlClient.DockerLinuxTest.csproj +++ b/src/Microsoft.Data.SqlClient/tests/Docker/DockerLinuxTest/Microsoft.Data.SqlClient.DockerLinuxTest.csproj @@ -7,7 +7,7 @@ Unix - + diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj index 33dca536ee..9af314d239 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj @@ -320,7 +320,6 @@ - From 26b84ecd3c0855de8dd0ae920e59e35c5fabb5eb Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 6 May 2025 17:31:29 -0700 Subject: [PATCH 03/11] EOF --- ....Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj | 2 +- .../src/Microsoft.Data.SqlClient.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj b/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj index 8687566695..2dec655333 100644 --- a/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj +++ b/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj index f18f9003cd..a65ba42f05 100644 --- a/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj @@ -17,4 +17,4 @@ - \ No newline at end of file + From b1362643116af7742308b83b619856a0712fb778 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 6 May 2025 18:18:38 -0700 Subject: [PATCH 04/11] Handle NU1009 --- src/Directory.Packages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 3d4201dda5..915c4b72dc 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -39,7 +39,7 @@ - + From 89522cddc2c7c7fbb6c72b83fcd74e50e146b78e Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Wed, 7 May 2025 08:46:42 -0700 Subject: [PATCH 05/11] Enable pinning, fix version --- src/Directory.Packages.props | 4 ++-- .../Microsoft.Data.SqlClient.TestUtilities.csproj | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 915c4b72dc..59c78dc5dd 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -1,6 +1,7 @@ true + true @@ -42,8 +43,7 @@ - - + diff --git a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj index 58fcfe942e..fae6697a63 100644 --- a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj +++ b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj @@ -4,7 +4,6 @@ netcoreapp win win-$(Platform) - $(ObjFolder)$(Configuration).$(Platform)\$(AssemblyName) $(BinFolder)$(Configuration).$(Platform)\$(AssemblyName) From 3959e6fc881e5b432c1ab0c3844127ab55d69a8b Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Wed, 7 May 2025 08:49:53 -0700 Subject: [PATCH 06/11] Disable implicit framework reference. --- src/Directory.Packages.props | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 59c78dc5dd..8357956af4 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -2,6 +2,7 @@ true true + true From 9c6419360123e3d572406f81c98a68b85d5e4218 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Wed, 7 May 2025 08:51:43 -0700 Subject: [PATCH 07/11] Fix line break --- .../netfx/ref/Microsoft.Data.SqlClient.csproj | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj index 9f0e6041c0..8a52093f11 100644 --- a/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj @@ -8,8 +8,7 @@ Framework $(BaseProduct) Debug;Release - + true $(SigningKeyPath) From 580323ecd9ce4019a28644b29186fff8c0870e71 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Wed, 7 May 2025 09:02:56 -0700 Subject: [PATCH 08/11] Ref fx assemblies --- src/Directory.Packages.props | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 8357956af4..45e063fb5a 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -2,6 +2,7 @@ true true + true @@ -41,7 +42,6 @@ - @@ -56,4 +56,8 @@ + + + + From 49e12984d2ea941259d4c9ca8d0f4838595d6a56 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Wed, 7 May 2025 15:52:55 -0700 Subject: [PATCH 09/11] try again --- src/Directory.Packages.props | 8 +------- .../tests/Directory.Packages.props | 7 +++++++ 2 files changed, 8 insertions(+), 7 deletions(-) create mode 100644 src/Microsoft.Data.SqlClient/tests/Directory.Packages.props diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 45e063fb5a..ab4d3fca3c 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -2,8 +2,6 @@ true true - - true @@ -26,8 +24,8 @@ - + @@ -56,8 +54,4 @@ - - - - diff --git a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props new file mode 100644 index 0000000000..799fb29cf0 --- /dev/null +++ b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props @@ -0,0 +1,7 @@ + + + + + + + From f9f0172d430fdd8d5117da1b0a34f3c25589d53b Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Wed, 7 May 2025 16:02:33 -0700 Subject: [PATCH 10/11] Fix source --- src/Microsoft.Data.SqlClient/tests/Directory.Packages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props index 799fb29cf0..1fe861a4fe 100644 --- a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props +++ b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props @@ -1,5 +1,5 @@ - + From 58e91c8391254a094c33dd6ace8d5822ef08d95d Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Thu, 8 May 2025 14:37:06 -0700 Subject: [PATCH 11/11] Fix package version for MDS test package --- ...a.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj | 2 +- .../add-ons/Directory.Packages.props | 6 ++++++ .../CustomRetryLogicProvider.csproj | 2 +- src/Microsoft.Data.SqlClient/tests/Directory.Packages.props | 3 +++ .../FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj | 2 +- .../ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj | 2 +- .../tests/ManualTests/SQL/UdtTest/UDTs/Circle/Circle.csproj | 4 ++-- .../tests/ManualTests/SQL/UdtTest/UDTs/Shapes/Shapes.csproj | 4 ++-- .../SQL/UdtTest/UDTs/Utf8String/Utf8String.csproj | 4 ++-- 9 files changed, 19 insertions(+), 10 deletions(-) create mode 100644 src/Microsoft.Data.SqlClient/add-ons/Directory.Packages.props diff --git a/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj b/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj index 2dec655333..d1e076cde9 100644 --- a/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj +++ b/src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj @@ -34,7 +34,7 @@ - + diff --git a/src/Microsoft.Data.SqlClient/add-ons/Directory.Packages.props b/src/Microsoft.Data.SqlClient/add-ons/Directory.Packages.props new file mode 100644 index 0000000000..772f188a2e --- /dev/null +++ b/src/Microsoft.Data.SqlClient/add-ons/Directory.Packages.props @@ -0,0 +1,6 @@ + + + + + + diff --git a/src/Microsoft.Data.SqlClient/tests/CustomConfigurableRetryLogic/CustomRetryLogicProvider.csproj b/src/Microsoft.Data.SqlClient/tests/CustomConfigurableRetryLogic/CustomRetryLogicProvider.csproj index 8a076d1e52..1b35e8f80d 100644 --- a/src/Microsoft.Data.SqlClient/tests/CustomConfigurableRetryLogic/CustomRetryLogicProvider.csproj +++ b/src/Microsoft.Data.SqlClient/tests/CustomConfigurableRetryLogic/CustomRetryLogicProvider.csproj @@ -13,6 +13,6 @@ - + diff --git a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props index 1fe861a4fe..08b7533621 100644 --- a/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props +++ b/src/Microsoft.Data.SqlClient/tests/Directory.Packages.props @@ -4,4 +4,7 @@ + + + diff --git a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj index f562b361cd..2ade02d82b 100644 --- a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj @@ -129,7 +129,7 @@ - + diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj index 941b08588c..d1487d9012 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj @@ -12,6 +12,6 @@ - + diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Circle/Circle.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Circle/Circle.csproj index 93137d1883..8e1719e8d3 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Circle/Circle.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Circle/Circle.csproj @@ -3,7 +3,7 @@ Circle Circle {6C88F00F-9597-43AD-9E5F-9B344DA3B16F} - netfx + netfx netcoreapp $(ObjFolder)$(Configuration).$(Platform)\$(AssemblyName) $(BinFolder)$(Configuration).$(Platform)\$(AssemblyName) @@ -12,6 +12,6 @@ - + diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Shapes/Shapes.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Shapes/Shapes.csproj index 596f7ffe74..ccd0d626d9 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Shapes/Shapes.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Shapes/Shapes.csproj @@ -5,13 +5,13 @@ {B73A7063-37C3-415D-AD53-BB3DA20ABD6E} netfx netcoreapp - $(ObjFolder)$(Configuration).$(Platform)\$(AssemblyName) + $(ObjFolder)$(Configuration).$(Platform)\$(AssemblyName) $(BinFolder)$(Configuration).$(Platform)\$(AssemblyName) - + diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Utf8String/Utf8String.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Utf8String/Utf8String.csproj index ec1229e0e7..1a7717e844 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Utf8String/Utf8String.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Utf8String/Utf8String.csproj @@ -5,13 +5,13 @@ {E0A6BB21-574B-43D9-890D-6E1144F2EE9E} netfx netcoreapp - $(ObjFolder)$(Configuration).$(Platform)\$(AssemblyName) + $(ObjFolder)$(Configuration).$(Platform)\$(AssemblyName) $(BinFolder)$(Configuration).$(Platform)\$(AssemblyName) - +