Merge IsPacketEmpty

Author: edwardneal

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.netcore.cs

@@ -100,8 +100,6 @@ internal abstract void CreatePhysicalSNIHandle(
 
         internal abstract void DisposePacketCache();
 
-        internal abstract bool IsPacketEmpty(PacketHandle readPacket);
-
         internal abstract PacketHandle ReadSyncOverAsync(int timeoutRemaining, out uint error);
 
         internal abstract PacketHandle ReadAsync(SessionHandle handle, out uint error);

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.netfx.cs

@@ -136,12 +136,6 @@ internal void CreatePhysicalSNIHandle(
                 ipPreference, cachedDNSInfo, hostNameInCertificate);
         }
 
-        internal bool IsPacketEmpty(PacketHandle readPacket)
-        {
-            Debug.Assert(readPacket.Type == PacketHandle.NativePointerType || readPacket.Type == 0, "unexpected packet type when requiring NativePointer");
-            return IntPtr.Zero == readPacket.NativePointer;
-        }
-
         internal PacketHandle ReadSyncOverAsync(int timeoutRemaining, out uint error)
         {
             SNIHandle handle = Handle ?? throw ADP.ClosedConnectionError();

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Diagnostics;
 using Interop.Windows.Sni;
 
 namespace Microsoft.Data.SqlClient
@@ -29,6 +30,12 @@ internal TdsParserStateObjectNative(TdsParser parser)
 
         internal override Guid? SessionId => default;
 
+        internal override bool IsPacketEmpty(PacketHandle readPacket)
+        {
+            Debug.Assert(readPacket.Type == PacketHandle.NativePointerType || readPacket.Type == 0, "unexpected packet type when requiring NativePointer");
+            return IntPtr.Zero == readPacket.NativePointer;
+        }
+
         internal override uint SniGetConnectionId(ref Guid clientConnectionId)
             => SniNativeWrapper.SniGetConnectionId(Handle, ref clientConnectionId);
 

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs

@@ -481,6 +481,8 @@ internal long TimeoutTime
 
         internal abstract SessionHandle SessionHandle { get; }
 
+        internal abstract bool IsPacketEmpty(PacketHandle readPacket);
+
         internal abstract uint SniGetConnectionId(ref Guid clientConnectionId);
 
         internal abstract uint DisableSsl();