Merge ReleasePacket

Author: edwardneal

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.netcore.cs

@@ -106,8 +106,6 @@ internal abstract void CreatePhysicalSNIHandle(
 
         internal abstract uint CheckConnection();
 
-        internal abstract void ReleasePacket(PacketHandle syncReadPacket);
-
         protected abstract uint SniPacketGetData(PacketHandle packet, byte[] _inBuff, ref uint dataSize);
 
         internal abstract PacketHandle GetResetWritePacket(int dataSize);

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.netfx.cs

@@ -153,12 +153,6 @@ internal PacketHandle ReadAsync(SessionHandle handle, out uint error)
 
         internal uint CheckConnection() => SniNativeWrapper.SniCheckConnection(Handle);
 
-        internal void ReleasePacket(PacketHandle syncReadPacket)
-        {
-            Debug.Assert(syncReadPacket.Type == PacketHandle.NativePointerType, "unexpected packet type when requiring NativePointer");
-            SniNativeWrapper.SniPacketRelease(syncReadPacket.NativePointer);
-        }
-
         [ReliabilityContract(Consistency.WillNotCorruptState, Cer.Success)]
         internal int DecrementPendingCallbacks(bool release)
         {

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs

@@ -36,6 +36,12 @@ internal override bool IsPacketEmpty(PacketHandle readPacket)
             return IntPtr.Zero == readPacket.NativePointer;
         }
 
+        internal override void ReleasePacket(PacketHandle syncReadPacket)
+        {
+            Debug.Assert(syncReadPacket.Type == PacketHandle.NativePointerType, "unexpected packet type when requiring NativePointer");
+            SniNativeWrapper.SniPacketRelease(syncReadPacket.NativePointer);
+        }
+
         internal override uint SniGetConnectionId(ref Guid clientConnectionId)
             => SniNativeWrapper.SniGetConnectionId(Handle, ref clientConnectionId);
 

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs

@@ -483,6 +483,8 @@ internal long TimeoutTime
 
         internal abstract bool IsPacketEmpty(PacketHandle readPacket);
 
+        internal abstract void ReleasePacket(PacketHandle syncReadPacket);
+
         internal abstract uint SniGetConnectionId(ref Guid clientConnectionId);
 
         internal abstract uint DisableSsl();