Switch to implicit object creation

Also enforce this via editorconfig

Author: edwardneal

src/Microsoft.Data.SqlClient/tests/UnitTests/.editorconfig

@@ -0,0 +1,11 @@
+# editorconfig.org
+
+# top-most EditorConfig file
+root = false
+
+[*.cs]
+
+csharp_style_var_when_type_is_apparent = false:refactor
+# IDE0090: Use 'new(...)'
+csharp_style_implicit_object_creation_when_type_is_apparent = true:warning
+

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/InvalidSerializationTest.cs

@@ -16,9 +16,9 @@ public class InvalidSerializationTest
     [Fact]
     public void RequiresSqlUserDefinedTypeAttribute()
     {
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
-        InvalidUdtException exception = Assert.Throws<InvalidUdtException>(
+        var exception = Assert.Throws<InvalidUdtException>(
             () => SerializationHelperSql9.Serialize(stream, new ClassMissingSqlUserDefinedTypeAttribute()));
 
         Assert.Equal($"'{typeof(ClassMissingSqlUserDefinedTypeAttribute).FullName}' is an invalid user defined type, reason: no UDT attribute.", exception.Message);
@@ -27,9 +27,9 @@ public void RequiresSqlUserDefinedTypeAttribute()
     [Fact]
     public void CannotSerializeUnknownFormattedType()
     {
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
-        ArgumentOutOfRangeException exception = Assert.Throws<ArgumentOutOfRangeException>("Format",
+        var exception = Assert.Throws<ArgumentOutOfRangeException>("Format",
             () => SerializationHelperSql9.Serialize(stream, new UnknownFormattedClass()));
 
 #if NET

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/NativeSerializationTest.cs

@@ -188,12 +188,12 @@ public void SerializeNullPrimitiveType(object primitive, byte[] expectedValue)
     [Fact]
     public void CanSerializeTopLevelClass()
     {
-        NestedBoolWrapperClass validWrapper = new NestedBoolWrapperClass()
+        NestedBoolWrapperClass validWrapper = new()
         {
             Field1 = true,
             Field2 = new BoolWrapperStruct() { Field1 = true }
         };
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
         SerializationHelperSql9.Serialize(stream, validWrapper);
     }
@@ -207,14 +207,14 @@ public void CanSerializeTopLevelClass()
     [Fact]
     public void CannotSerializeNestedClass()
     {
-        InvalidNestedBoolWrapperClass invalidWrapper = new InvalidNestedBoolWrapperClass()
+        InvalidNestedBoolWrapperClass invalidWrapper = new()
         {
             Field1 = true,
             Field2 = new BoolWrapperClass() { Field1 = true }
         };
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
-        Exception ex = Assert.Throws<Exception>(() => SerializationHelperSql9.Serialize(stream, invalidWrapper));
+        var ex = Assert.Throws<Exception>(() => SerializationHelperSql9.Serialize(stream, invalidWrapper));
         string expectedException = StringsHelper.GetString(Strings.SQL_CannotCreateNormalizer, invalidWrapper.Field2.GetType().FullName);
 
         Assert.Equal(expectedException, ex.Message);
@@ -227,14 +227,14 @@ public void CannotSerializeNestedClass()
     [Fact]
     public void CannotSerializeNonPrimitiveType()
     {
-        InvalidIntPtrAndByteWrapperStruct invalidWrapper = new InvalidIntPtrAndByteWrapperStruct()
+        InvalidIntPtrAndByteWrapperStruct invalidWrapper = new()
         {
             Field1 = 1,
             Field2 = IntPtr.Zero
         };
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
-        Exception ex = Assert.Throws<Exception>(() => SerializationHelperSql9.Serialize(stream, invalidWrapper));
+        var ex = Assert.Throws<Exception>(() => SerializationHelperSql9.Serialize(stream, invalidWrapper));
         string expectedException = StringsHelper.GetString(Strings.SQL_CannotCreateNormalizer, invalidWrapper.Field2.GetType().FullName);
 
         Assert.Equal(expectedException, ex.Message);
@@ -247,7 +247,7 @@ public void CannotSerializeNonPrimitiveType()
     /// <param name="expectedValue">Expected serialization output.</param>
     private static void RoundtripType(object inputValue, byte[] expectedValue)
     {
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
         object readPrimitive;
         int typeSize = SerializationHelperSql9.SizeInBytes(inputValue.GetType());
         int objectSize = SerializationHelperSql9.SizeInBytes(inputValue);

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/UserDefinedSerializationTest.cs

@@ -27,7 +27,7 @@ public void CanSerializeClass()
     [Fact]
     public void RequiresPublicParameterlessConstructor()
     {
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
         SerializationHelperSql9.Serialize(stream, new UserDefinedMissingPublicConstructor(true));
         stream.Seek(0, SeekOrigin.Begin);
@@ -39,7 +39,7 @@ public void RequiresPublicParameterlessConstructor()
     [Fact]
     public void RequiresIBinarySerializeImplementation()
     {
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
 
         Assert.Throws<InvalidCastException>(
             () => SerializationHelperSql9.Serialize(stream, new UserDefinedDoesNotImplementIBinarySerialize()));
@@ -48,7 +48,7 @@ public void RequiresIBinarySerializeImplementation()
     private static void RoundtripType<T>(T userObject)
         where T : IFormattingProgress
     {
-        using MemoryStream stream = new MemoryStream();
+        using MemoryStream stream = new();
         byte[] serializedValue;
         T readInstance;
         int typeSize = SerializationHelperSql9.SizeInBytes(userObject.GetType());