Remove redundant SmiRecordBuffer class

Author: edwardneal

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj

@@ -432,9 +432,6 @@
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs</Link>
     </Compile>
-    <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiRecordBuffer.cs">
-      <Link>Microsoft\Data\SqlClient\Server\SmiRecordBuffer.cs</Link>
-    </Compile>
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiSettersStream.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiSettersStream.cs</Link>
     </Compile>

src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj

@@ -543,9 +543,6 @@
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs</Link>
     </Compile>
-    <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiRecordBuffer.cs">
-      <Link>Microsoft\Data\SqlClient\Server\SmiRecordBuffer.cs</Link>
-    </Compile>
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiSettersStream.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiSettersStream.cs</Link>
     </Compile>

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MemoryRecordBuffer.cs

@@ -9,7 +9,7 @@
 namespace Microsoft.Data.SqlClient.Server
 {
     // Class for implementing a record object used in out-of-proc scenarios.
-    internal sealed class MemoryRecordBuffer : SmiRecordBuffer
+    internal sealed class MemoryRecordBuffer : SmiTypedGetterSetter
     {
         private SqlRecordBuffer[] _buffer;
 
@@ -25,6 +25,12 @@ internal MemoryRecordBuffer(SmiMetaData[] metaData)
             }
         }
 
+        #region Read/Write
+        protected override bool CanGet => true;
+
+        protected override bool CanSet => true;
+        #endregion
+
         #region Getters
         // Null test
         //      valid for all types

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SmiRecordBuffer.cs

@@ -14,7 +14,7 @@ namespace Microsoft.Data.SqlClient.Server
     /// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient.Server/SqlDataRecord.xml' path='docs/members[@name="SqlDataRecord"]/SqlDataRecord/*' />
     public partial class SqlDataRecord : IDataRecord
     {
-        private readonly SmiRecordBuffer _recordBuffer;
+        private readonly MemoryRecordBuffer _recordBuffer;
         private readonly SmiExtendedMetaData[] _columnSmiMetaData;
         private readonly SqlMetaData[] _columnMetaData;
         private FieldNameLookup _fieldNameLookup;

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SqlDataRecord.cs

@@ -11,7 +11,7 @@
 namespace Microsoft.Data.SqlClient
 {
     // TdsRecordBufferSetter handles writing a structured value out to a TDS stream
-    internal class TdsRecordBufferSetter : SmiRecordBuffer
+    internal class TdsRecordBufferSetter : SmiTypedGetterSetter
     {
         #region Fields (private)