Cleanup | Remove More Dead SMI Code (Part 2) (#3414)

* Oh hey, InOutOfProcHelper.InProc always returns false! Let's propagate that false everywhere it was being used to determine what other branches of code can be deleted

* Remove usages of IsInProc that were always false

* Remove dead code in SmiContextFactory and distill properties down to exceptions they will always throw b/c _smiLink will always be null

* Propagate always thrown exceptions, remove that code from SmiContextFactory

* Remove SmiVersion that was hardcoded to 2008. Propagate 2008 to all usages of the property
It can continue to be propagated if we find out the version is always the same...

* Remove SmiContextFactory.LatestVersion by replacing usage with 2008 and propagate that forward, allowing us to remove MetadataUtilsSmi.IsValidForSmiVersion and a block of code in SqlDataRecord

* Propagate 2008 version, which eliminates a bunch of conditions, eliminating the last uses of SmiVersion2008

* Delete the now unused SmiContextFactory class

* Remove _smiRequestContext from SqlCommand since it is always assigned `null`, replacing usages of it with `null`

* Remove context parameter from ValueUtilsSmi.GetOutputParameterV3Smi, since it is always passed to itself

* Remove context parameter from ValueUtilsSmi.GetOutputParameterV200Smi, since it is always passed to itself and is always null

* Delete ExecuteToPipe since it is no longer being used.

* Remove _recordContext from SqlDataRecord since it is always null, propagate null to all usages of it

* SqlInternalConnectionSmi.InternalContext is always null, deleting and propagating null to all usages of it
Also removing SqlInternalConnectionSmi.SmiConnection since it's never used.

* Removing SqlContext usages from ValueUtilsSmi - it was always null, so it can be eliminated

* Removing last references to SqlContext in SqlInternalConnectionSmi

* Delete SmiContext

* @edwardneal is a hero, deleting another bundle of unused code.

Author: benrr101

src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj

@@ -543,12 +543,6 @@
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiConnection.netfx.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiConnection.netfx.cs</Link>
     </Compile>
-    <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiContext.netfx.cs">
-      <Link>Microsoft\Data\SqlClient\Server\SmiContext.netfx.cs</Link>
-    </Compile>
-    <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiContextFactory.netfx.cs">
-      <Link>Microsoft\Data\SqlClient\Server\SmiContextFactory.netfx.cs</Link>
-    </Compile>
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiEventSink.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiEventSink.cs</Link>
     </Compile>
@@ -953,8 +947,6 @@
     </Compile>
 
     <Compile Include="Microsoft\Data\SqlClient\SqlBulkCopy.cs" />
-    <Compile Include="Microsoft\Data\SqlClient\SqlClientWrapperSmiStream.cs" />
-    <Compile Include="Microsoft\Data\SqlClient\SqlClientWrapperSmiStreamChars.cs" />
     <Compile Include="Microsoft\Data\SqlClient\SqlCommand.cs" />
     <Compile Include="Microsoft\Data\SqlClient\SqlConnection.cs" />
     <Compile Include="Microsoft\Data\SqlClient\SqlConnectionFactory.cs" />
@@ -968,7 +960,6 @@
     <Compile Include="Microsoft\Data\SqlClient\TdsParser.netfx.cs" />
     <Compile Include="Microsoft\Data\SqlClient\TdsParserStateObject.netfx.cs" />
     <Compile Include="Microsoft\Data\SqlClient\TdsParserStateObjectNative.cs" />
-    <Compile Include="Microsoft\Data\SqlTypes\SqlStreamChars.cs" />
     <Compile Include="Microsoft\Data\SqlTypes\SqlTypeWorkarounds.netfx.cs" />
   </ItemGroup>
   <!-- Resources  -->

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlClientWrapperSmiStream.cs

@@ -463,8 +463,8 @@ internal override void ParametersAvailable(SmiParameterMetaData[] metaData, ITyp
                         }
                     }
                 }
-
-                Debug.Assert(SmiContextFactory.Instance.NegotiatedSmiVersion >= SmiContextFactory.Sql2005Version);
+                
+                Debug.Fail("NegotiatedSmiVersion will always throw (SmiContextFactory.Instance.NegotiatedSmiVersion >= SmiContextFactory.Sql2005Version)");
                 _command.OnParametersAvailableSmi(metaData, parameterValues);
             }
 
@@ -474,12 +474,12 @@ internal override void ParameterAvailable(SmiParameterMetaData metaData, SmiType
                 {
                     SqlClientEventSource.Log.AdvancedTraceEvent("<sc.SqlCommand.CommandEventSink.ParameterAvailable|ADV> {0}, metaData[{1}] is {2}{ 3}", _command.ObjectID, ordinal, metaData?.GetType(), metaData?.TraceString());
                 }
-                Debug.Assert(SmiContextFactory.Instance.NegotiatedSmiVersion >= SmiContextFactory.Sql2008Version);
+
+                Debug.Fail("NegotiatedSmiVersion will always throw (SmiContextFactory.Instance.NegotiatedSmiVersion >= SmiContextFactory.Sql2008Version)");
                 _command.OnParameterAvailableSmi(metaData, parameterValues, ordinal);
             }
         }
 
-        private SmiContext _smiRequestContext; // context that _smiRequest came from
         private CommandEventSink _smiEventSink;
         private SmiEventSink_DeferredProcessing _outParamEventSink;
 
@@ -599,9 +599,6 @@ private SqlCommand(SqlCommand from) : this()
                     _transaction = null;
                 }
 
-                // If the connection has changes, then the request context may have changed as well
-                _smiRequestContext = null;
-
                 // Command is no longer prepared on new connection, cleanup prepare status
                 if (IsPrepared)
                 {
@@ -1560,32 +1557,6 @@ public override int ExecuteNonQuery()
             }
         }
 
-        // Handles in-proc execute-to-pipe functionality
-        //  Identical to ExecuteNonQuery
-        internal void ExecuteToPipe(SmiContext pipeContext)
-        {
-            SqlConnection.ExecutePermission.Demand();
-
-            // Reset _pendingCancel upon entry into any Execute - used to synchronize state
-            // between entry into Execute* API and the thread obtaining the stateObject.
-            _pendingCancel = false;
-
-            SqlStatistics statistics = null;
-
-            using (TryEventScope.Create("<sc.SqlCommand.ExecuteToPipe|INFO> {0}", ObjectID))
-            {
-                try
-                {
-                    statistics = SqlStatistics.StartTimer(Statistics);
-                    InternalExecuteNonQuery(null, nameof(ExecuteNonQuery), true, CommandTimeout, out _);
-                }
-                finally
-                {
-                    SqlStatistics.StopTimer(statistics);
-                }
-            }
-        }
-
         /// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlCommand.xml' path='docs/members[@name="SqlCommand"]/BeginExecuteNonQuery[@name="default"]/*'/>
         [System.Security.Permissions.HostProtectionAttribute(ExternalThreading = true)]
         public IAsyncResult BeginExecuteNonQuery()
@@ -6199,12 +6170,20 @@ internal void OnParameterAvailableSmi(SmiParameterMetaData metaData, ITypedGette
                     if (_activeConnection.Is2008OrNewer)
                     {
                         result = ValueUtilsSmi.GetOutputParameterV200Smi(
-                                OutParamEventSink, (SmiTypedGetterSetter)parameterValues, ordinal, metaData, _smiRequestContext, buffer);
+                                OutParamEventSink,
+                                (SmiTypedGetterSetter)parameterValues,
+                                ordinal,
+                                metaData,
+                                buffer);
                     }
                     else
                     {
                         result = ValueUtilsSmi.GetOutputParameterV3Smi(
-                                    OutParamEventSink, parameterValues, ordinal, metaData, _smiRequestContext, buffer);
+                                    OutParamEventSink,
+                                    parameterValues,
+                                    ordinal,
+                                    metaData,
+                                    buffer);
                     }
                     if (result != null)
                     {

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlClientWrapperSmiStreamChars.cs

@@ -1909,6 +1909,7 @@ private bool TryOpenInner(TaskCompletionSource<DbConnectionInternal> retry)
                 var tdsInnerConnection = (InnerConnection as SqlInternalConnectionTds);
                 if (tdsInnerConnection == null)
                 {
+                    // @TODO: This branch can't be called, because it'll automatically break. But I can't prove it isn't just yet....
                     SqlInternalConnectionSmi innerConnection = (InnerConnection as SqlInternalConnectionSmi);
                     innerConnection.AutomaticEnlistment();
                 }