Skip to content

Commit 7d809a8

Browse files
authored
Merge | SqlConnectionFactory (#3420)
* Merge SqlConnectionFactory.AssemblyLoadContext into netcore SqlConnectionFactory class Align netcore and netfx versions to make merge really easy * Create merge file * Resolving most of the merges, except a few that I need some help on. * Adding more stubs :) * Resolve remaining merge conflicts * Use the common file in both projects * Applying the change that I said I was going to apply in the last PR * PR Comments, Round 1
1 parent 12f742d commit 7d809a8

File tree

9 files changed

+121
-434
lines changed

9 files changed

+121
-434
lines changed

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,9 @@
591591
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlConnectionEncryptOptionConverter.cs">
592592
<Link>Microsoft\Data\SqlClient\SqlConnectionEncryptOptionConverter.cs</Link>
593593
</Compile>
594+
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlConnectionFactory.cs">
595+
<Link>Microsoft\Data\SqlClient\SqlConnectionFactory.cs</Link>
596+
</Compile>
594597
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlConnectionString.cs">
595598
<Link>Microsoft\Data\SqlClient\SqlConnectionString.cs</Link>
596599
</Compile>
@@ -806,10 +809,8 @@
806809
</Compile>
807810

808811
<Compile Include="Microsoft\Data\SqlClient\SqlAppContextSwitchManager.NetCoreApp.cs" />
809-
<Compile Include="Microsoft\Data\SqlClient\SqlConnectionFactory.AssemblyLoadContext.cs" />
810812
<Compile Include="Microsoft\Data\SqlClient\SqlCommand.cs" />
811813
<Compile Include="Microsoft\Data\SqlClient\SqlConnection.cs" />
812-
<Compile Include="Microsoft\Data\SqlClient\SqlConnectionFactory.cs" />
813814
<Compile Include="Microsoft\Data\SqlClient\SqlConnectionHelper.cs" />
814815
<Compile Include="Microsoft\Data\SqlClient\SqlInternalConnectionTds.cs" />
815816
<Compile Include="Microsoft\Data\SqlClient\TdsParser.cs" />

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnectionFactory.AssemblyLoadContext.cs

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,9 @@
741741
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlConnectionEncryptOptionConverter.cs">
742742
<Link>Microsoft\Data\SqlClient\SqlConnectionEncryptOptionConverter.cs</Link>
743743
</Compile>
744+
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlConnectionFactory.cs">
745+
<Link>Microsoft\Data\SqlClient\SqlConnectionFactory.cs</Link>
746+
</Compile>
744747
<Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SqlConnectionString.cs">
745748
<Link>Microsoft\Data\SqlClient\SqlConnectionString.cs</Link>
746749
</Compile>
@@ -951,7 +954,6 @@
951954

952955
<Compile Include="Microsoft\Data\SqlClient\SqlCommand.cs" />
953956
<Compile Include="Microsoft\Data\SqlClient\SqlConnection.cs" />
954-
<Compile Include="Microsoft\Data\SqlClient\SqlConnectionFactory.cs" />
955957
<Compile Include="Microsoft\Data\SqlClient\SqlConnectionHelper.cs" />
956958
<Compile Include="Microsoft\Data\SqlClient\SqlDataReaderSmi.cs" />
957959
<Compile Include="Microsoft\Data\SqlClient\SqlInternalConnectionSmi.cs" />

0 commit comments

Comments
 (0)