Sync method signature for CreatePhysicalSNIHandle

Author: edwardneal

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -450,6 +450,8 @@ internal void Connect(ServerInfo serverInfo,
                 false,
                 true,
                 fParallel,
+                TransparentNetworkResolutionState.DisabledMode,
+                -1,
                 _connHandler.ConnectionOptions.IPAddressPreference,
                 FQDNforDNSCache,
                 ref _connHandler.pendingSQLDNSObject,
@@ -550,6 +552,8 @@ internal void Connect(ServerInfo serverInfo,
                     true,
                     true,
                     fParallel,
+                    TransparentNetworkResolutionState.DisabledMode,
+                    -1,
                     _connHandler.ConnectionOptions.IPAddressPreference,
                     FQDNforDNSCache,
                     ref _connHandler.pendingSQLDNSObject,

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.netcore.cs

@@ -75,6 +75,8 @@ internal abstract void CreatePhysicalSNIHandle(
             bool flushCache,
             bool async,
             bool fParallel,
+            TransparentNetworkResolutionState transparentNetworkResolutionState,
+            int totalTimeout,
             SqlConnectionIPAddressPreference iPAddressPreference,
             string cachedFQDN,
             ref SQLDNSInfo pendingDNSInfo,

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs

@@ -85,6 +85,8 @@ internal override void CreatePhysicalSNIHandle(
             bool flushCache,
             bool async,
             bool parallel,
+            TransparentNetworkResolutionState transparentNetworkResolutionState,
+            int totalTimeout,
             SqlConnectionIPAddressPreference iPAddressPreference,
             string cachedFQDN,
             ref SQLDNSInfo pendingDNSInfo,

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs

@@ -162,7 +162,9 @@ internal override void CreatePhysicalSNIHandle(
             bool flushCache,
             bool async,
             bool fParallel,
-            SqlConnectionIPAddressPreference ipPreference,
+            TransparentNetworkResolutionState transparentNetworkResolutionState,
+            int totalTimeout,
+            SqlConnectionIPAddressPreference iPAddressPreference,
             string cachedFQDN,
             ref SQLDNSInfo pendingDNSInfo,
             string serverSPN,
@@ -191,7 +193,7 @@ internal override void CreatePhysicalSNIHandle(
             bool ret = SQLFallbackDNSCache.Instance.GetDNSInfo(cachedFQDN, out cachedDNSInfo);
 
             _sessionHandle = new SNIHandle(myInfo, serverName, ref serverSPN, timeout.MillisecondsRemainingInt, out instanceName,
-                flushCache, !async, fParallel, ipPreference, cachedDNSInfo, hostNameInCertificate);
+                flushCache, !async, fParallel, iPAddressPreference, cachedDNSInfo, hostNameInCertificate);
             spns = new[] { serverSPN.TrimEnd() };
         }
 

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -516,7 +516,12 @@ internal void Connect(ServerInfo serverInfo,
                 totalTimeout,
                 _connHandler.ConnectionOptions.IPAddressPreference,
                 FQDNforDNSCache,
-                hostNameInCertificate);
+                ref _connHandler.pendingSQLDNSObject,
+                serverInfo.ServerSPN,
+                integratedSecurity || authType == SqlAuthenticationMethod.ActiveDirectoryIntegrated,
+                isTlsFirst,
+                hostNameInCertificate,
+                serverCertificateFilename);
 
             _authenticationProvider?.Initialize(serverInfo, _physicalStateObj, this);
 
@@ -610,7 +615,12 @@ internal void Connect(ServerInfo serverInfo,
                     totalTimeout,
                     _connHandler.ConnectionOptions.IPAddressPreference,
                     serverInfo.ResolvedServerName,
-                    hostNameInCertificate);
+                    ref _connHandler.pendingSQLDNSObject,
+                    serverInfo.ServerSPN,
+                    integratedSecurity,
+                    isTlsFirst,
+                    hostNameInCertificate,
+                    serverCertificateFilename);
 
                 _authenticationProvider?.Initialize(serverInfo, _physicalStateObj, this);
 

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.netfx.cs

@@ -114,9 +114,14 @@ internal void CreatePhysicalSNIHandle(
             bool fParallel,
             TransparentNetworkResolutionState transparentNetworkResolutionState,
             int totalTimeout,
-            SqlConnectionIPAddressPreference ipPreference,
+            SqlConnectionIPAddressPreference iPAddressPreference,
             string cachedFQDN,
-            string hostNameInCertificate = "")
+            ref SQLDNSInfo pendingDNSInfo,
+            string serverSPN,
+            bool isIntegratedSecurity = false,
+            bool tlsFirst = false,
+            string hostNameInCertificate = "",
+            string serverCertificateFilename = "")
         {
             ConsumerInfo myInfo = CreateConsumerInfo(async);
 
@@ -127,7 +132,7 @@ internal void CreatePhysicalSNIHandle(
 
             _sessionHandle = new SNIHandle(myInfo, serverName, ref spn, timeout.MillisecondsRemainingInt,
                 out instanceName, flushCache, !async, fParallel, transparentNetworkResolutionState, totalTimeout,
-                ipPreference, cachedDNSInfo, hostNameInCertificate);
+                iPAddressPreference, cachedDNSInfo, hostNameInCertificate);
         }
 
         internal uint CheckConnection() => SniNativeWrapper.SniCheckConnection(Handle);