Initial work to enable Unix support.

* Only allow the use of the CurrentUser location for certificates.
* Changed the PublishTestResults@2 step to ensure that failed tests are also published.

Author: edwardneal

eng/pipelines/common/templates/steps/publish-test-results-step.yml

@@ -38,6 +38,7 @@ steps:
         TestResults/*.trx
         TestResults/**/*.coverage
       testRunTitle: 'Linux Tests'
+  condition: succeededOrFailed()
 
 - powershell: |
    cd TestResults

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlColumnEncryptionCertificateStoreProvider.cs

@@ -324,7 +324,9 @@ private void ValidateCertificatePathLength(string masterKeyPath, bool isSystemOp
         /// </summary>
         private string[] GetValidCertificateLocations()
         {
-            return new string[2] { CertLocationLocalMachine, CertLocationCurrentUser };
+            return Environment.OSVersion.Platform == PlatformID.Win32NT
+                ? new string[2] { CertLocationLocalMachine, CertLocationCurrentUser }
+                : new string[1] { CertLocationCurrentUser };
         }
 
         /// <summary>
@@ -372,7 +374,8 @@ private X509Certificate2 GetCertificateByPath(string keyPath, bool isSystemOp)
             // Extract the store location where the cert is stored
             if (certParts.Length > 2)
             {
-                if (string.Equals(certParts[0], CertLocationLocalMachine, StringComparison.OrdinalIgnoreCase) == true)
+                if (string.Equals(certParts[0], CertLocationLocalMachine, StringComparison.OrdinalIgnoreCase) == true
+                    && Environment.OSVersion.Platform == PlatformID.Win32NT)
                 {
                     storeLocation = StoreLocation.LocalMachine;
                 }

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs

@@ -1854,17 +1854,27 @@ internal static Exception InvalidCngKey(string masterKeyPath, string cngProvider
 
         internal static Exception InvalidCertificateLocation(string certificateLocation, string certificatePath, string[] validLocations, bool isSystemOp)
         {
-
-#if NETFRAMEWORK
-            Debug.Assert(2 == validLocations.Length);
-#endif
-            if (isSystemOp)
+            if (Environment.OSVersion.Platform == PlatformID.Win32NT)
             {
-                return ADP.Argument(StringsHelper.GetString(Strings.TCE_InvalidCertificateLocationSysErr, certificateLocation, certificatePath, validLocations[0], validLocations[1], @"/"), TdsEnums.TCE_PARAM_MASTERKEY_PATH);
+                if (isSystemOp)
+                {
+                    return ADP.Argument(StringsHelper.GetString(Strings.TCE_InvalidCertificateLocationSysErr, certificateLocation, certificatePath, validLocations[0], validLocations[1], @"/"), TdsEnums.TCE_PARAM_MASTERKEY_PATH);
+                }
+                else
+                {
+                    return ADP.Argument(StringsHelper.GetString(Strings.TCE_InvalidCertificateLocation, certificateLocation, certificatePath, validLocations[0], validLocations[1], @"/"), TdsEnums.TCE_PARAM_MASTERKEY_PATH);
+                }
             }
             else
             {
-                return ADP.Argument(StringsHelper.GetString(Strings.TCE_InvalidCertificateLocation, certificateLocation, certificatePath, validLocations[0], validLocations[1], @"/"), TdsEnums.TCE_PARAM_MASTERKEY_PATH);
+                if (isSystemOp)
+                {
+                    return ADP.Argument(StringsHelper.GetString(Strings.TCE_InvalidCertificateLocationSysErr_Unix, certificateLocation, certificatePath, validLocations[0], @"/"), TdsEnums.TCE_PARAM_MASTERKEY_PATH);
+                }
+                else
+                {
+                    return ADP.Argument(StringsHelper.GetString(Strings.TCE_InvalidCertificateLocation_Unix, certificateLocation, certificatePath, validLocations[0], @"/"), TdsEnums.TCE_PARAM_MASTERKEY_PATH);
+                }
             }
         }
 

src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs

@@ -4071,9 +4071,15 @@
   <data name="TCE_InvalidCertificateLocation" xml:space="preserve">
     <value>Invalid certificate location '{0}' in certificate path '{1}'. Use the following format: &lt;certificate location&gt;{4}&lt;certificate store&gt;{4}&lt;certificate thumbprint&gt;, where &lt;certificate location&gt; is either '{2}' or '{3}'.</value>
   </data>
+  <data name="TCE_InvalidCertificateLocation_Unix" xml:space="preserve">
+    <value>Invalid certificate location '{0}' in certificate path '{1}'. Use the following format: &lt;certificate location&gt;{3}&lt;certificate store&gt;{3}&lt;certificate thumbprint&gt;, where &lt;certificate location&gt; is '{2}'.</value>
+  </data>
   <data name="TCE_InvalidCertificateLocationSysErr" xml:space="preserve">
     <value>Internal error. Invalid certificate location '{0}' in certificate path '{1}'. Use the following format: &lt;certificate location&gt;{4}&lt;certificate store&gt;{4}&lt;certificate thumbprint&gt;, where &lt;certificate location&gt; is either '{2}' or '{3}'.</value>
   </data>
+  <data name="TCE_InvalidCertificateLocationSysErr_Unix" xml:space="preserve">
+    <value>Internal error. Invalid certificate location '{0}' in certificate path '{1}'. Use the following format: &lt;certificate location&gt;{3}&lt;certificate store&gt;{3}&lt;certificate thumbprint&gt;, where &lt;certificate location&gt; is '{2}'.</value>
+  </data>
   <data name="TCE_InvalidCertificateStore" xml:space="preserve">
     <value>Invalid certificate store '{0}' specified in certificate path '{1}'. Expected value: '{2}'.</value>
   </data>

src/Microsoft.Data.SqlClient/src/Resources/Strings.resx

@@ -495,12 +495,17 @@ public class ValidCertificatePathsParameters : DataAttribute
             public override IEnumerable<Object[]> GetData(MethodInfo testMethod)
             {
                 yield return new object[2] { CurrentUserMyPathPrefix, StoreLocation.CurrentUser };
-                yield return new object[2] { MyPathPrefix, null };
-                yield return new object[2] { @"", null };
-                // use localmachine cert path only when current user is Admin.
-                if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && CertificateFixture.IsAdmin)
+
+                // use localmachine cert path (or a location in the cert path which defaults to localmachine) only when current user is Admin.
+                if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
                 {
-                    yield return new object[2] { LocalMachineMyPathPrefix, StoreLocation.LocalMachine };
+                    yield return new object[2] { @"", null };
+                    yield return new object[2] { MyPathPrefix, null };
+
+                    if (CertificateFixture.IsAdmin)
+                    {
+                        yield return new object[2] { LocalMachineMyPathPrefix, StoreLocation.LocalMachine };
+                    }
                 }
             }
         }