Skip to content

Commit 02470f2

Browse files
committed
Addressing the last of the comments.
1 parent f394b97 commit 02470f2

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/SQLSetupStrategy.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class SQLSetupStrategy : ColumnMasterKeyCertificateFixture
1717
{
1818
internal const string ColumnEncryptionAlgorithmName = @"AEAD_AES_256_CBC_HMAC_SHA256";
1919

20-
public string ColumnMasterKeyPath { get; protected set; }
20+
public string ColumnMasterKeyPath { get; }
2121
public Table ApiTestTable { get; private set; }
2222
public Table BulkCopyAEErrorMessageTestTable { get; private set; }
2323
public Table BulkCopyAETestTable { get; private set; }
@@ -61,7 +61,7 @@ public class SQLSetupStrategy : ColumnMasterKeyCertificateFixture
6161
public SQLSetupStrategy()
6262
: base(true)
6363
{
64-
ColumnMasterKeyPath = string.Format("{0}/{1}/{2}", StoreLocation.CurrentUser, StoreName.My, ColumnMasterKeyCertificate.Thumbprint);
64+
ColumnMasterKeyPath = $"{StoreLocation.CurrentUser}/{StoreName.My}/{ColumnMasterKeyCertificate.Thumbprint}";
6565
}
6666

6767
protected SQLSetupStrategy(string customKeyPath)

src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Fixtures/CertificateFixtureBase.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ namespace Microsoft.Data.SqlClient.TestUtilities.Fixtures
1414
{
1515
public abstract class CertificateFixtureBase : IDisposable
1616
{
17+
/// <summary>
18+
/// Certificates must be created using this provider. Certificates created by PowerShell
19+
/// using another provider aren't accessible from RSACryptoServiceProvider, which means
20+
/// that we could not roundtrip between SqlColumnEncryptionCertificateStoreProvider and
21+
/// SqlColumnEncryptionCspProvider.
22+
/// </summary>
1723
private const string CspProviderName = "Microsoft Enhanced RSA and AES Cryptographic Provider";
1824

1925
private sealed class CertificateStoreContext

0 commit comments

Comments
 (0)