-
Notifications
You must be signed in to change notification settings - Fork 85
Open
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
OpenShift version
Not related to OpenShift
Problem description
I've recently run across a situation where I wanted to set up a pelorus development environment in a workspace where I was using ZSHELL. This doesn't work because some of our scripts rely on bash specific environment variables
Steps to reproduce
- install
zsh - switch to a zsh terminal by running
zsh - run
make dev-env
Current behavior
make dev-env will fail with an error like the following:
Downloading https://get.helm.sh/helm-v3.15.3-linux-amd64.tar.gz
Preparing to install helm into .venv/bin
helm installed into .venv/bin/helm
helm is /projects/pelorus/.venv/bin/helm
Installing tkn CLI to: .venv/bin/tkn
Traceback (most recent call last):
File "/projects/pelorus/scripts/get_tool_dl_url.py", line 12, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
Cleaning up temporary files
make: *** [Makefile:75: cli_dev_tools] Error 2
Expected behavior
make dev-env should succeed. I expect there are probably a few other areas besides this one that would need cleaned up in order to allow zsh users to use the scripts, but we won't know until we get past this one.
Code of Conduct
- I agree to follow Pelorus's Code of Conduct
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.