Skip to content

Developer Experience: allow pelorus devs to use ZSH #1143

@etsauer

Description

@etsauer

OpenShift version

Not related to OpenShift

Problem description

I've recently run across a situation where I wanted to set up a pelorus development environment in a workspace where I was using ZSHELL. This doesn't work because some of our scripts rely on bash specific environment variables

Steps to reproduce

  1. install zsh
  2. switch to a zsh terminal by running zsh
  3. run make dev-env

Current behavior

make dev-env will fail with an error like the following:

Downloading https://get.helm.sh/helm-v3.15.3-linux-amd64.tar.gz
Preparing to install helm into .venv/bin
helm installed into .venv/bin/helm
helm is /projects/pelorus/.venv/bin/helm
Installing tkn CLI to: .venv/bin/tkn
Traceback (most recent call last):
  File "/projects/pelorus/scripts/get_tool_dl_url.py", line 12, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'
Cleaning up temporary files
make: *** [Makefile:75: cli_dev_tools] Error 2

Expected behavior

make dev-env should succeed. I expect there are probably a few other areas besides this one that would need cleaned up in order to allow zsh users to use the scripts, but we won't know until we get past this one.

Code of Conduct

  • I agree to follow Pelorus's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions